Patch Detail
Show a patch.
GET /api/patches/22278/?format=api
{ "id": 22278, "url": "https://patchwork.libcamera.org/api/patches/22278/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22278/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241210153440.1007470-3-mzamazal@redhat.com>", "date": "2024-12-10T15:34:32", "name": "[v3,2/9] libcamera: software_isp: Store color temperature to metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "84ff8fa1cc97db4f117105bb65972e10564a8991", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22278/mbox/", "series": [ { "id": 4871, "url": "https://patchwork.libcamera.org/api/series/4871/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4871", "date": "2024-12-10T15:34:30", "name": "Software ISP support for CCM", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4871/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22278/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22278/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 236C8C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Dec 2024 15:35:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DF6267E9C;\n\tTue, 10 Dec 2024 16:35:04 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C5D2618AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Dec 2024 16:35:01 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-581-mFHSnwX5ObyQuYUvOAMuhQ-1;\n\tTue, 10 Dec 2024 10:34:57 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 0FFD619560AE; Tue, 10 Dec 2024 15:34:56 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.8])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 9864D1956048; Tue, 10 Dec 2024 15:34:53 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"g5ArjwSz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1733844900;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=o+skvZc9lwOz3/59AJO3klIRfx6lq74PoAggKly2A7I=;\n\tb=g5ArjwSzp/TJ/2dLDByV783tiYIVZQ43yw3pu2ck1HTNMkC1u7scReaSsWtL0OEmuL5F1Y\n\tsv0gTYcfw1HHhC+2WnemN60v3I/CLpMo45bTbFIyW0VQ06ygEVvHhG80l+5ErAMvDr3g0j\n\tpetQxnxStbgbIHGUeHsWeHtONy7EAFw=", "X-MC-Unique": "mFHSnwX5ObyQuYUvOAMuhQ-1", "X-Mimecast-MFC-AGG-ID": "mFHSnwX5ObyQuYUvOAMuhQ", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 2/9] libcamera: software_isp: Store color temperature to\n\tmetadata", "Date": "Tue, 10 Dec 2024 16:34:32 +0100", "Message-ID": "<20241210153440.1007470-3-mzamazal@redhat.com>", "In-Reply-To": "<20241210153440.1007470-1-mzamazal@redhat.com>", "References": "<20241210153440.1007470-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "VxMJpuCg_OhE8_FqWzdQEUYwl_KYuYor9HYrghTJ3F0_1733844896", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Image color temperature is a piece of information that should be\nreported in metadata, let's put it there.\n\nMetadata is currently not reported in simple pipeline but we should make\nat least newly added information ready to be reported.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex f4fe1af6..30af3d31 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -12,6 +12,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include <libcamera/control_ids.h>\n+\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n@@ -34,7 +36,7 @@ void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n-\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t ControlList &metadata)\n {\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n@@ -63,6 +65,7 @@ void Awb::process(IPAContext &context,\n \tRGB<double> rgbGains{ { 1 / gains.red, 1 / gains.green, 1 / gains.blue } };\n \tuint32_t temperature = estimateCCT(rgbGains);\n \tcontext.activeState.awb.temperatureK = temperature;\n+\tmetadata.set(controls::ColourTemperature, temperature);\n \n \tLOG(IPASoftAwb, Debug)\n \t\t<< \"gain R/B: \" << gains.red << \"/\" << gains.blue\n", "prefixes": [ "v3", "2/9" ] }