Patch Detail
Show a patch.
GET /api/patches/22261/?format=api
{ "id": 22261, "url": "https://patchwork.libcamera.org/api/patches/22261/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22261/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241209171128.270901-1-barnabas.pocze@ideasonboard.com>", "date": "2024-12-09T17:11:28", "name": "[libcamera-ci,v2] Enable `cpp_debugstl`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5e1a9f3979029c2f4383adb1416b5d5d13bd5eb2", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22261/mbox/", "series": [ { "id": 4868, "url": "https://patchwork.libcamera.org/api/series/4868/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4868", "date": "2024-12-09T17:11:28", "name": "[libcamera-ci,v2] Enable `cpp_debugstl`", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4868/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22261/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22261/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 213ABBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 9 Dec 2024 17:11:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E6F767E69;\n\tMon, 9 Dec 2024 18:11:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F11266132\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Dec 2024 18:11:37 +0100 (CET)", "from pb-laptop.tail49a43.ts.net (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B04F5502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Dec 2024 18:11:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q8U1XYpX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733764265;\n\tbh=CRflvJYj94S5hjYBJ0u69gEHfO01zGh6nF5BAaVkSFw=;\n\th=From:To:Subject:Date:From;\n\tb=Q8U1XYpX7+zmqotaCtDtEQsSrvWgOdC8wteW7mhIUcRxA+x1g3zciVKD9hIj4N+eN\n\t0WAsLCsdo4y7TP8bTfy4rCbsKSMg4iWcgefX/FY5eZ3DskIaPSAjFJBTiVJS/JYwS3\n\tOlM0kQ3KLNhLio8fqgHvlliLuIpRKr+mhWP/6ohk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [PATCH v2] Enable `cpp_debugstl`", "Date": "Mon, 9 Dec 2024 18:11:28 +0100", "Message-ID": "<20241209171128.270901-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Meson's `cpp_debugstl` built-in option enables extra checks\nin libstdc++ and libc++, such as iterator invalidation tests,\nbounds checking in the `operator[]` of multiple types, etc.\nby setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n\nEnable it in the same cases ASan is enabled as they are\nsomewhat similar debugging tools.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nhttps://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1326230\n\nChanges in v2:\n * do not rebuild containers\n * note that it is enabled when ASan is enabled\n---\n gitlab-ci.yml | 2 ++\n 1 file changed, 2 insertions(+)\n\n--\n2.47.1", "diff": "diff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex ea038ec..c78235e 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -15,6 +15,7 @@ variables:\n -D android=enabled\n -D b_sanitize=address\n -D cam=enabled\n+ -D cpp_debugstl=true\n -D documentation=enabled\n -D gstreamer=enabled\n -D lc-compliance=enabled\n@@ -389,6 +390,7 @@ test-unit:\n MESON_OPTIONS: >-\n -D b_sanitize=address\n -D cam=disabled\n+ -D cpp_debugstl=true\n -D documentation=disabled\n -D gstreamer=enabled\n -D lc-compliance=disabled\n", "prefixes": [ "libcamera-ci", "v2" ] }