Patch Detail
Show a patch.
GET /api/patches/22189/?format=api
{ "id": 22189, "url": "https://patchwork.libcamera.org/api/patches/22189/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22189/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241205192519.49104-3-hdegoede@redhat.com>", "date": "2024-12-05T19:25:16", "name": "[resend,2/5] libcamera: swstats_cpu: Drop patternSize_ documentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "59741e75c523b0031de9169f512623c1b3987ba1", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22189/mbox/", "series": [ { "id": 4853, "url": "https://patchwork.libcamera.org/api/series/4853/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4853", "date": "2024-12-05T19:25:14", "name": "libcamera: Add swstats_cpu::processFrame()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4853/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22189/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22189/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61235BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 5 Dec 2024 19:25:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00C596611B;\n\tThu, 5 Dec 2024 20:25:39 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60D3066114\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Dec 2024 20:25:36 +0100 (CET)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-178-w7chssjnP7yXs_vUsteJXA-1;\n\tThu, 05 Dec 2024 14:25:32 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2634319560BD; Thu, 5 Dec 2024 19:25:31 +0000 (UTC)", "from localhost.localdomain (unknown [10.39.192.39])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A9B5A19560A0; Thu, 5 Dec 2024 19:25:29 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Rd3NePE5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1733426735;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=3IA9KdyRpz/t1m8U6ZGcZvVeTZf1xWFVPDwNGYmpB00=;\n\tb=Rd3NePE5kKoRR7ncJEX8JquxXFFwmHn5+ySMZmxvxRumWj14gJniUf2GeIh8+Rh20mP3mv\n\twIwhbMrKUL2XJ5lfhF8U9l5MBBtbH0XPOZKYEUwVzcBPKIsnxFEwo30B4XaV6omJWxx7xn\n\tAw2KA4Yv3l744QUdwG6/BtprQ5THBlU=", "X-MC-Unique": "w7chssjnP7yXs_vUsteJXA-1", "X-Mimecast-MFC-AGG-ID": "w7chssjnP7yXs_vUsteJXA", "From": "Hans de Goede <hdegoede@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH resend 2/5] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation", "Date": "Thu, 5 Dec 2024 20:25:16 +0100", "Message-ID": "<20241205192519.49104-3-hdegoede@redhat.com>", "In-Reply-To": "<20241205192519.49104-1-hdegoede@redhat.com>", "References": "<20241205192519.49104-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "3BM0BEndX3wCz74Hv7ipCtJkGvIZ8wgtG4WElhZKQ3w_1733426731", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "patternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex a9a3e77a..5e4246a9 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -112,13 +114,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n", "prefixes": [ "resend", "2/5" ] }