Patch Detail
Show a patch.
GET /api/patches/22187/?format=api
{ "id": 22187, "url": "https://patchwork.libcamera.org/api/patches/22187/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22187/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241205192519.49104-2-hdegoede@redhat.com>", "date": "2024-12-05T19:25:15", "name": "[resend,1/5] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c0b0044db5a2947d522938c71bb1d10b3806dc1d", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22187/mbox/", "series": [ { "id": 4853, "url": "https://patchwork.libcamera.org/api/series/4853/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4853", "date": "2024-12-05T19:25:14", "name": "libcamera: Add swstats_cpu::processFrame()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4853/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22187/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22187/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F460BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 5 Dec 2024 19:25:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3074E66116;\n\tThu, 5 Dec 2024 20:25:34 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADBBD66114\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Dec 2024 20:25:32 +0100 (CET)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-427-Pn8qSfC8MSqWEh-oIoJM7Q-1;\n\tThu, 05 Dec 2024 14:25:30 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 41EB919560BF; Thu, 5 Dec 2024 19:25:29 +0000 (UTC)", "from localhost.localdomain (unknown [10.39.192.39])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DAC321956095; Thu, 5 Dec 2024 19:25:27 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"X3F6R6Gj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1733426731;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=iwl/81QLODj9g4E5//7BryIL0atSwd2fJmIrEGm167k=;\n\tb=X3F6R6GjWvKmsUxaCJekq8EtEP+ABWv+Q8bekVoey8H/INuphPN6xYsBh/bXdwAQiAX7uX\n\tQD/T+/5rdPShJtSasBoSi+rmMQDunP0udy8vmnVFXmS16L6hTvHG8JOd7TgM4lFQu902ub\n\tkFFUlizRicPqyX8axeJXOe2cSWxwpLA=", "X-MC-Unique": "Pn8qSfC8MSqWEh-oIoJM7Q-1", "X-Mimecast-MFC-AGG-ID": "Pn8qSfC8MSqWEh-oIoJM7Q", "From": "Hans de Goede <hdegoede@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH resend 1/5] libcamera: swstats_cpu: Update statsProcessFn() /\n\tprocessLine0() documentation", "Date": "Thu, 5 Dec 2024 20:25:15 +0100", "Message-ID": "<20241205192519.49104-2-hdegoede@redhat.com>", "In-Reply-To": "<20241205192519.49104-1-hdegoede@redhat.com>", "References": "<20241205192519.49104-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "23gECPCy-pgsFleEWsI9w042vsWJF179lPLTvPJJJGQ_1733426729", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the documentation of the statsProcessFn() / processLine0() src[]\npointer argument to take into account that swstats_cpu may also be used\nwith planar input data or with non Bayer single plane input data.\n\nThe statsProcessFn typedef is private, so no documentation is generated\nfor it. Move the new updated src[] pointer argument documentation to\nprocessLine0() so that it gets included in the generated docs.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 27 +++++++++++-----------\n 1 file changed, 13 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex c520c806..a9a3e77a 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -71,6 +71,19 @@ namespace libcamera {\n * patternSize height == 1.\n * It'll process line 0 and 1 for input formats with patternSize height >= 2.\n * This function may only be called after a successful setWindow() call.\n+ *\n+ * This function takes an array of src pointers each pointing to a line in\n+ * the source image.\n+ *\n+ * Bayer input data requires (patternSize_.height + 1) src pointers, with\n+ * the middle element of the array pointing to the actual line being processed.\n+ * Earlier element(s) will point to the previous line(s) and later element(s)\n+ * to the next line(s). See the DebayerCpu::debayerFn documentation for details.\n+ *\n+ * Planar input data requires a src pointer for each plane, with src[0] pointing\n+ * to the line in plane 0, etc.\n+ *\n+ * For non Bayer single plane input data only a single src pointer is required.\n */\n \n /**\n@@ -89,20 +102,6 @@ namespace libcamera {\n * \\brief Signals that the statistics are ready\n */\n \n-/**\n- * \\typedef SwStatsCpu::statsProcessFn\n- * \\brief Called when there is data to get statistics from\n- * \\param[in] src The input data\n- *\n- * These functions take an array of (patternSize_.height + 1) src\n- * pointers each pointing to a line in the source image. The middle\n- * element of the array will point to the actual line being processed.\n- * Earlier element(s) will point to the previous line(s) and later\n- * element(s) to the next line(s).\n- *\n- * See the documentation of DebayerCpu::debayerFn for more details.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::ySkipMask_\n * \\brief Skip lines where this bitmask is set in y\n", "prefixes": [ "resend", "1/5" ] }