Patch Detail
Show a patch.
GET /api/patches/22145/?format=api
{ "id": 22145, "url": "https://patchwork.libcamera.org/api/patches/22145/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22145/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241202090457.584020-1-chenghaoyang@chromium.org>", "date": "2024-12-02T09:04:53", "name": "Thread: Fix setThreadAffinity issue", "commit_ref": "d49a84a4f3aa63efc900564ff32558e4f5d85b04", "pull_url": null, "state": "accepted", "archived": false, "hash": "0cd427fef2f78475a1c6a33b504877ac9a479b53", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22145/mbox/", "series": [ { "id": 4836, "url": "https://patchwork.libcamera.org/api/series/4836/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4836", "date": "2024-12-02T09:04:53", "name": "Thread: Fix setThreadAffinity issue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4836/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22145/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22145/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 212CCBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 2 Dec 2024 09:05:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 324386605C;\n\tMon, 2 Dec 2024 10:05:07 +0100 (CET)", "from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com\n\t[IPv6:2607:f8b0:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8960266010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 2 Dec 2024 10:05:04 +0100 (CET)", "by mail-pl1-x62f.google.com with SMTP id\n\td9443c01a7336-21278f3d547so27850065ad.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 02 Dec 2024 01:05:04 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-215219058b1sm72313265ad.74.2024.12.02.01.05.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Dec 2024 01:05:02 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"NiINeg8e\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1733130303; x=1733735103;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Fa4+Y79PGTprbqZeJm96PuesJyixiLSaHg4DvuyNYnY=;\n\tb=NiINeg8eulcgIhsVHmzBeG8UKvHMMlm3pxSQaqjBC+1LybqROHJuoH/kUKALPC0Xis\n\tp5+agTGO/zl84k3v2Rj2mqKt0w6VOi/h/XHYTz8NNmfSN8m2u5Bym5wbeY91Caqzmv51\n\tpPJuF2MXlQQXTn9V0HR1aX82bMm6nhs7ss2UM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733130303; x=1733735103;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Fa4+Y79PGTprbqZeJm96PuesJyixiLSaHg4DvuyNYnY=;\n\tb=q+81NcHdj1huuyFhVeuHmkFMlt1P2CKWPolgNCwsQunafr0jUS+PejbqdmlBwrib+8\n\tDrWtcLLzObfYbsn/GEK3WX8KxRCQxd7Vlp3BDsE/1E7fFwPOWQaRaStBuf05ax0fUyf1\n\ttyJ/zG3RcpfaiiQgdhEuTwS6QqaAdrvQRBKF1wQHygBKzyZRtV+ncqLyUL4hU2R4EcPa\n\trCw4u3gT7Y3cPC3po0j45YzpgLpbrk3v7chs0LkHPqw2ncyVfXgOqAw3FfEwasOge2v4\n\tYl+5kzLLX7+LqVgmNTK15Xnn9Te/ZhuDW/F9/XylAuwTsuahMMWueYJeZvk9c5yoVF7s\n\tJ41w==", "X-Gm-Message-State": "AOJu0Yz+BQBsg5i8pC9ysgqn+DhYW+by4Kml2vahAPSkFXPHEZFUewEN\n\t3L3IiUJkWci+un68EGiARtonHl/B/gIIuOoQ85sNB9CBdgQ88fII311fG51fxJQHRr7usBu8W0m\n\tyKg==", "X-Gm-Gg": "ASbGnctbyPL5cRxzH2os4s7b7NoZhauz2TP5wNEzJSAYxOYgR39vS7O3+j/CZkN1NUz\n\tM5keVlTkvCBK6TxQxwRmy4x37gtsW7mnoJhkc3YMoK7VUdcG3x/KcbraRMNSnjkXdHe8sbZfkyk\n\tKQhWcinLmoadVoTLNjwoFatui8vNF/Nnj1CV15LJQ7E3ZEUQELL6jg3mUYiiNVfjvlY3XWuQYTa\n\tPNiaRdbkj+4gzJSaeO/4LT9BMmRqCpWN4+zBN3tD9B5cNqXzCouo1n/gDKIcpF6vARCTUvp+MXy\n\t9ZxjX53efjAzA1VGjp+kACxb+StAY8PP11kWIre8TLrJSayWYfTxYZFU", "X-Google-Smtp-Source": "AGHT+IHxUSd6p3GSKP94M+qwrx0cZK3g9e9YO8Aftv6eMNzuTcuW53W+bzI2Yp8BvD3z5uawL+kigQ==", "X-Received": "by 2002:a17:902:f543:b0:215:9ed9:932f with SMTP id\n\td9443c01a7336-2159ed994c7mr21004855ad.55.1733130302690; \n\tMon, 02 Dec 2024 01:05:02 -0800 (PST)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH] Thread: Fix setThreadAffinity issue", "Date": "Mon, 2 Dec 2024 09:04:53 +0000", "Message-ID": "<20241202090457.584020-1-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.338.g60cca15819-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This fixes commit 4d9db06d669044c0c461a2aed79c85c7fe32a502.\n\nPreviously we call Thread::setThreadAffinityInternal in\nThread::startThread, which seems to lead to a SEGV in\npthread_setaffinity_np.\n\nThis patch moves the call after the construction of std::thread.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/libcamera/base/thread.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex f6322fe31..319bfda9a 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -257,6 +257,8 @@ void Thread::start()\n \tdata_->exit_.store(false, std::memory_order_relaxed);\n \n \tthread_ = std::thread(&Thread::startThread, this);\n+\n+\tsetThreadAffinityInternal();\n }\n \n void Thread::startThread()\n@@ -284,8 +286,6 @@ void Thread::startThread()\n \tdata_->tid_ = syscall(SYS_gettid);\n \tcurrentThreadData = data_;\n \n-\tsetThreadAffinityInternal();\n-\n \trun();\n }\n \n", "prefixes": [] }