Patch Detail
Show a patch.
GET /api/patches/22134/?format=api
{ "id": 22134, "url": "https://patchwork.libcamera.org/api/patches/22134/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22134/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241129055331.2490988-3-chenghaoyang@chromium.org>", "date": "2024-11-29T05:52:19", "name": "[v6,2/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor properties", "commit_ref": "8e0e6886f7522e161839c9c9ea42a6552d8c6cdf", "pull_url": null, "state": "accepted", "archived": false, "hash": "40e60c88343f55ecdd82798cdae9e82a3a7ac45e", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22134/mbox/", "series": [ { "id": 4832, "url": "https://patchwork.libcamera.org/api/series/4832/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4832", "date": "2024-11-29T05:52:17", "name": "Add camera sensor properties for ciri", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4832/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22134/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22134/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5E94C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Nov 2024 05:53:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7393A65FFA;\n\tFri, 29 Nov 2024 06:53:45 +0100 (CET)", "from mail-pf1-x431.google.com (mail-pf1-x431.google.com\n\t[IPv6:2607:f8b0:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FB4965FE2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Nov 2024 06:53:41 +0100 (CET)", "by mail-pf1-x431.google.com with SMTP id\n\td2e1a72fcca58-724d8422f37so1267627b3a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Nov 2024 21:53:41 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7fc9c2e537fsm2029676a12.24.2024.11.28.21.53.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Nov 2024 21:53:38 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"gjmVRSmb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732859619; x=1733464419;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=SxKMVpxfI6WGI4nwOpzHjrREB0HhKaGiUooWehNfeSs=;\n\tb=gjmVRSmbjzcs11/fgkM8QEtw6lAYDc1s2xUSaTznLpWwvb5yPLv5kr77vafUEt7O7I\n\t7RDzDeVvOt0eXZuY8gBKtE3Ec/Z0BOlgBiG6SO957uJsi7osOMjL1wQaKmtUZmpPTLa8\n\tzbTMmsjFtL1AAsgLi2k3I1GlM2/3WU6gdb4V0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732859619; x=1733464419;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=SxKMVpxfI6WGI4nwOpzHjrREB0HhKaGiUooWehNfeSs=;\n\tb=QLz3oWcGIrQ2xOmExLq2/PmIAu0Efm3XhauWJ/kYcBzeUgM+NacOZZNIbMyWB1Foxz\n\t2DblWxEKq7AOttnVe6CSindR0a2kWgNDW9V4t75ap1JZvtctogmnoLySK/srrNWAdVWC\n\twi7GLMNlqsLS8qwA8W90UL3/V6S3bMRLpC4aJI7oHIRJGYi2J3gAzTlWRKmaFiUY69qz\n\tq9CkvT8WJShIchezLoAtdDnA4pc1Cv7RInGKEka8qityaFMb53X+K0BsiV0nICbwpwTZ\n\tvHKkLfDtkY/P+OfHx8lJWLEUnJzh0y4YkL2p/HkxC+mz9gpGGtQe57c8+fAQsnip8zjO\n\tDD+Q==", "X-Gm-Message-State": "AOJu0YzGHtiKQpfPKjnu+G8fjllj68SeUmgrVCosLy+hTZrBYN2RiRsU\n\to0Keiln+FsgPuK67N0olNd5gPtlIHvhDQah0m85OGzOdRIzOwc6kmxHJ/CDgNH/wYszNbNDB54Q\n\tstQ==", "X-Gm-Gg": "ASbGncubFGN+NPE8b301QgZ2JH+gQOWF49h4czWTqOdP7XtxhSX0EPMySmUkjCeni2e\n\te2jqcv9TvSvGYRj8LvQZP0+JDtsMXyS8KNaZs7R03Z/bFtknH1fGzvB+wOemuyjjpOWsTkUWNXV\n\tov9FrUpk18tGUlieUcz4w4p+bXxyTWrujaYXrB8zKEY9GUCXj1lrssf6NgpY/FjVf8Kp/eq9W49\n\ti57682LOfQ5J2Bq8HEl9rBHdMNZSedaosEaAjBoNWXNH4hA5QkDRHs7Pkwmqmzf5u2pVN4ubOpR\n\t2oL0WGOYGL9VwFpQX1Jxtb8F5iYuYGELZw0iVhKEsHzrYCiT5OJsIQ7s", "X-Google-Smtp-Source": "AGHT+IFg4iufyXyeEDrLREP48+M2FY0/gQ5LJsjaay3RXCbpksr+ZUfvb/32yUWvilJRdvzBTX8g/Q==", "X-Received": "by 2002:a05:6a00:4b11:b0:71e:573f:5673 with SMTP id\n\td2e1a72fcca58-7253005dd87mr12885131b3a.15.1732859618785; \n\tThu, 28 Nov 2024 21:53:38 -0800 (PST)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHan-Lin Chen <hanlinchen@chromium.org>, Xing Gu <xinggu@chromium.org>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 2/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc08a3 sensor properties", "Date": "Fri, 29 Nov 2024 05:52:19 +0000", "Message-ID": "<20241129055331.2490988-3-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.338.g60cca15819-goog", "In-Reply-To": "<20241129055331.2490988-1-chenghaoyang@chromium.org>", "References": "<20241129055331.2490988-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@google.com>\n\nProvide the GalaxyCore gc08a3 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Xing Gu <xinggu@chromium.org>\nSigned-off-by: Xing Gu <xinggu@chromium.org>\nCo-developed-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++\n 2 files changed, 26 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 9fb55bcfa..a76e5e754 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -532,6 +532,19 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n \n+class CameraSensorHelperGc08a3 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperGc08a3()\n+\t{\n+\t\t/* From datasheet: 64 at 10bits. */\n+\t\tblackLevel_ = 4096;\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 100, 0, 0, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 73c47b9a1..2b06c5a1a 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -119,6 +119,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t.hblankDelay = 2\n \t\t\t},\n \t\t} },\n+\t\t{ \"gc08a3\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "v6", "2/2" ] }