Patch Detail
Show a patch.
GET /api/patches/22075/?format=api
{ "id": 22075, "url": "https://patchwork.libcamera.org/api/patches/22075/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22075/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241125151430.2437285-9-stefan.klug@ideasonboard.com>", "date": "2024-11-25T15:14:17", "name": "[v2,8/8] pipeline: rkisp1: Add ScalerMaximumCrop property", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a1ea8f5c740e6e8d24c499ebbbada67bb554027", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22075/mbox/", "series": [ { "id": 4818, "url": "https://patchwork.libcamera.org/api/series/4818/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4818", "date": "2024-11-25T15:14:09", "name": "rkisp1: Fix aspect ratio and ScalerCrop", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4818/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22075/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22075/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BA47C32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Nov 2024 15:15:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFE206603D;\n\tMon, 25 Nov 2024 16:14:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 055056603C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 16:14:57 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4cf:a935:de6f:a329])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E5086B5;\n\tMon, 25 Nov 2024 16:14:35 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TG6yWZPC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732547675;\n\tbh=sn4sxcC4HIKI8WwHR5LtzEAMmK0tZ3z/Qjk+SuBsuzs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TG6yWZPCt4f/NiHwpRD37wKqDS074srRTc8tcpmOG7E8zOCNKl3orwA4iXkUrDQ98\n\tTApbdmxoHh31YPEsCmTAPdGtVOeneSM6wdyj85x0Z4oypkuG4w73V5bRN0xYUDeiOm\n\tPO+15ztoyPsagQXbD8VYf3lEkw6u5GbZMMtMqMB0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v2 8/8] pipeline: rkisp1: Add ScalerMaximumCrop property", "Date": "Mon, 25 Nov 2024 16:14:17 +0100", "Message-ID": "<20241125151430.2437285-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241125151430.2437285-1-stefan.klug@ideasonboard.com>", "References": "<20241125151430.2437285-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\nvalue. Add it to the rkisp1.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- Moved one hunk to the correct patch 6/7\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 0a044b08bc87..993515c258ef 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -24,6 +24,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/formats.h>\n #include <libcamera/framebuffer.h>\n+#include <libcamera/property_ids.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n #include <libcamera/transform.h>\n@@ -1247,6 +1248,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\t\t\t\t\t\t\t dewarperSensorCrop_);\n \n \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min, max, max);\n+\t\tdata->properties_.set(properties::ScalerCropMaximum, max);\n \t\tactiveCrop_ = max;\n \t}\n \n", "prefixes": [ "v2", "8/8" ] }