Patch Detail
Show a patch.
GET /api/patches/22055/?format=api
{ "id": 22055, "url": "https://patchwork.libcamera.org/api/patches/22055/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22055/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241121085800.3208123-3-chenghaoyang@chromium.org>", "date": "2024-11-21T08:57:17", "name": "[v5,2/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6e414db7371ce7cbf8f42e5493b439b6f864941a", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22055/mbox/", "series": [ { "id": 4812, "url": "https://patchwork.libcamera.org/api/series/4812/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4812", "date": "2024-11-21T08:57:16", "name": "[v5,1/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4812/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22055/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22055/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DA51C32FD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Nov 2024 08:58:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B927965FB8;\n\tThu, 21 Nov 2024 09:58:14 +0100 (CET)", "from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com\n\t[IPv6:2607:f8b0:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F017165FB0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Nov 2024 09:58:10 +0100 (CET)", "by mail-pl1-x62a.google.com with SMTP id\n\td9443c01a7336-21200c749bfso6098265ad.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Nov 2024 00:58:10 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-212882d1c66sm8734775ad.138.2024.11.21.00.58.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 21 Nov 2024 00:58:08 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DP+cIkkW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732179489; x=1732784289;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=tgGqSxJF2d05q7ZsAxT/8t/I0WJ1ujmJl/I2wnjjeuQ=;\n\tb=DP+cIkkW3QHPHuKVK1DphwuCCtEhRi1gOjNtD/0lwPx4fysNlqsEJZAllKR/diIuIV\n\tdjFYAqvkTLtSM+48R8eMXcIF74qIFiaKh73Xz0b1CXEXPyc8NGKTERU0eBpgCr3TWhUo\n\tgbIXTyHcxDuMGbxTlnLRzIWciat63di/DazvA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732179489; x=1732784289;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=tgGqSxJF2d05q7ZsAxT/8t/I0WJ1ujmJl/I2wnjjeuQ=;\n\tb=Q2kiHyQS6NptVj7Ipz3kr0898TlVHvJeMnmJFIWLadHcyAT1z4M+EgFky41T9DmJWr\n\tLg7D8bI4729r0/i2Y2gYVAc/mfBcGWXS79eF6IlhkthSy/a3DoIxcHhiCU+qEHDV9jBZ\n\tEsWdFwjocEzuNvAw6ghiR2Wg5uiSpnvooMIbgFeTq+gVTE1qvJLBIKg2roQ4Ib0x0b5u\n\tolUJyzhi7ETYHW1wcM0lMVY+yfCULPG7kZneblP3YhZsswI1zkdRkmd2dM918yVYkZYc\n\tFtTKvu4uCL51Ye0RHIXrhDI5C1WT11+SVxlsh70tCMiGaZADXGP7jYHZDJpUxncHr40R\n\t2w8Q==", "X-Gm-Message-State": "AOJu0YwumPDmeskeNkqKfhbg+QgumBNf0/zJaZU1YRAX2HFzJsWEuCxs\n\tFNySiJH50QsW4iYe0OsZoomurG5hy1tvcRAUIEjD9DP6eZSVRb6FD51QPho0Xcs+q98/igGrcs4\n\t=", "X-Google-Smtp-Source": "AGHT+IHiLnjEzBs3ZhvLTrJxEdhpaEyEEIdiE/DEUyxpGrYVRKGReouGEVa9Tg5Q20/O/BIVyJS4wA==", "X-Received": "by 2002:a17:903:22c8:b0:212:12a2:4011 with SMTP id\n\td9443c01a7336-2126c15b295mr65259035ad.27.1732179489081; \n\tThu, 21 Nov 2024 00:58:09 -0800 (PST)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHan-Lin Chen <hanlinchen@chromium.org>, Xing Gu <xinggu@chromium.org>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH v5 2/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc08a3 sensor properties", "Date": "Thu, 21 Nov 2024 08:57:17 +0000", "Message-ID": "<20241121085800.3208123-3-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.338.g60cca15819-goog", "In-Reply-To": "<20241121085800.3208123-1-chenghaoyang@chromium.org>", "References": "<20241121085800.3208123-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@google.com>\n\nProvide the GalaxyCore gc08a3 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Xing Gu <xinggu@chromium.org>\nCo-developed-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 7 +++++++\n 2 files changed, 20 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 3067d9bc1..e2da07723 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -532,6 +532,19 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n \n+class CameraSensorHelperGc08a3 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperGc08a3()\n+\t{\n+\t\t/* From datasheet: 64 at 10bits. */\n+\t\tblackLevel_ = 4096;\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 100, 0, 0, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 2f048d4a3..a15004341 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -77,6 +77,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"gc08a3\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "v5", "2/2" ] }