Patch Detail
Show a patch.
GET /api/patches/22027/?format=api
{ "id": 22027, "url": "https://patchwork.libcamera.org/api/patches/22027/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22027/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241120085753.1993436-6-stefan.klug@ideasonboard.com>", "date": "2024-11-20T08:57:44", "name": "[5/7] pipeline: rkisp1: Reorder sensorInfo collection code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b1ac0b287a777492b82f847431894fad16f170cc", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22027/mbox/", "series": [ { "id": 4807, "url": "https://patchwork.libcamera.org/api/series/4807/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4807", "date": "2024-11-20T08:57:39", "name": "rkisp1: Fix aspect ratio and ScalerCrop", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4807/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22027/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22027/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B520CC32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Nov 2024 08:58:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5316B65F40;\n\tWed, 20 Nov 2024 09:58:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A1FD65F4C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Nov 2024 09:58:12 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bbd:82cc:f3f3:e12e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5234C75A;\n\tWed, 20 Nov 2024 09:57:54 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RoI1R87W\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732093074;\n\tbh=YsRH3k0BMH2X0TuJFgfW6hsk+gw9uUhLBTj+/VBU7wA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RoI1R87WPgrPH6RzsspX47QsbRiJykemi860aX+XLBnxAGxUq2PWBe397axrKlUT9\n\tPyRZanhW2/ISRgZ97kEcMBCPOeKMU6UbRJcaMA7I+QvhT/GLXy+QYbwn3GeMMnl0RX\n\teElKkX9fDOrlZmwS8x41qblizt07dswn0vJXkPIo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 5/7] pipeline: rkisp1: Reorder sensorInfo collection code", "Date": "Wed, 20 Nov 2024 09:57:44 +0100", "Message-ID": "<20241120085753.1993436-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241120085753.1993436-1-stefan.klug@ideasonboard.com>", "References": "<20241120085753.1993436-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensorInfo (specifically the crop rectangle of the selected sensor\nmode) is collected to be passed to the IPA later. In an upcoming patch\nthat data will also be needed for correct ScalerCrop handling. Move the\ncollection of the sensorInfo before the dewarper configuration step and\nrefactor the code a bit.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 6491a48ee83c..4a226d9b809f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -844,6 +844,11 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t<< \"ISP output pad configured with \" << format\n \t\t<< \" crop \" << outputCrop;\n \n+\tIPACameraSensorInfo sensorInfo;\n+\tret = data->sensor_->sensorInfo(&sensorInfo);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tstd::map<unsigned int, IPAStream> streamConfig;\n \tstd::vector<std::reference_wrapper<StreamConfiguration>> outputCfgs;\n \n@@ -883,14 +888,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \n \t/* Inform IPA of stream configuration and sensor controls. */\n-\tipa::rkisp1::IPAConfigInfo ipaConfig{};\n-\n-\tret = data->sensor_->sensorInfo(&ipaConfig.sensorInfo);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tipaConfig.sensorControls = data->sensor_->controls();\n-\tipaConfig.paramFormat = paramFormat.fourcc;\n+\tipa::rkisp1::IPAConfigInfo ipaConfig{ sensorInfo,\n+\t\t\t\t\t data->sensor_->controls(),\n+\t\t\t\t\t paramFormat.fourcc };\n \n \tret = data->ipa_->configure(ipaConfig, streamConfig, &data->ipaControls_);\n \tif (ret) {\n", "prefixes": [ "5/7" ] }