Patch Detail
Show a patch.
GET /api/patches/22018/?format=api
{ "id": 22018, "url": "https://patchwork.libcamera.org/api/patches/22018/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22018/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241119130301.264972-2-dan.scally@ideasonboard.com>", "date": "2024-11-19T13:03:00", "name": "[v4,1/2] libcamera: camera_sensor_properties: Add sensor control delays", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b5d044e1b50e7b71f038286ea9d912a3d308387d", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22018/mbox/", "series": [ { "id": 4805, "url": "https://patchwork.libcamera.org/api/series/4805/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4805", "date": "2024-11-19T13:02:59", "name": "Add sensor control delays to CameraSensorProperties", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4805/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22018/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22018/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B319C32F3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Nov 2024 13:03:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6B9D65F26;\n\tTue, 19 Nov 2024 14:03:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 605DF65F1D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 14:03:13 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E8BD1211;\n\tTue, 19 Nov 2024 14:02:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hcl0tmB3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732021371;\n\tbh=fk9DGu/bMdFryHcHy+MznqipyfTTR5Gr+FdDg7ts3U4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hcl0tmB30eaAOXvWMuSEz6E4hjC32/nrzlqRonSuvOwgRd6/z7oPtSnmO4TLPxh5i\n\t/LrA4DrZ3ITnZbqoH+g8S93t02wMo8th818YlemfB8/CS9sJNMNRumGm/wRBJTS2jP\n\te+b1h721wo/wNqFTyKtSxTiBCsIkWY/4blldKhAw=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "mike.rudenko@gmail.com,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v4 1/2] libcamera: camera_sensor_properties: Add sensor\n\tcontrol delays", "Date": "Tue, 19 Nov 2024 13:03:00 +0000", "Message-Id": "<20241119130301.264972-2-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241119130301.264972-1-dan.scally@ideasonboard.com>", "References": "<20241119130301.264972-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add properties covering the sensor control application delays to both\nthe static CameraSensorProperties definitions. The values used are the\ndefaults that're in use across the library, with deviations from that\ntaken from Raspberry Pi's CamHelper class definitions.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges in v4:\n\n\t- getSensorDelays() renamed to sensorDelays()\n\t- sensorDelays() returns a reference to the SensorDelays struct rather\n\t than each of the values.\n\t- Reworded the comments to make the default values seem less acceptable\n\t- Added delay values for AR0144\n\nChanges in v3:\n\n\t- Rebased on top of the CameraSensorFactory introduction\n\t- Some rephrasing\n\t- Defined the sensorDelays member as empty where Raspberry Pi didn't\n\t have any specific values. Check for the empty struct in\n\t getSensorDelays() and return the defaults from there with a warning.\n\nChanges in v2:\n\n\t- Rather than adding the delays to the properties ControlList, added a\n\t new function in CameraSensor that allows PipelineHandlers to retreive\n\t the delay values.\n\n include/libcamera/internal/camera_sensor.h | 2 +\n .../internal/camera_sensor_properties.h | 10 ++\n src/libcamera/sensor/camera_sensor.cpp | 12 ++\n src/libcamera/sensor/camera_sensor_legacy.cpp | 18 +++\n .../sensor/camera_sensor_properties.cpp | 121 ++++++++++++++++++\n 5 files changed, 163 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 8aafd82e..bbdb83a1 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -20,6 +20,7 @@\n #include <libcamera/orientation.h>\n #include <libcamera/transform.h>\n \n+#include \"libcamera/internal/camera_sensor_properties.h\"\n #include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n \n@@ -73,6 +74,7 @@ public:\n \tvirtual const std::vector<controls::draft::TestPatternModeEnum> &\n \ttestPatternModes() const = 0;\n \tvirtual int setTestPatternMode(controls::draft::TestPatternModeEnum mode) = 0;\n+\tvirtual const CameraSensorProperties::SensorDelays &sensorDelays() = 0;\n };\n \n class CameraSensorFactoryBase\ndiff --git a/include/libcamera/internal/camera_sensor_properties.h b/include/libcamera/internal/camera_sensor_properties.h\nindex 480ac121..fe40bd7f 100644\n--- a/include/libcamera/internal/camera_sensor_properties.h\n+++ b/include/libcamera/internal/camera_sensor_properties.h\n@@ -8,6 +8,7 @@\n #pragma once\n \n #include <map>\n+#include <stdint.h>\n #include <string>\n \n #include <libcamera/control_ids.h>\n@@ -20,6 +21,15 @@ struct CameraSensorProperties {\n \n \tSize unitCellSize;\n \tstd::map<controls::draft::TestPatternModeEnum, int32_t> testPatternModes;\n+\n+\tstruct SensorDelays {\n+\t\tuint8_t exposureDelay;\n+\t\tuint8_t gainDelay;\n+\t\tuint8_t vblankDelay;\n+\t\tuint8_t hblankDelay;\n+\t} sensorDelays;\n };\n \n+extern const CameraSensorProperties::SensorDelays defaultSensorDelays;\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex 54cf98b2..e9ca291c 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -336,6 +336,18 @@ CameraSensor::~CameraSensor() = default;\n * pattern mode for every frame thus incurs no performance penalty.\n */\n \n+/**\n+ * \\fn CameraSensor::sensorDelays()\n+ * \\brief Fetch the sensor delay values\n+ *\n+ * This function fills in sensor control delays for pipeline handlers to use to\n+ * inform the DelayedControls. If no static properties are available it returns\n+ * a reference to the default sensor delays.\n+ *\n+ * \\return A reference to a struct CameraSensorProperties::SensorDelays holding\n+ * the delay values.\n+ */\n+\n /**\n * \\class CameraSensorFactoryBase\n * \\brief Base class for camera sensor factories\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex a9b15c03..f9202606 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -95,6 +95,7 @@ public:\n \tconst std::vector<controls::draft::TestPatternModeEnum> &\n \ttestPatternModes() const override { return testPatternModes_; }\n \tint setTestPatternMode(controls::draft::TestPatternModeEnum mode) override;\n+\tconst CameraSensorProperties::SensorDelays &sensorDelays() override;\n \n protected:\n \tstd::string logPrefix() const override;\n@@ -482,6 +483,23 @@ void CameraSensorLegacy::initStaticProperties()\n \tinitTestPatternModes();\n }\n \n+const CameraSensorProperties::SensorDelays &CameraSensorLegacy::sensorDelays()\n+{\n+\tif (!staticProps_ ||\n+\t (!staticProps_->sensorDelays.exposureDelay &&\n+\t !staticProps_->sensorDelays.gainDelay &&\n+\t !staticProps_->sensorDelays.vblankDelay &&\n+\t !staticProps_->sensorDelays.hblankDelay)) {\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"No sensor delays found in static properties. \"\n+\t\t\t \"Assuming unverified defaults.\";\n+\n+\t\treturn defaultSensorDelays;\n+\t}\n+\n+\treturn staticProps_->sensorDelays;\n+}\n+\n void CameraSensorLegacy::initTestPatternModes()\n {\n \tconst auto &v4l2TestPattern = controls().find(V4L2_CID_TEST_PATTERN);\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6d4136d0..97202bee 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -41,7 +41,51 @@ LOG_DEFINE_CATEGORY(CameraSensorProperties)\n * \\brief Map that associates the TestPattern control value with the indexes of\n * the corresponding sensor test pattern modes as returned by\n * V4L2_CID_TEST_PATTERN.\n+ *\n+ * \\var CameraSensorProperties::sensorDelays\n+ * \\brief Sensor control application delays.\n+ *\n+ * This struct may be defined as empty, in which case the CameraSensor\n+ * derivative should provide some appropriate default values.\n+ */\n+\n+/**\n+ * \\struct CameraSensorProperties::SensorDelays\n+ * \\brief Sensor control application delay values\n+ *\n+ * This struct holds delay values, expressed in number of frames, between the\n+ * time a control value is applied to the sensor and the time that value is\n+ * reflected in the output. For example \"2 frames delay\" means that parameters\n+ * set during frame N will take effect for frame N+2 (and by extension a delay\n+ * of 0 would mean the parameter is applied immediately to the current frame).\n+ *\n+ * \\var CameraSensorProperties::SensorDelays::exposureDelay\n+ * \\brief Number of frames between application of exposure control and effect\n+ *\n+ * \\var CameraSensorProperties::SensorDelays::gainDelay\n+ * \\brief Number of frames between application of analogue gain control and effect\n+ *\n+ * \\var CameraSensorProperties::SensorDelays::vblankDelay\n+ * \\brief Number of frames between application of vblank control and effect\n+ *\n+ * \\var CameraSensorProperties::SensorDelays::hblankDelay\n+ * \\brief Number of frames between application of hblank control and effect\n+ */\n+\n+/**\n+ * \\brief Default sensor control application delay values\n+ *\n+ * These sensor control delays are intended to be used where no specific values\n+ * are defined for a particular sensor in its CameraSensorProperties. These are\n+ * not verified for use with any particular sensor and so should be used with\n+ * caution.\n */\n+constexpr CameraSensorProperties::SensorDelays defaultSensorDelays = {\n+\t.exposureDelay = 2,\n+\t.gainDelay = 1,\n+\t.vblankDelay = 2,\n+\t.hblankDelay = 2,\n+};\n \n /**\n * \\brief Retrieve the properties associated with a sensor\n@@ -60,6 +104,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"ar0521\", {\n \t\t\t.unitCellSize = { 2200, 2200 },\n@@ -69,6 +119,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -87,6 +138,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * 9: \"Resolution Pattern\"\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"imx214\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -97,6 +149,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"imx219\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -107,6 +160,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 1,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"imx258\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -117,34 +176,62 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"imx283\", {\n \t\t\t.unitCellSize = { 2400, 2400 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"imx290\", {\n \t\t\t.unitCellSize = { 2900, 2900 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"imx296\", {\n \t\t\t.unitCellSize = { 3450, 3450 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"imx327\", {\n \t\t\t.unitCellSize = { 2900, 2900 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"imx335\", {\n \t\t\t.unitCellSize = { 2000, 2000 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"imx415\", {\n \t\t\t.unitCellSize = { 1450, 1450 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 3,\n+\t\t\t\t.hblankDelay = 3\n+\t\t\t},\n \t\t} },\n \t\t{ \"imx519\", {\n \t\t\t.unitCellSize = { 1220, 1220 },\n@@ -157,6 +244,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1).\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 3,\n+\t\t\t\t.hblankDelay = 3\n+\t\t\t},\n \t\t} },\n \t\t{ \"imx708\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n@@ -167,6 +260,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 3,\n+\t\t\t\t.hblankDelay = 3\n+\t\t\t},\n \t\t} },\n \t\t{ \"ov2685\", {\n \t\t\t.unitCellSize = { 1750, 1750 },\n@@ -181,6 +280,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * 5: \"Color Square\"\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov2740\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n@@ -188,6 +288,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov4689\", {\n \t\t\t.unitCellSize = { 2000, 2000 },\n@@ -201,6 +302,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * colorBarType2 and colorBarType3.\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov5640\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n@@ -208,10 +310,17 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov5647\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"ov5670\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -219,6 +328,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov5675\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -226,6 +336,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov5693\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n@@ -238,6 +349,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * Rolling Bar\".\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov64a40\", {\n \t\t\t.unitCellSize = { 1008, 1008 },\n@@ -251,6 +363,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n \t\t} },\n \t\t{ \"ov8858\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -264,6 +382,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov8865\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n@@ -278,6 +397,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t * 5: \"Color squares with rolling bar\"\n \t\t\t\t */\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t\t{ \"ov13858\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n@@ -285,6 +405,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n+\t\t\t.sensorDelays = { },\n \t\t} },\n \t};\n \n", "prefixes": [ "v4", "1/2" ] }