Patch Detail
Show a patch.
GET /api/patches/22007/?format=api
{ "id": 22007, "url": "https://patchwork.libcamera.org/api/patches/22007/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22007/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241119121928.30939-10-laurent.pinchart@ideasonboard.com>", "date": "2024-11-19T12:19:20", "name": "[v4,09/17] ipa: libipa: vector: Add element-wise min() and max() functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f4c543af6b773c1b96b9e09d6c71398753a32846", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22007/mbox/", "series": [ { "id": 4804, "url": "https://patchwork.libcamera.org/api/series/4804/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4804", "date": "2024-11-19T12:19:11", "name": "Improve linear algebra helpers in libipa", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4804/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22007/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22007/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BEC26C32F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Nov 2024 12:20:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5440765F28;\n\tTue, 19 Nov 2024 13:20:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D495865F28\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 13:20:06 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 327B91934\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 13:19:49 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uJLMT+H7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732018789;\n\tbh=4fzdi9q8tpbnT+vsDUJ0qe/mYweGuMe/LZdAmn2Fg2M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=uJLMT+H75A0Q3P3pX7QNsDvnIqDlEWXzASI5JRio3Y68roeG+wqBS9uZlFa9+NJhH\n\tTe+A8oW3RZvjXtJ3Vgqo9jhD00GjajS8Cl4anKuIGPnO02ND+JDg3i6Fps2ZMJQlMV\n\tbDVAKQ1DFyBytgWt6S7Eq2YYERB664eU2HdTJLgE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v4 09/17] ipa: libipa: vector: Add element-wise min() and\n\tmax() functions", "Date": "Tue, 19 Nov 2024 14:19:20 +0200", "Message-ID": "<20241119121928.30939-10-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>", "References": "<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add functions to calculate the element-wise minimum and maximum of two\nvectors or of a vector and a scalar. This will be used in algorithm\nimplementations.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/libipa/vector.cpp | 28 ++++++++++++++++++++++++++++\n src/ipa/libipa/vector.h | 20 ++++++++++++++++++++\n 2 files changed, 48 insertions(+)", "diff": "diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 3305dcb38e6b..a506487c7b43 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -189,6 +189,34 @@ namespace ipa {\n * \\return This vector\n */\n \n+/**\n+ * \\fn Vector::min(const Vector &other) const\n+ * \\brief Calculate the minimum of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise minimum of this vector and \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::min(T scalar) const\n+ * \\brief Calculate the minimum of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise minimum of this vector and \\a scalar\n+ */\n+\n+/**\n+ * \\fn Vector::max(const Vector &other) const\n+ * \\brief Calculate the maximum of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise maximum of this vector and \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::max(T scalar) const\n+ * \\brief Calculate the maximum of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise maximum of this vector and \\a scalar\n+ */\n+\n /**\n * \\fn Vector::dot(const Vector<T, Rows> &other) const\n * \\brief Compute the dot product\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 683bf9ee2564..85b7f6ee68a7 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -152,6 +152,26 @@ public:\n \t\treturn apply(scalar, [](T a, T b) { return a / b; });\n \t}\n \n+\tconstexpr Vector min(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, [](T a, T b) { return std::min(a, b); });\n+\t}\n+\n+\tconstexpr Vector min(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) { return std::min(a, b); });\n+\t}\n+\n+\tconstexpr Vector max(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, [](T a, T b) { return std::max(a, b); });\n+\t}\n+\n+\tconstexpr Vector max(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) -> T { return std::max(a, b); });\n+\t}\n+\n \tconstexpr T dot(const Vector<T, Rows> &other) const\n \t{\n \t\tT ret = 0;\n", "prefixes": [ "v4", "09/17" ] }