Patch Detail
Show a patch.
GET /api/patches/21992/?format=api
{ "id": 21992, "url": "https://patchwork.libcamera.org/api/patches/21992/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21992/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241119103740.1919807-5-stefan.klug@ideasonboard.com>", "date": "2024-11-19T10:37:31", "name": "[v2,4/9] libcamera: internal: matrix: Replace vector with array in constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b36414b9c3bac67eae1988b84abf347c139b6a44", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21992/mbox/", "series": [ { "id": 4803, "url": "https://patchwork.libcamera.org/api/series/4803/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4803", "date": "2024-11-19T10:37:27", "name": "ove Matrix class from libipa to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4803/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21992/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21992/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8431C326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Nov 2024 10:38:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 378CA65F02;\n\tTue, 19 Nov 2024 11:38:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0D7F65EFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 11:37:56 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bf40:cdab:103d:2270])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC329641;\n\tTue, 19 Nov 2024 11:37:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DMCcURZr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732012659;\n\tbh=Pxq+QbtgSim5UiVA3GTHPL6TLY8dvp3jcvBt7+Svdmw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DMCcURZrriMOADqoy9F+hhfV5RtrSM4tWDPTrj9rj+bAB0N17U+jdpqiLTc3ImuK3\n\t2l3hiX8uI+lIt1zJccZ8t0+LlfFYXLNj15siKUBoyBgprSzimq9UWFYbtXTzwxOpar\n\tVcFawyUuWCQjzTQC8lppBZZx9Ox+2435gfp2oibI=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 4/9] libcamera: internal: matrix: Replace vector with\n\tarray in constructor", "Date": "Tue, 19 Nov 2024 11:37:31 +0100", "Message-ID": "<20241119103740.1919807-5-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241119103740.1919807-1-stefan.klug@ideasonboard.com>", "References": "<20241119103740.1919807-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Having an array based constructor gives us initialization via\ninitializer lists.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n include/libcamera/internal/matrix.h | 2 +-\n src/libcamera/matrix.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\nindex 3701d0ee980b..7a71028c473a 100644\n--- a/include/libcamera/internal/matrix.h\n+++ b/include/libcamera/internal/matrix.h\n@@ -33,7 +33,7 @@ public:\n \t\tdata_.fill(static_cast<T>(0));\n \t}\n \n-\tMatrix(const std::vector<T> &data)\n+\tMatrix(const std::array<T, Rows * Cols> &data)\n \t{\n \t\tstd::copy(data.begin(), data.end(), data_.begin());\n \t}\ndiff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\nindex 55359aa206ee..4d95a19bfbb9 100644\n--- a/src/libcamera/matrix.cpp\n+++ b/src/libcamera/matrix.cpp\n@@ -32,7 +32,7 @@ LOG_DEFINE_CATEGORY(Matrix)\n */\n \n /**\n- * \\fn Matrix::Matrix(const std::vector<T> &data)\n+ * \\fn Matrix::Matrix(const std::array<T, Rows * Cols> &data)\n * \\brief Construct a matrix from supplied data\n * \\param[in] data Data from which to construct a matrix\n *\n", "prefixes": [ "v2", "4/9" ] }