Patch Detail
Show a patch.
GET /api/patches/21986/?format=api
{ "id": 21986, "url": "https://patchwork.libcamera.org/api/patches/21986/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21986/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241119084525.22589-1-naush@raspberrypi.com>", "date": "2024-11-19T08:45:25", "name": "ipa: rpi: awb: Disable CT search bias for Grey World AWB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ba5903a02bc54338d87b16a4473d8aa0f51172dc", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21986/mbox/", "series": [ { "id": 4801, "url": "https://patchwork.libcamera.org/api/series/4801/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4801", "date": "2024-11-19T08:45:25", "name": "ipa: rpi: awb: Disable CT search bias for Grey World AWB", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4801/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21986/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21986/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42833C32F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Nov 2024 08:55:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7021165EDE;\n\tTue, 19 Nov 2024 09:55:46 +0100 (CET)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A602565898\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 09:55:44 +0100 (CET)", "by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-382435f561cso246078f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2024 00:55:44 -0800 (PST)", "from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-382371a5646sm9917548f8f.0.2024.11.19.00.55.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 Nov 2024 00:55:43 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"L+gDRyYu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1732006544; x=1732611344;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=0bRztghqo3+Z/lsYSlInSpe1Xy1ewd07T4em2ITcA1s=;\n\tb=L+gDRyYum3b0ud49pOeUXTQDEvrXLXJmUUnevDXN/i8nB6uL6CiZZx9MPUeLrbodf8\n\tCYf+mx5gTpBOm2LN56bKmnZ/pACogdHb9+7gQZhI5XFTOS6UxYqRjdm3ZfwUa7GSD8Fi\n\tudWGwSnnuWflCJIO7TLFsDNbVocbKbfERuk3TdtaWyQF7cKoSHZy3YlSRzqj4aofINAA\n\tupCilahmLK+UFaIq1APGSdEY7kxVdkA3ilSr/wkSPaMhffxXi23+Jujx1yf3gLWC/YRE\n\ts1FG4utJ1E1DefWyritpV9zfrBPPlYNN6aIvqFJykbrLOS5ZxwhJfqTYk7eKfV6nUYTf\n\tGGuA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732006544; x=1732611344;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=0bRztghqo3+Z/lsYSlInSpe1Xy1ewd07T4em2ITcA1s=;\n\tb=u/UMIMbEjIJNM2IsTF7B+iokE5f5HuDSmqdarHQ114FImYCrYutqPL1qqPToYK6Wst\n\tQgm4QKUGMCukxLvP45Nvuy6F0zjxbJzd88ML8RING4D6c1lhz9ZtbJhKH9q8cchzlHxh\n\tImZWCrI12B2xgQgsI4wJqqqQLAmq7xQNMP+Sx/PuMtl4x26XYXDPJ+z/2YIAOK0hKXw6\n\twTTfRmlm9LoBPgjsDEWkym6LJ/Wz0ZIvngqkaYOD7NBTQXTPeUMhAGpbHoqG3Hx/eH9O\n\tV7ohSr+2LYARHZ2xnCjrrs+JNm4Tb4lbi7BZVVimD0jXXtzDlrBykV25qoZJOaG1FmU7\n\tXZBA==", "X-Gm-Message-State": "AOJu0YwGT+G6Lh3FaQycqn/NohbiOUxeqBtbOoNVluF3ToqgKIedcTRu\n\tomBJ8wJFZVbMCt6oGtkPSVQ/p88x/QW+SDy5vdy2gOXiRugeHky2LYmbJnYvsJkVWveo7plULc+\n\tF", "X-Google-Smtp-Source": "AGHT+IEnxRxCcn1MreTuqd6nHxYCdt6c+1nXblrPPgRmEEHqSOIax170WwrAlSJRU78J8s1OlEeH/A==", "X-Received": "by 2002:a05:6000:1886:b0:37e:d92e:818b with SMTP id\n\tffacd0b85a97d-38225a8da69mr5248518f8f.14.1732006543895; \n\tTue, 19 Nov 2024 00:55:43 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "david.plowman@raspberrypi.com,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH] ipa: rpi: awb: Disable CT search bias for Grey World AWB", "Date": "Tue, 19 Nov 2024 08:45:25 +0000", "Message-Id": "<20241119084525.22589-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If grey world AWB is setup in the tuning file, the CT curve will either\nbe missing or invalid. Disable biasing the statistics for the search in\nsuch cases.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/controller/rpi/awb.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\nindex 9d8e170d1bfe..87b1b077ffb8 100644\n--- a/src/ipa/rpi/controller/rpi/awb.cpp\n+++ b/src/ipa/rpi/controller/rpi/awb.cpp\n@@ -459,10 +459,13 @@ void Awb::prepareStats()\n \t * LSC has already been applied to the stats in this pipeline, so stop\n \t * any LSC compensation. We also ignore config_.fast in this version.\n \t */\n+\tconst double biasCtR = config_.bayes && config_.ctR.size() ?\n+\t\t\t config_.ctR.eval(config_.biasCT) : 0;\n+\tconst double biasCtB = config_.bayes && config_.ctB.size() ?\n+\t\t\t config_.ctB.eval(config_.biasCT) : 0;\n \tgenerateStats(zones_, statistics_, config_.minPixels,\n \t\t config_.minG, getGlobalMetadata(),\n-\t\t config_.biasProportion, config_.ctR.eval(config_.biasCT),\n-\t\t config_.ctB.eval(config_.biasCT));\n+\t\t config_.biasProportion, biasCtR, biasCtB);\n \t/*\n \t * apply sensitivities, so values appear to come from our \"canonical\"\n \t * sensor.\n", "prefixes": [] }