Patch Detail
Show a patch.
GET /api/patches/21979/?format=api
{ "id": 21979, "url": "https://patchwork.libcamera.org/api/patches/21979/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21979/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241118225310.446706-2-geoffrey.vl@gmail.com>", "date": "2024-11-18T22:53:07", "name": "[v2,1/4] libcamera: libipa: camera_sensor: Provide CameraSensorHelper and CameraSensorProperties for the Sony IMX462 image sensor.", "commit_ref": "8655ba6ffb5cc5d28d9d6cc293bf23812166a7ef", "pull_url": null, "state": "accepted", "archived": false, "hash": "86a3823c113c038bbb33d6d0764c8355f8b5637a", "submitter": { "id": 214, "url": "https://patchwork.libcamera.org/api/people/214/?format=api", "name": "Geoffrey Van Landeghem", "email": "geoffrey.vl@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21979/mbox/", "series": [ { "id": 4799, "url": "https://patchwork.libcamera.org/api/series/4799/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4799", "date": "2024-11-18T22:53:06", "name": "Add support for Sony IMX327 and IMX462 sensors", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4799/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21979/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21979/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B253C3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Nov 2024 22:53:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA54165904;\n\tMon, 18 Nov 2024 23:53:21 +0100 (CET)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF504658F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2024 23:53:16 +0100 (CET)", "by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-4315eac969aso27420125e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2024 14:53:16 -0800 (PST)", "from localhost.localdomain\n\t(ptr-gh3gmpb67n6nyq8fe1w.18120a2.ip6.access.telenet.be.\n\t[2a02:1812:2512:400:b7f4:fa69:c596:84e4])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-432dab807d4sm170221535e9.21.2024.11.18.14.53.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2024 14:53:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PWdrQ41O\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1731970396; x=1732575196;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=teXj3gc6g+HopFaIxFYUMApdjK8cAzC9KOk5oMwIDIE=;\n\tb=PWdrQ41O7OjggGVZ+R3n4R832icrf2OsARwOwJ68gozJnnF2QWYPfFoLbflVtc219r\n\txNidN1uZmZLAMLzsLSolqWyS8XmuY/8LQvnrFRQ+XCi9iMwh1RIrf2kfqu6IUy48yMef\n\t/DJTYwdFhCq+IBYYjFnJDJ8zUXOFOasT3KnakP0gHXNldcGsCEIG12atEW6cfdEgyJf8\n\t+Dvgd8qdrASZSK/vBRgHi8zr8pcjcsmg9mwzEbs69vNibAkuGW8nvb60nxkIEsqnVZvg\n\t+ggHdNZF8D4CN26UAZ9ruF3vEbzrrZgswpDh6sSVeg50tIgw3yEpFEdenSCHyZrrNtUv\n\tBq7A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731970396; x=1732575196;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=teXj3gc6g+HopFaIxFYUMApdjK8cAzC9KOk5oMwIDIE=;\n\tb=cJusmnGQcR+T0yNvgYeaAZautIUQmnuqHUztdXH18uolhR7RQ1EP01rYCyfsTnH6Fu\n\to9jXonx0qAwFjzxBkOW11YLe416O6niFGRzuWYYMd99iliHeJfWUYI6SLOb0ANkNuIoQ\n\tPPgknt93qMzm0f5rBigt4UPQFzAPS8DvXyUPy77UofsoHnvvNDfR8D56iKltYnq0kEme\n\t45n5jBww6eImvyOuRCOzTc1szLnNuaLsfRdEZ4yfqSQ/ZlkAQIu8J0wVIHMHyPAUL8sR\n\tnhapMlM875ItZ0DyfocczF8DpJcvUEn3bFy8T5/SdR9zdpfZh7yEb+U5ur7yHOsxGvSN\n\tl1Ww==", "X-Gm-Message-State": "AOJu0YxtzadN4nVm2qab1IjFh34C6qJnxE2cL65hr2r2A+Y3/awewmux\n\tHo09m3H1+68WTQfA/CtJISXojLqRXEG9hTwEhHdGyQn8vgoIUhHc6NiN0PVq", "X-Google-Smtp-Source": "AGHT+IECCgK3Ch9AEDpoHFL7V8LCgzP8/CipofU1ZZnX2lfo2zDEUkDo4CQcc2t5vAJ8hHgN2qhEiA==", "X-Received": "by 2002:a05:600c:242:b0:42c:b67b:816b with SMTP id\n\t5b1f17b1804b1-432f579dff8mr8540655e9.1.1731970396092; \n\tMon, 18 Nov 2024 14:53:16 -0800 (PST)", "From": "Geoffrey Van Landeghem <geoffrey.vl@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Geoffrey Van Landeghem <geoffrey.vl@gmail.com>", "Subject": "[PATCH v2 1/4] libcamera: libipa: camera_sensor: Provide\n\tCameraSensorHelper and CameraSensorProperties for the Sony IMX462\n\timage sensor.", "Date": "Mon, 18 Nov 2024 23:53:07 +0100", "Message-ID": "<20241118225310.446706-2-geoffrey.vl@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241118225310.446706-1-geoffrey.vl@gmail.com>", "References": "<20241118225310.446706-1-geoffrey.vl@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensor is largely compatible with the already supported Sony IMX290 so we can reuse the same helpers for the analogue gain conversion functions.\n\nSigned-off-by: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex c6169bdc..f870dc28 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -622,6 +622,11 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n \n+class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\nindex e57ab538..0cc24a6d 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n@@ -73,3 +73,4 @@ static CamHelper *create()\n }\n \n static RegisterCamHelper reg(\"imx290\", &create);\n+static RegisterCamHelper reg462(\"imx462\", &create);\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6d4136d0..e2305166 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 1450, 1450 },\n \t\t\t.testPatternModes = {},\n \t\t} },\n+\t\t{ \"imx462\", {\n+\t\t\t.unitCellSize = { 2900, 2900 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n", "prefixes": [ "v2", "1/4" ] }