Patch Detail
Show a patch.
GET /api/patches/2194/?format=api
{ "id": 2194, "url": "https://patchwork.libcamera.org/api/patches/2194/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2194/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191016232018.30239-1-laurent.pinchart@ideasonboard.com>", "date": "2019-10-16T23:20:18", "name": "[libcamera-devel] qcam: Support Qt versions earlier than 5.9", "commit_ref": "6b6c02e2236c22136c7b0d8d7141dd19dd0d6386", "pull_url": null, "state": "accepted", "archived": false, "hash": "cd8f497ef59446599010807c92ba6d3f0e5fe402", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2194/mbox/", "series": [ { "id": 536, "url": "https://patchwork.libcamera.org/api/series/536/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=536", "date": "2019-10-16T23:20:18", "name": "[libcamera-devel] qcam: Support Qt versions earlier than 5.9", "version": 1, "mbox": "https://patchwork.libcamera.org/series/536/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2194/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2194/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC39060E1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Oct 2019 01:20:26 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E9AB4FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Oct 2019 01:20:26 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1571268026;\n\tbh=VSJzZoJ3R2k6i70hVWHgBS6MqUdBVcv43lxqvc/4ZGE=;\n\th=From:To:Subject:Date:From;\n\tb=q+NITF60WXrMK96ltAIaAt2+HFwhFgMhJrKi94dItmcBNua1p+H/TuM7/daZ6GXHq\n\tdg5WtQ5hsRva1oTqgOxLvxHN1m059tI5yVnjQqGWfzUyrVbbPZ7g884cwRmT2wP5R9\n\tdUQbEcUfXjsOTMJdsPXoAx9QWgZozqr4+Q513zMg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 17 Oct 2019 02:20:18 +0300", "Message-Id": "<20191016232018.30239-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] qcam: Support Qt versions earlier than 5.9", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 16 Oct 2019 23:20:27 -0000" }, "content": "The QtEventDispatcher timers implementation depends on Qt 5.9 or newer\ndue to the use of QObject::startTimer(std::chrono::milliseconds).\nSupport earlier Qt versions by using the QObject::startTimer(int)\nversion instead.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/qt_event_dispatcher.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/qt_event_dispatcher.cpp b/src/qcam/qt_event_dispatcher.cpp\nindex 9e989bef7d53..2780c9123ac3 100644\n--- a/src/qcam/qt_event_dispatcher.cpp\n+++ b/src/qcam/qt_event_dispatcher.cpp\n@@ -117,7 +117,7 @@ void QtEventDispatcher::registerTimer(Timer *timer)\n \tstd::chrono::steady_clock::duration duration = timer->deadline() - now;\n \tstd::chrono::milliseconds msec =\n \t\tstd::chrono::duration_cast<std::chrono::milliseconds>(duration);\n-\tint timerId = startTimer(msec);\n+\tint timerId = startTimer(msec.count());\n \ttimers_[timerId] = timer;\n \ttimerIds_[timer] = timerId;\n }\n", "prefixes": [ "libcamera-devel" ] }