Patch Detail
Show a patch.
GET /api/patches/21904/?format=api
{ "id": 21904, "url": "https://patchwork.libcamera.org/api/patches/21904/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21904/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241115101334.453104-2-dan.scally@ideasonboard.com>", "date": "2024-11-15T10:13:21", "name": "[v6,01/14] libcamera: mali-c55: Limit max size to sensor resolution", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0d1de27224076e1ea206f122fdcbb4eb8341642b", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21904/mbox/", "series": [ { "id": 4793, "url": "https://patchwork.libcamera.org/api/series/4793/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4793", "date": "2024-11-15T10:13:20", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4793/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21904/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21904/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A356C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Nov 2024 10:13:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E6A565877;\n\tFri, 15 Nov 2024 11:13:52 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24CF365860\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Nov 2024 11:13:48 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E52CE0D;\n\tFri, 15 Nov 2024 11:13:33 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VlsvYGck\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731665613;\n\tbh=cinsoAfR3z1VnpqG5w1re9WpRuIu3VLCiSwau/9of+g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VlsvYGckIpJbLzdfSesW96L1NLUFhTY5zhyPygh8jFsYXVgqkoVsrEI9UFtl7/Xnq\n\t1sfUUKGCY2tbcA9pFgqEQjymFXkT1399sZGRMqt/kfZjz5sg7XTI+g4oVBmH9M3L3n\n\tHVXaHBMKyAPXD8lxpBzpRjrBWWH7x2x4CeRbCvRM=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Anthony.McGivern@arm.com, Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 01/14] libcamera: mali-c55: Limit max size to sensor\n\tresolution", "Date": "Fri, 15 Nov 2024 10:13:21 +0000", "Message-Id": "<20241115101334.453104-2-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241115101334.453104-1-dan.scally@ideasonboard.com>", "References": "<20241115101334.453104-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThe Mali C55 ISP cannot upscale. The maximum allowed output size\nis the sensor's resolution.\n\nFor RAW streams this is already handled in adjustRawSizes(), while\nfor processed streams the maximum allowed resolution was wrongly\nset to the ISP maximum output size (8192x8192).\n\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges in v6:\n\n\t- None\n\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex e40025b4..662b34ef 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -341,7 +341,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\trawConfig = &config;\n \t}\n \n-\tSize maxSize = kMaliC55MaxSize;\n+\t/*\n+\t * The C55 can not upscale. Limit the configuration to the ISP\n+\t * capabilities and the sensor resolution.\n+\t */\n+\tSize maxSize = kMaliC55MaxSize.boundedTo(data_->resolution());\n \tif (rawConfig) {\n \t\t/*\n \t\t * \\todo Take into account the Bayer components ordering once\n", "prefixes": [ "v6", "01/14" ] }