Patch Detail
Show a patch.
GET /api/patches/21892/?format=api
{ "id": 21892, "url": "https://patchwork.libcamera.org/api/patches/21892/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21892/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241113223556.413637-2-geoffrey.vl@gmail.com>", "date": "2024-11-13T22:35:54", "name": "[1/4] libcamera: libipa: camera_sensor: Add Sony IMX462 sensor properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "86a3823c113c038bbb33d6d0764c8355f8b5637a", "submitter": { "id": 214, "url": "https://patchwork.libcamera.org/api/people/214/?format=api", "name": "Geoffrey Van Landeghem", "email": "geoffrey.vl@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21892/mbox/", "series": [ { "id": 4791, "url": "https://patchwork.libcamera.org/api/series/4791/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4791", "date": "2024-11-13T22:35:54", "name": "[1/4] libcamera: libipa: camera_sensor: Add Sony IMX462 sensor properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4791/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21892/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21892/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68EE6C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 Nov 2024 22:44:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 819A56582B;\n\tWed, 13 Nov 2024 23:44:28 +0100 (CET)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B05E0657CF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Nov 2024 23:36:39 +0100 (CET)", "by mail-wr1-x431.google.com with SMTP id\n\tffacd0b85a97d-37d5aedd177so6419f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Nov 2024 14:36:39 -0800 (PST)", "from localhost.localdomain\n\t(ptr-gh3gmpabk3m2xfsbzez.18120a2.ip6.access.telenet.be.\n\t[2a02:1812:2512:400:7ff6:bc6d:a745:500b])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-381eda04b52sm19268695f8f.101.2024.11.13.14.36.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2024 14:36:38 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jT24gwpU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1731537399; x=1732142199;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Tlr1dXLdnam0CPN4niYvxQcdsM7HjCpJo8kuQcSScms=;\n\tb=jT24gwpUHG/74itdTSaxaDuIu5ls4bM1PHkPmqT0JuISMgSOc+jwattbqVaTbDdpb8\n\t0CcSKeMYO3e+ogVDq6WZdP/5NVKF9/Igk3Ez9ShqIanZ4p4dvJ13Kq7BtH5xAnZyaF8d\n\tINWGCum51AzGPT4wHInseNLwoSD5PuLKmiCTpclRytghMNNTc5OYfiPBftGGQZp1WmQU\n\tN4dnf/ZOHGMviw2i4F3Q825pLbbMo48kuhMl4XnpFwTFMKzJ+sWCa3Fa8zX/WbZLaKgq\n\tsn9w6CxaZAQx5h2Gs19TTaS3qmMddrI9u6W2InvOBfx7UC5eTd7ofQb2+LKI2L0xgkKQ\n\tss5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731537399; x=1732142199;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Tlr1dXLdnam0CPN4niYvxQcdsM7HjCpJo8kuQcSScms=;\n\tb=i5SJU/+8OR87SPtsKAN56BhJ6yEaYW94Rq34uXAacbg1RHp/cumRpYU63xQ4spHYOG\n\td2ud52IM15XuTyi5BH9VGSQJRCaY4PQuCeTAmgU3O5C8gZufLC49xNOY5ngrgEotmagV\n\tJDSjIygQmXGvfxAKxX0B/YHFSMm+mdHMwyqi2BBIrjcMVFpH47X/NFJl822ln3sq55Vp\n\tkbxx5qSwb2DiidQTbW2gCaFn4Y7UtjcPPZ2CsuGVMZErJfgVxpW6vOAxZFOo9YG5D3wL\n\trtzVhLXqd1poYeqsIbVGD998KX6X/+A9z4yQMKo5pCuDeQ98ULDHc953PzAcyy3B1W3o\n\tWmvQ==", "X-Gm-Message-State": "AOJu0YzmjpEk7IQmypc5gTGMLrAOMdCUrsuOG+wD1bB1cRCKxqVJkqpF\n\tw8Eeqwn5MH++uLmjt8/NUNLw9aQahUBSKdlJyl2dfXnlpNTjeheVQNtHew==", "X-Google-Smtp-Source": "AGHT+IFXVRZHZNmuMrPp+dwnw8uyJH3fMDm+dT7CQ1dM8ou5SGF/CeUeGcuwumTcnKBt7hb1iPnstQ==", "X-Received": "by 2002:a05:6000:1845:b0:37c:d4ba:1127 with SMTP id\n\tffacd0b85a97d-3820df6117emr4398071f8f.16.1731537398839; \n\tWed, 13 Nov 2024 14:36:38 -0800 (PST)", "From": "Geoffrey Van Landeghem <geoffrey.vl@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Geoffrey Van Landeghem <geoffrey.vl@gmail.com>", "Subject": "[PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462 sensor\n\tproperties", "Date": "Wed, 13 Nov 2024 23:35:54 +0100", "Message-ID": "<20241113223556.413637-2-geoffrey.vl@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 13 Nov 2024 23:44:26 +0100", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\nThis patch-set comes as part of an ongoing effort to support Sony IMX327 and IMX462 sensors better in the linux kernel.\nFor the kernel following changes are proposed:\nhttps://github.com/raspberrypi/linux/pull/5859\n\nAfter those changes have been applied, the 2 Starvis sensors will no longer be identied by libcamera as a IMX290 and therefore require this patch-set to work correctly. \n\nSigned-off-by: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex c6169bdc..f870dc28 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -622,6 +622,11 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n \n+class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\nindex e57ab538..0cc24a6d 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n@@ -73,3 +73,4 @@ static CamHelper *create()\n }\n \n static RegisterCamHelper reg(\"imx290\", &create);\n+static RegisterCamHelper reg462(\"imx462\", &create);\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6d4136d0..e2305166 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 1450, 1450 },\n \t\t\t.testPatternModes = {},\n \t\t} },\n+\t\t{ \"imx462\", {\n+\t\t\t.unitCellSize = { 2900, 2900 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n", "prefixes": [ "1/4" ] }