Patch Detail
Show a patch.
GET /api/patches/21838/?format=api
{ "id": 21838, "url": "https://patchwork.libcamera.org/api/patches/21838/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21838/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241107105846.52287-6-dan.scally@ideasonboard.com>", "date": "2024-11-07T10:58:38", "name": "[v5,05/13] libcamera: mali-c55: Remove MaliC55CameraData::mbusCodes()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b278d899c81f640da96623f3c7b95e073feb470d", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21838/mbox/", "series": [ { "id": 4776, "url": "https://patchwork.libcamera.org/api/series/4776/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4776", "date": "2024-11-07T10:58:33", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4776/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21838/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21838/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3C4BC324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Nov 2024 10:59:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3125465481;\n\tThu, 7 Nov 2024 11:59:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B4256546F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Nov 2024 11:58:55 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9217CBDB;\n\tThu, 7 Nov 2024 11:58:46 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nv0k89xI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977126;\n\tbh=xpRucEToqc68lR5BVm1Jls8ePX0OSJoB8zcQwPaYUWA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nv0k89xI85ONW05O+VEbtz4dqUnuImZ74n1dC2Y3QYP3Vv2QH9EnAipyRAnr/LD/1\n\tsi4YFRhw0SnYooR5TA6v8NQYROeoC99zO2fPbzFTVbHIXr+BgqBnQF0SmIIuIdXa7l\n\t1U+2oFSYe2GRbk5pJTXJui26jX3QkahKgseaHam8=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v5 05/13] libcamera: mali-c55: Remove\n\tMaliC55CameraData::mbusCodes()", "Date": "Thu, 7 Nov 2024 10:58:38 +0000", "Message-Id": "<20241107105846.52287-6-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20241107105846.52287-1-dan.scally@ideasonboard.com>", "References": "<20241107105846.52287-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The MaliC55CameraData::mbusCodes() function is unused. Remove it.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 12e32f23..877a156c 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -95,7 +95,6 @@ public:\n \tint init();\n \n \t/* Deflect these functionalities to either TPG or CameraSensor. */\n-\tconst std::vector<unsigned int> mbusCodes() const;\n \tconst std::vector<Size> sizes(unsigned int mbusCode) const;\n \tconst Size resolution() const;\n \n@@ -178,14 +177,6 @@ void MaliC55CameraData::initTPGData()\n \ttpgResolution_ = tpgSizes_.back();\n }\n \n-const std::vector<unsigned int> MaliC55CameraData::mbusCodes() const\n-{\n-\tif (sensor_)\n-\t\treturn sensor_->mbusCodes();\n-\n-\treturn tpgCodes_;\n-}\n-\n const std::vector<Size> MaliC55CameraData::sizes(unsigned int mbusCode) const\n {\n \tif (sensor_)\n", "prefixes": [ "v5", "05/13" ] }