Patch Detail
Show a patch.
GET /api/patches/21797/?format=api
{ "id": 21797, "url": "https://patchwork.libcamera.org/api/patches/21797/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21797/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241101172220.5765-1-umang.jain@ideasonboard.com>", "date": "2024-11-01T17:22:20", "name": "gstreamer: Merge initControls_ with request controls", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "47d719a882d86992783af97aff1d3e501edfa556", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21797/mbox/", "series": [ { "id": 4763, "url": "https://patchwork.libcamera.org/api/series/4763/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4763", "date": "2024-11-01T17:22:20", "name": "gstreamer: Merge initControls_ with request controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4763/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21797/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21797/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D1A4BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Nov 2024 17:22:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 685B6653A8;\n\tFri, 1 Nov 2024 18:22:32 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5B6C65398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Nov 2024 18:22:30 +0100 (CET)", "from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DA7C3A2;\n\tFri, 1 Nov 2024 18:22:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"du29JW5D\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730481745;\n\tbh=tbbWfP3Ddl+EBk5eO5o4KmfYfx7C2ikakJMftygIYRM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=du29JW5D8msx/yqRzQb2P9bHGvACBUXL3RbFF0h6VAIOJNEsEbQI73fD6rInLVF8t\n\thWud7Zp3KJYUGEgVN5St/UlezANr8fZgrJbEmzHyuZaS5TdCT6NSKgflqeHXNtOjq+\n\teOZuEprE0AB4MMQkxaJwO+8xw7HXfksqiBARDpu8=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH] gstreamer: Merge initControls_ with request controls", "Date": "Fri, 1 Nov 2024 22:52:20 +0530", "Message-ID": "<20241101172220.5765-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It turns out there a few pipeline-handler/IPA that do not honor\nthe controls passed during start() phase. For instance, he gstreamer\nlibcamerasrc element, passes the target framerate during start() to\nlibcamera. As rkisp1 pipeline-handler/IPA doesn't do anything with\ncontrols passed during start(), the target fps is unable to take\neffect on rkisp1 platform.\n\nHence, merge the initControls_ with request controls with\nControlList::MergePolicy::KeepExisting. This way, the controls passed\nby libcamerasrc during start(), can atleast get honoured on the\nplatform through requests' control.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 912a8d55..0d615f4a 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -208,6 +208,7 @@ int GstLibcameraSrcState::queueRequest()\n \t}\n \n \tGST_TRACE_OBJECT(src_, \"Requesting buffers\");\n+\twrap->request_.get()->controls().merge(initControls_, ControlList::MergePolicy::KeepExisting);\n \tcam_->queueRequest(wrap->request_.get());\n \n \t{\n", "prefixes": [] }