Patch Detail
Show a patch.
GET /api/patches/21761/?format=api
{ "id": 21761, "url": "https://patchwork.libcamera.org/api/patches/21761/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21761/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241028101525.21369-1-jacopo.mondi@ideasonboard.com>", "date": "2024-10-28T10:15:23", "name": "libcamera: rkisp1: Create main buffer pool out of if(!isRaw)", "commit_ref": "e1d45a17f76d5d125d44409b259114b087a4bfe3", "pull_url": null, "state": "accepted", "archived": false, "hash": "20d76cadabe79250e9f3a3c759a2051abe6275d6", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21761/mbox/", "series": [ { "id": 4749, "url": "https://patchwork.libcamera.org/api/series/4749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4749", "date": "2024-10-28T10:15:23", "name": "libcamera: rkisp1: Create main buffer pool out of if(!isRaw)", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21761/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21761/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66B45BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Oct 2024 10:15:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E01E56539F;\n\tMon, 28 Oct 2024 11:15:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3294B60360\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2024 11:15:38 +0100 (CET)", "from ideasonboard.com (mob-5-90-59-111.net.vodafone.it\n\t[5.90.59.111])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 527B4346;\n\tMon, 28 Oct 2024 11:15:34 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sVZbV/U4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730110536;\n\tbh=YG0OkSf2AsCZqPIB5h06FRTgt6xsXCqdpkwLfDcEWQs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=sVZbV/U4eUKUQrpnTDv68rcaqXc5UokhRKB7f6kfNg+EC52POUM1hHPlX8o2/2g6f\n\truvO1d8wb8RwgN2T+CVy3bxWIVhvXQM8VB5wbVdfXNUIBmFRnSjYb8fkUINsRIGcN6\n\tOHWBPBp6l2/2JqaGIoTcSeDBBUr6y7AMa9Q6q+eg=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH] libcamera: rkisp1: Create main buffer pool out of if(!isRaw)", "Date": "Mon, 28 Oct 2024 11:15:23 +0100", "Message-ID": "<20241028101525.21369-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The \"useDewarper_\" class variable is set to true during configure\nonly if the configuration is !isRaw.\n\nThe main path buffer pool creation can thus be moved out of the\nif (!isRaw) block at allocateBuffers() time.\n\nCosmetic change that will make it easier to create a buffer pool\nfor the main and self paths unconditionally in future.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 83b74b27652f..20fb9765727f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -927,16 +927,16 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n \t\tret = stat_->allocateBuffers(maxCount, &statBuffers_);\n \t\tif (ret < 0)\n \t\t\tgoto error;\n+\t}\n \n-\t\t/* If the dewarper is being used, allocate internal buffers for ISP. */\n-\t\tif (useDewarper_) {\n-\t\t\tret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);\n-\t\t\tif (ret < 0)\n-\t\t\t\tgoto error;\n+\t/* If the dewarper is being used, allocate internal buffers for ISP. */\n+\tif (useDewarper_) {\n+\t\tret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);\n+\t\tif (ret < 0)\n+\t\t\tgoto error;\n \n-\t\t\tfor (std::unique_ptr<FrameBuffer> &buffer : mainPathBuffers_)\n-\t\t\t\tavailableMainPathBuffers_.push(buffer.get());\n-\t\t}\n+\t\tfor (std::unique_ptr<FrameBuffer> &buffer : mainPathBuffers_)\n+\t\t\tavailableMainPathBuffers_.push(buffer.get());\n \t}\n \n \tfor (std::unique_ptr<FrameBuffer> &buffer : paramBuffers_) {\n", "prefixes": [] }