Patch Detail
Show a patch.
GET /api/patches/21757/?format=api
{ "id": 21757, "url": "https://patchwork.libcamera.org/api/patches/21757/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21757/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241028011459.696-1-laurent.pinchart@ideasonboard.com>", "date": "2024-10-28T01:14:59", "name": "ipa: libipa: Fix ExposureModeHelper function name in documentation", "commit_ref": "19617424dbc1ccd03abec6609c52fdba629494de", "pull_url": null, "state": "accepted", "archived": false, "hash": "27126ff0a86305df3303577ea8dccf094bb84f88", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21757/mbox/", "series": [ { "id": 4745, "url": "https://patchwork.libcamera.org/api/series/4745/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4745", "date": "2024-10-28T01:14:59", "name": "ipa: libipa: Fix ExposureModeHelper function name in documentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4745/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21757/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21757/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 219F9BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Oct 2024 01:15:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CF416539E;\n\tMon, 28 Oct 2024 02:15:07 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2860865392\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2024 02:15:05 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71A16641\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2024 02:15:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D0bl8oe5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730078103;\n\tbh=UXvs3+nJs/K0ZWC0wC5J+4azzrwqx+rAPWzoDxxpnxE=;\n\th=From:To:Subject:Date:From;\n\tb=D0bl8oe5LLKpBRqoPfUuFVmtoHU0EXfmSbM2N9IeoaRiCPmomsHHZwv1VwWLNeRGW\n\tQ72DVJets2ADNKVoCEqxe3wUg3iXmpwkh/9/lDGXCd37IH/FvHMYGvDd3I6chsh7fy\n\txfBGIa1jA3ulu/Xk34p2qhDReu4hh6UUlrXuOg04=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] ipa: libipa: Fix ExposureModeHelper function name in\n\tdocumentation", "Date": "Mon, 28 Oct 2024 03:14:59 +0200", "Message-ID": "<20241028011459.696-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Previous iterations of the ExposureModeHelper class had a\nsetShutterGainLimits() function, which got renamed to setLimits(). The\ndocumentation still uses the old name. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/exposure_mode_helper.cpp | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)\n\n\nbase-commit: 80a7ccd3add45eb56fda6f1fb445017ac01fea7a", "diff": "diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\nindex 7703becc4766..30da0c894044 100644\n--- a/src/ipa/libipa/exposure_mode_helper.cpp\n+++ b/src/ipa/libipa/exposure_mode_helper.cpp\n@@ -67,7 +67,7 @@ namespace ipa {\n * encompasses both analogue and digital gain.\n *\n * The vector of stages may be empty. In that case, the helper will simply use\n- * the runtime limits set through setShutterGainLimits() instead.\n+ * the runtime limits set through setLimits() instead.\n */\n ExposureModeHelper::ExposureModeHelper(const Span<std::pair<utils::Duration, double>> stages)\n {\n@@ -213,28 +213,25 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n /**\n * \\fn ExposureModeHelper::minShutter()\n * \\brief Retrieve the configured minimum shutter time limit set through\n- * setShutterGainLimits()\n+ * setLimits()\n * \\return The minShutter_ value\n */\n \n /**\n * \\fn ExposureModeHelper::maxShutter()\n- * \\brief Retrieve the configured maximum shutter time set through\n- * setShutterGainLimits()\n+ * \\brief Retrieve the configured maximum shutter time set through setLimits()\n * \\return The maxShutter_ value\n */\n \n /**\n * \\fn ExposureModeHelper::minGain()\n- * \\brief Retrieve the configured minimum gain set through\n- * setShutterGainLimits()\n+ * \\brief Retrieve the configured minimum gain set through setLimits()\n * \\return The minGain_ value\n */\n \n /**\n * \\fn ExposureModeHelper::maxGain()\n- * \\brief Retrieve the configured maximum gain set through\n- * setShutterGainLimits()\n+ * \\brief Retrieve the configured maximum gain set through setLimits()\n * \\return The maxGain_ value\n */\n \n", "prefixes": [] }