Patch Detail
Show a patch.
GET /api/patches/21746/?format=api
{ "id": 21746, "url": "https://patchwork.libcamera.org/api/patches/21746/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21746/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241023165812.868221-1-chenghaoyang@chromium.org>", "date": "2024-10-23T16:58:04", "name": "libcamera: Add static Object::Deleter function", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4957ade38cb5111eb925b1b0d502217ff76a53a2", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21746/mbox/", "series": [ { "id": 4739, "url": "https://patchwork.libcamera.org/api/series/4739/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4739", "date": "2024-10-23T16:58:04", "name": "libcamera: Add static Object::Deleter function", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4739/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21746/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21746/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BBF2C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Oct 2024 16:58:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22EA26538A;\n\tWed, 23 Oct 2024 18:58:21 +0200 (CEST)", "from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com\n\t[IPv6:2607:f8b0:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52C736537E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Oct 2024 18:58:19 +0200 (CEST)", "by mail-pg1-x52a.google.com with SMTP id\n\t41be03b00d2f7-7ea0ff74b15so4634925a12.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Oct 2024 09:58:19 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(199.211.81.34.bc.googleusercontent.com. [34.81.211.199])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7eaeab1e31esm7054958a12.26.2024.10.23.09.58.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 23 Oct 2024 09:58:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"j7WpBKO5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729702697; x=1730307497;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=cXQ/zFdKudlz8s25Cl5h6yz4gizr21nKE3SmdZrDzr4=;\n\tb=j7WpBKO5Xhmfc0MFCZLWE1IIkyLGJlzTkzRyT8Td6HUtT2bUVrGyfukIiWpiMcPhQA\n\tBe0rW8ATc+mXR8CvH+ZGPuCjkk3IcKdZAAahyE0+SocxbDMTKL+H1ZOOvouYPo4I5D0F\n\tzr7JnD/H8r9rgKEg/3A9lGzGvFWm4HlR+ad44=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729702697; x=1730307497;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=cXQ/zFdKudlz8s25Cl5h6yz4gizr21nKE3SmdZrDzr4=;\n\tb=MbEW28bskf0YL/e5rdlP3ta1yROHaZIIkeK0hlIk0/bRAoOWs1cdKlA/k6Z50F88eS\n\tMlK4L9WlKCAR3MKrsOedFBn3swi3VYCtflgg/H+8mQjSUeu6qNaDNJ++sERh+SMmaQ7J\n\tg9I9hyPmFgZ3Bb+CBzN92v+Sggx8/4bU7X0KuY7rxj3x5rOkAdEQmKc1F95dCgnPIhP6\n\tnMKAV0E5Il4fPLbGrmNC93JChFxsM/0JaFEGu7B5S6uwzTEA+S77mDRwZxZpQyB6YsEB\n\tRpWpINs/RJHyKxJUJ0r2D1/xfB7IKIenmst75tU5kaL/wgY0lUM25kLa8fchPuvAZv/w\n\toG8A==", "X-Gm-Message-State": "AOJu0Ywj1ZLmLlk0nyPvNW34lbUOW1vDmpNO55PG69/81RGTRLCZie0G\n\tREnXyYI89s/qVTzjf6DaZiqWBb7Aa3EAW+LSrqH9zA0H4J6+xcKzA8EJ5btHAjnya/Unw713wuk\n\t=", "X-Google-Smtp-Source": "AGHT+IH8vLxydn3zFaBIssb2jkWdEnK+CzFTghayk8RJGZJwRtchFI1dF8WgU3dG6zlDOGXQ+UCVQQ==", "X-Received": "by 2002:a05:6a20:c797:b0:1d9:4837:ada1 with SMTP id\n\tadf61e73a8af0-1d978b9906dmr4217176637.35.1729702697353; \n\tWed, 23 Oct 2024 09:58:17 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH] libcamera: Add static Object::Deleter function", "Date": "Wed, 23 Oct 2024 16:58:04 +0000", "Message-ID": "<20241023165812.868221-1-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.105.g07ac214952-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch allows a smart pointer of Object to be destructed in other\nthreads.\n\nThere will be multiple usages of smart pointers of Object. This patch\nadds the deleter function to avoid duplicated code.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/base/object.h | 2 ++\n src/libcamera/base/object.cpp | 11 +++++++++++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/include/libcamera/base/object.h b/include/libcamera/base/object.h\nindex 508773cd0..c4522d480 100644\n--- a/include/libcamera/base/object.h\n+++ b/include/libcamera/base/object.h\n@@ -24,6 +24,8 @@ class Thread;\n class Object\n {\n public:\n+\tstatic void Deleter(Object *obj);\n+\n \tObject(Object *parent = nullptr);\n \tvirtual ~Object();\n \ndiff --git a/src/libcamera/base/object.cpp b/src/libcamera/base/object.cpp\nindex 745d2565a..2c04b99a5 100644\n--- a/src/libcamera/base/object.cpp\n+++ b/src/libcamera/base/object.cpp\n@@ -59,6 +59,17 @@ LOG_DEFINE_CATEGORY(Object)\n * \\sa Message, Signal, Thread\n */\n \n+/**\n+ * \\brief A deleter function that calls Object::deleteLater\n+ * \\param[in] obj The object itself\n+ *\n+ * The static deleter function that's used in smart pointers.\n+ */\n+void Object::Deleter(Object *obj)\n+{\n+\tobj->deleteLater();\n+}\n+\n /**\n * \\brief Construct an Object instance\n * \\param[in] parent The object parent\n", "prefixes": [] }