Patch Detail
Show a patch.
GET /api/patches/21703/?format=api
{ "id": 21703, "url": "https://patchwork.libcamera.org/api/patches/21703/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21703/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241019184340.111785-1-robert.mader@collabora.com>", "date": "2024-10-19T18:43:39", "name": "[1/2] libcamera: software_isp: Stop clearing context config and state again", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fcaf4e2ebc7f0cd40a0c143d1a37d3a6dc473e54", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21703/mbox/", "series": [ { "id": 4726, "url": "https://patchwork.libcamera.org/api/series/4726/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4726", "date": "2024-10-19T18:43:39", "name": "[1/2] libcamera: software_isp: Stop clearing context config and state again", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4726/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21703/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21703/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12474C3302\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 19 Oct 2024 18:44:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAB9B6538D;\n\tSat, 19 Oct 2024 20:44:16 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1B7065380\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 19 Oct 2024 20:44:13 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1729363448036674.2882559438096;\n\tSat, 19 Oct 2024 11:44:08 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"jBCl06NM\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1729363450; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=XOE6xB1veE6snB4Ygth6aajWBibWVQZ/TzQSDPC983NfzmwI/VSvRlbHL/o8WsKo1Ia0zl16aIdjcxqetW9JUfaEA0iO3dch8WFrytEFukHFabWngWrBNhjhFhncaY73w/ufp8QSSYU6bO7hERjJdDnc7Y6wFA/3tgG5ejhBjRw=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1729363450;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=knZ82CySN+eCHh67b8pL3OWDNyMRSzBhtlrAv/RofvM=; \n\tb=FCMdeMekxa+XBcO28M7voitVVkokkthbzJTNUbL3y/VN1tda85ECIh97bbSnLoKTQpEcpltg1tDKz+HqOkx+oRkRW7AOr2mb8iwVUsTd7DnN0vINbZSWNkBkDyYXK3xIvZWThY9ySLoLWTQOd2of5Cg0h+NqpcspiQeQA6jIiiw=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1729363450;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=knZ82CySN+eCHh67b8pL3OWDNyMRSzBhtlrAv/RofvM=;\n\tb=jBCl06NMbl6TyDhjUb4Oguc1Zq92woELdbQDE0ZHMtxbYB5riGwWUYn/47Ow9U2O\n\taDIHcLjJN+wLRHhQo1ESc94rRlPbOxzG/lGHh4aOjjvQYs1Jjr8VhOddHVNCQUUfveh\n\tyVZR1oaugbkcHfMisTH19Db04ZgwAuwE+WHsSC94=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH 1/2] libcamera: software_isp: Stop clearing context config\n\tand state again", "Date": "Sat, 19 Oct 2024 20:43:39 +0200", "Message-ID": "<20241019184340.111785-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.47.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This partly reverts commit 41e3d61c, removing parts that had unintended\nside effects as the intention for the commit was purely to fix crashes.\n\nClearing the configuration turned out to be problematic as some values such\nas configuration.black.level only get on initialization and thus were never\nused.\n\nClearing the activeState resulted in additional, arguably undesired churn,\nvery noticable when switching back and forth between cameras. Whether this\nis desirable is AFAIK a matter of taste/policy and shouldn't have been done\nas part of a crash fix.\n\nFixes: 41e3d61c (\"libcamera: software_isp: Clear IPA context on configure and stop\")\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n src/ipa/simple/soft_simple.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex c8ad55a2..065673dc 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -185,8 +185,6 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n \tconst ControlInfo &gainInfo = sensorInfoMap_.find(V4L2_CID_ANALOGUE_GAIN)->second;\n \n \t/* Clear the IPA context before the streaming session. */\n-\tcontext_.configuration = {};\n-\tcontext_.activeState = {};\n \tcontext_.frameContexts.clear();\n \n \tcontext_.configuration.agc.exposureMin = exposureInfo.min().get<int32_t>();\n", "prefixes": [ "1/2" ] }