Patch Detail
Show a patch.
GET /api/patches/21664/?format=api
{ "id": 21664, "url": "https://patchwork.libcamera.org/api/patches/21664/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21664/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241018075242.1143876-1-chenghaoyang@chromium.org>", "date": "2024-10-18T07:52:37", "name": "libcamera: mtkisp7: Change ipa_control_value_entry.count to 32 bits", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5399c5659dab3743ddb77a5707f7c8aa6ab9230c", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21664/mbox/", "series": [ { "id": 4714, "url": "https://patchwork.libcamera.org/api/series/4714/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4714", "date": "2024-10-18T07:52:37", "name": "libcamera: mtkisp7: Change ipa_control_value_entry.count to 32 bits", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4714/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21664/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21664/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE1B8C32FE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Oct 2024 07:52:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD2996538B;\n\tFri, 18 Oct 2024 09:52:51 +0200 (CEST)", "from mail-pl1-x632.google.com (mail-pl1-x632.google.com\n\t[IPv6:2607:f8b0:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C67A65379\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Oct 2024 09:52:50 +0200 (CEST)", "by mail-pl1-x632.google.com with SMTP id\n\td9443c01a7336-20cdb889222so19004105ad.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Oct 2024 00:52:50 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(199.211.81.34.bc.googleusercontent.com. [34.81.211.199])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-20e5a71eab2sm7453635ad.40.2024.10.18.00.52.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Oct 2024 00:52:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"b57/bcxY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729237968; x=1729842768;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ZwebKJfAGBPJhOfJWOtRSD7ZIUDGMzFxv9NXGtefBUM=;\n\tb=b57/bcxYemfVb7FihuWqZeWvrprSG332YxQvuVxCIhZqXAyzEIXu34mD7gzlJVJGAr\n\trw19gpSl6jd21o/Fxe8d8rkq5p/9lv6rrAnmasHPAxa1AEXowLbomShQBdMbke35r/fk\n\tyzYOZJxtXo1Ixat2pkzGB5U52amt6BrQdijrQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729237968; x=1729842768;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ZwebKJfAGBPJhOfJWOtRSD7ZIUDGMzFxv9NXGtefBUM=;\n\tb=p70G3bSUsF3UptPJOJ7uCDVWJwzUUhUprub5ju2jNODfIrvIhBCPpYZo1Ai8YzpP3Y\n\tppBEzMzZoE0JDJeYLRkMHOGKrlB8jF2MIuZB+qEiQIHoYC+6Ps6dhaafH5r9rMQPU6vv\n\tWhe9wEph5cjN0Aas/n3ZHLi5kG3c2oQa2FbK/HUZlEEhlM1EFOcxrGQiohhqTNoih2Sf\n\twnBnsQm6TN2XekCyCy17UREPZtvkOCncSeKhGhxjC3BH9YhPQ3DQg7lBccxM2vdIGU7u\n\tFEkSA/epmKjMsuQqhQNWF++44X4mw2mLbQKHwlJO/V5C8uJxtySSbXa2nU2nJl5SpSVJ\n\tFJwQ==", "X-Gm-Message-State": "AOJu0YydV6ylWOetxNC9luIWyjpgIgatkjoFi8zeyKLx88HVMXnjGFv0\n\tlKgKaqNE43WaFO2v7Gd5OG4mfsfMD+0AiXQRoCgH1WU2vexu/zhpn4+BQyhPNW9s6V8G2p5RyL8\n\t=", "X-Google-Smtp-Source": "AGHT+IG+KQMhmtW1qqnshCSHfYOUYKWhKLT9CCXYfhZm6gsC8H6bXkd5iAE3R9Val7kGRjOT6HgjKA==", "X-Received": "by 2002:a17:903:41cd:b0:20c:675d:923d with SMTP id\n\td9443c01a7336-20e5a8f23cfmr19354705ad.39.1729237967971; \n\tFri, 18 Oct 2024 00:52:47 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Xing-Gu Chen <xinggu@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count to\n\t32 bits", "Date": "Fri, 18 Oct 2024 07:52:37 +0000", "Message-ID": "<20241018075242.1143876-1-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.rc1.288.g06298d1525-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Xing-Gu Chen <xinggu@chromium.org>\n\nChange ipa_control_value_entry.count to uint32_t because the\nelement count of JpegApplicationSegmentContent is bigger than\n65536.\n\nSigned-off-by: Xing-Gu Chen <xinggu@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/ipa/ipa_controls.h | 2 +-\n src/libcamera/ipa_controls.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\nindex 5fd13394f..7a8051695 100644\n--- a/include/libcamera/ipa/ipa_controls.h\n+++ b/include/libcamera/ipa/ipa_controls.h\n@@ -37,7 +37,7 @@ struct ipa_control_value_entry {\n \tuint32_t id;\n \tuint8_t type;\n \tuint8_t is_array;\n-\tuint16_t count;\n+\tuint32_t count;\n \tuint32_t offset;\n \tuint32_t padding[1];\n };\ndiff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\nindex 9420c889f..a1ccc7d61 100644\n--- a/src/libcamera/ipa_controls.cpp\n+++ b/src/libcamera/ipa_controls.cpp\n@@ -207,7 +207,7 @@ static_assert(sizeof(ipa_controls_header) == 32,\n * Padding bytes (shall be set to 0)\n */\n \n-static_assert(sizeof(ipa_control_value_entry) == 16,\n+static_assert(sizeof(ipa_control_value_entry) == 20,\n \t \"Invalid ABI size change for struct ipa_control_value_entry\");\n \n /**\n", "prefixes": [] }