Patch Detail
Show a patch.
GET /api/patches/2162/?format=api
{ "id": 2162, "url": "https://patchwork.libcamera.org/api/patches/2162/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2162/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191012184407.31684-2-laurent.pinchart@ideasonboard.com>", "date": "2019-10-12T18:43:54", "name": "[libcamera-devel,v2,01/14] libcamera: pipeline: rkisp1: Avoid copy assignment of V4L2 control map", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "50aa2f0a23de1fb8ab75362737bc80bceb6f7478", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2162/mbox/", "series": [ { "id": 531, "url": "https://patchwork.libcamera.org/api/series/531/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=531", "date": "2019-10-12T18:43:53", "name": "Use ControlList for both libcamera and V4L2 controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/531/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2162/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2162/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AE9061563\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 12 Oct 2019 20:44:15 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84F0D54C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 12 Oct 2019 20:44:14 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570905854;\n\tbh=rUJFRV8cl37hkAEqYF6hFVVdtfsUwULZC17nOZieKxQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Hb8yOGkRrwmsXAgxX1JixPwGVK6PFiyiG+hOVEvA4GlsPD6Ivm40FwX9owJZNgJpv\n\t5KezhTjavyAJHSb7IP5KQngy/jDj+Sj4OuchYn0f2n9dgOZvzvAgykmeCpadI2CVPU\n\t3A3+MOulwXM98WR4pdmb1zB4+O3jg1yVE77mWpyM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 12 Oct 2019 21:43:54 +0300", "Message-Id": "<20191012184407.31684-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>", "References": "<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 01/14] libcamera: pipeline: rkisp1:\n\tAvoid copy assignment of V4L2 control map", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 12 Oct 2019 18:44:15 -0000" }, "content": "Use the std::map::emplace() method to avoid unnecessary creation of an\nempty V4L2ControlInfoMap folled by a copy assignment.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 029d5868d11f..32b023730009 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -777,7 +777,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \t};\n \n \tstd::map<unsigned int, V4L2ControlInfoMap> entityControls;\n-\tentityControls[0] = data->sensor_->controls();\n+\tentityControls.emplace(0, data->sensor_->controls());\n \n \tdata->ipa_->configure(streamConfig, entityControls);\n \n", "prefixes": [ "libcamera-devel", "v2", "01/14" ] }