Patch Detail
Show a patch.
GET /api/patches/21587/?format=api
{ "id": 21587, "url": "https://patchwork.libcamera.org/api/patches/21587/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21587/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241011092222.537322-2-umang.jain@ideasonboard.com>", "date": "2024-10-11T09:22:20", "name": "[1/3] libcamera: rkisp1: Use const reference for sensor configuration", "commit_ref": "326e0aa834487dd50610c0ff0423acc48d7b2298", "pull_url": null, "state": "accepted", "archived": false, "hash": "4907cbd61851a0cb8998b4e84af8573a3aab0be4", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21587/mbox/", "series": [ { "id": 4684, "url": "https://patchwork.libcamera.org/api/series/4684/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4684", "date": "2024-10-11T09:22:19", "name": "libcamera: rkisp1: sensorConfig assorted fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4684/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21587/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21587/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A827CC3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 11 Oct 2024 09:22:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF69C65375;\n\tFri, 11 Oct 2024 11:22:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 157366536C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Oct 2024 11:22:37 +0200 (CEST)", "from umang.jain (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C6CDCDB;\n\tFri, 11 Oct 2024 11:20:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y/+N9dfZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728638458;\n\tbh=xW2uqmk5kvlornICxBmL4hpFoKO9QCloAsflcEgzTVA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Y/+N9dfZ6fDpMdtpNoGzvnr1d7cNuKoe6XrM8twaV1IL12Yd8EhQfE14m3T7bh0b0\n\tD95hgPTYSgpKsZpDnFI2q+Jhd1HZzG9wpndTaJHUtHlIk3Mfbj42a1r1JJLeokffQw\n\tae8oHz44ViN0ri1c7UU3KRmpMKQezUH3n8NXdiaY=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 1/3] libcamera: rkisp1: Use const reference for sensor\n\tconfiguration", "Date": "Fri, 11 Oct 2024 14:52:20 +0530", "Message-ID": "<20241011092222.537322-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241011092222.537322-1-umang.jain@ideasonboard.com>", "References": "<20241011092222.537322-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "User-provided sensor configuration is never meant to be altered,\nhence pass SensorConfiguration by `const` reference in\nRkISP1Path::validate().\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 1999094e..4a3b779c 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -253,7 +253,7 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor, const Size &size,\n \n CameraConfiguration::Status\n RkISP1Path::validate(const CameraSensor *sensor,\n-\t\t std::optional<SensorConfiguration> &sensorConfig,\n+\t\t const std::optional<SensorConfiguration> &sensorConfig,\n \t\t StreamConfiguration *cfg)\n {\n \tconst std::vector<unsigned int> &mbusCodes = sensor->mbusCodes();\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\nindex ce9a5666..8461071f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n@@ -45,7 +45,7 @@ public:\n \t\t\t\t\t\t const Size &resolution,\n \t\t\t\t\t\t StreamRole role);\n \tCameraConfiguration::Status validate(const CameraSensor *sensor,\n-\t\t\t\t\t std::optional<SensorConfiguration> &sensorConfig,\n+\t\t\t\t\t const std::optional<SensorConfiguration> &sensorConfig,\n \t\t\t\t\t StreamConfiguration *cfg);\n \n \tint configure(const StreamConfiguration &config,\n", "prefixes": [ "1/3" ] }