Patch Detail
Show a patch.
GET /api/patches/21582/?format=api
{ "id": 21582, "url": "https://patchwork.libcamera.org/api/patches/21582/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21582/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241010084719.712485-3-paul.elder@ideasonboard.com>", "date": "2024-10-10T08:47:18", "name": "[2/3] apps: cam: Print control vendor information when listing controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c485d457cb8277d02036eb13864f381a168810d9", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21582/mbox/", "series": [ { "id": 4681, "url": "https://patchwork.libcamera.org/api/series/4681/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4681", "date": "2024-10-10T08:47:16", "name": "libcamera: controls: Add namespace to ControlId", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4681/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21582/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21582/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F434C32E0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Oct 2024 08:47:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D52756536B;\n\tThu, 10 Oct 2024 10:47:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5346663538\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Oct 2024 10:47:37 +0200 (CEST)", "from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:c738:203:8807:bdb1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 778874D4;\n\tThu, 10 Oct 2024 10:45:58 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WUnF+S8v\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728549959;\n\tbh=IzpRygg62rxhojM9zT+WiAbirjGJn0T4ncQKQgsRjio=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WUnF+S8vUGbS8zuy5YufLZ9stN4kHIyJerGUjaUqU3BDWn5Y5CutT9BtdywmF5Dsv\n\t4NWftvzztcU6al6Oq83rgkmKHBCYBVIocWQDK3j5KCxfCWvyYnAyLTDcqtDiH6WEea\n\tAVEZQcxeudgwoXpMblGJ4rtMUS1akQGtLMY+Hvto=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH 2/3] apps: cam: Print control vendor information when listing\n\tcontrols", "Date": "Thu, 10 Oct 2024 17:47:18 +0900", "Message-Id": "<20241010084719.712485-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20241010084719.712485-1-paul.elder@ideasonboard.com>", "References": "<20241010084719.712485-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the vendor of the control can be queried, print it in\n--list-controls.\n\nExample output:\n$ cam -c 1 --list-controls\nUsing camera platform/vimc.0 Sensor B as cam0\nControl: libcamera::Brightness: [-1.000000..1.000000]\nControl: libcamera::Contrast: [0.000000..2.000000]\nControl: libcamera::Saturation: [0.000000..2.000000]\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex edc49b875450..6e9890ccfda1 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -160,10 +160,13 @@ void CameraSession::listControls() const\n {\n \tfor (const auto &[id, info] : camera_->controls()) {\n \t\tif (info.values().empty()) {\n-\t\t\tstd::cout << \"Control: \" << id->name() << \": \"\n+\t\t\tstd::cout << \"Control: \"\n+\t\t\t\t << id->vendor() << \"::\" << id->name() << \": \"\n \t\t\t\t << info.toString() << std::endl;\n \t\t} else {\n-\t\t\tstd::cout << \"Control: \" << id->name() << \":\" << std::endl;\n+\t\t\tstd::cout << \"Control: \"\n+\t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n+\t\t\t\t << std::endl;\n \t\t\tfor (const auto &value : info.values()) {\n \t\t\t\tint32_t val = value.get<int32_t>();\n \t\t\t\tconst auto &it = id->enumerators().find(val);\n", "prefixes": [ "2/3" ] }