Patch Detail
Show a patch.
GET /api/patches/21544/?format=api
{ "id": 21544, "url": "https://patchwork.libcamera.org/api/patches/21544/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21544/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241008153031.429906-7-stefan.klug@ideasonboard.com>", "date": "2024-10-08T15:29:44", "name": "[v3,6/7] ipa: libipa: Add data accessor to Histogram", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8a3d938ac00119ed1a54dd3c5794ebb17b47bf32", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21544/mbox/", "series": [ { "id": 4667, "url": "https://patchwork.libcamera.org/api/series/4667/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4667", "date": "2024-10-08T15:29:38", "name": "Add support for IPA debugging metadata", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4667/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21544/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21544/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6954BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 8 Oct 2024 15:30:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B8C665374;\n\tTue, 8 Oct 2024 17:30:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E37EA65372\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Oct 2024 17:30:52 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d:f30b:aa60:fabf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3812FDB2;\n\tTue, 8 Oct 2024 17:29:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VOfrcBgD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728401356;\n\tbh=LWH0Fjvo2R3wNXd0L9iqL8mPrb5JPIZ/8rxsFKxYbeA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VOfrcBgD7U6rAOIVtLjcvTJ9QDZRduh/Dnuv9N2CeKYJ3qNjOXyebUTqnE67xQEmW\n\tozkuU6X2xm55TNfn8sfgM4/j7CYEVTS2zRuF/j038dPgNBOclfAheHKpdWcxjDcQsP\n\t27lMHBtoOuRcE2KCZ+Xn0H1/UrSKzO9b5wU/hXLA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 6/7] ipa: libipa: Add data accessor to Histogram", "Date": "Tue, 8 Oct 2024 17:29:44 +0200", "Message-ID": "<20241008153031.429906-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241008153031.429906-1-stefan.klug@ideasonboard.com>", "References": "<20241008153031.429906-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For debugging purposes it is helpful to access the internal data of the\nhistogram. Add an accessor for that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v2:\n- return Span instead of reference to std::vector\n---\n src/ipa/libipa/histogram.cpp | 6 ++++++\n src/ipa/libipa/histogram.h | 1 +\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\nindex 5fbfadf5e4e1..10e44b54a0cf 100644\n--- a/src/ipa/libipa/histogram.cpp\n+++ b/src/ipa/libipa/histogram.cpp\n@@ -62,6 +62,12 @@ Histogram::Histogram(Span<const uint32_t> data)\n * \\return Number of bins\n */\n \n+/**\n+ * \\fn Histogram::data()\n+ * \\brief Retrieve the internal data\n+ * \\return The data\n+ */\n+\n /**\n * \\fn Histogram::total()\n * \\brief Retrieve the total number of values in the data set\ndiff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\nindex 6fd641683694..a926002c8cf0 100644\n--- a/src/ipa/libipa/histogram.h\n+++ b/src/ipa/libipa/histogram.h\n@@ -36,6 +36,7 @@ public:\n \t}\n \n \tsize_t bins() const { return cumulative_.size() - 1; }\n+\tconst Span<const uint64_t> data() const { return cumulative_; }\n \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n \tuint64_t cumulativeFrequency(double bin) const;\n \tdouble quantile(double q, uint32_t first = 0, uint32_t last = UINT_MAX) const;\n", "prefixes": [ "v3", "6/7" ] }