Patch Detail
Show a patch.
GET /api/patches/21524/?format=api
{ "id": 21524, "url": "https://patchwork.libcamera.org/api/patches/21524/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21524/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241007095425.211158-2-stefan.klug@ideasonboard.com>", "date": "2024-10-07T09:54:05", "name": "[v2,1/7] libcamera: Add debug control space", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b8b809645e13629f516811b8b5a90fd988f49696", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21524/mbox/", "series": [ { "id": 4661, "url": "https://patchwork.libcamera.org/api/series/4661/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4661", "date": "2024-10-07T09:54:04", "name": "Add support for IPA debugging metadata", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4661/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21524/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21524/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97507C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Oct 2024 09:54:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6700063536;\n\tMon, 7 Oct 2024 11:54:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64B736352D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Oct 2024 11:54:33 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ba12:1296:516b:1122])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 859AE55;\n\tMon, 7 Oct 2024 11:52:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ksQtZfvu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728294777;\n\tbh=mwTbDvgj9NfE8vYX85KBZNJCWGr2we9pfCBV7XsWqCs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ksQtZfvu1LUeR918Gu81QJNux6JntuOV+AleXAQ1F9hOL7tXLCxDwzIdGoW4DNCSO\n\tb5ixyReBAnPqY8ImduSJorlWTTiUwJNxqlO3KUVc+EzMdAfLjWImxNz2OU9pHbC85Z\n\t7Ng4P0otn/GCpjep1dvvJNxGGLumkd7amdhY7+mA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 1/7] libcamera: Add debug control space", "Date": "Mon, 7 Oct 2024 11:54:05 +0200", "Message-ID": "<20241007095425.211158-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241007095425.211158-1-stefan.klug@ideasonboard.com>", "References": "<20241007095425.211158-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a new 'debug' controls namespace for the upcoming implementation of\ndebug metadata. While at it, sort the entries alphabetically.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v2:\n- Order lists in meson file alphabetically\n- Fix wording in control-ranges\n---\n include/libcamera/meson.build | 5 +++--\n src/libcamera/control_ids_debug.yaml | 7 +++++++\n src/libcamera/control_ranges.yaml | 4 +++-\n 3 files changed, 13 insertions(+), 3 deletions(-)\n create mode 100644 src/libcamera/control_ids_debug.yaml", "diff": "diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex a969a95dbf7a..fd69a5172b6a 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -34,8 +34,9 @@ libcamera_headers_install_dir = get_option('includedir') / libcamera_include_dir\n \n controls_map = {\n 'controls': {\n- 'draft': 'control_ids_draft.yaml',\n 'core': 'control_ids_core.yaml',\n+ 'debug': 'control_ids_debug.yaml',\n+ 'draft': 'control_ids_draft.yaml',\n 'rpi/vc4': 'control_ids_rpi.yaml',\n },\n \n@@ -55,7 +56,7 @@ foreach mode, entry : controls_map\n files_list = []\n input_files = []\n foreach vendor, header : entry\n- if vendor != 'core' and vendor != 'draft'\n+ if vendor not in ['core', 'debug', 'draft']\n if vendor not in pipelines\n continue\n endif\ndiff --git a/src/libcamera/control_ids_debug.yaml b/src/libcamera/control_ids_debug.yaml\nnew file mode 100644\nindex 000000000000..62f742c58129\n--- /dev/null\n+++ b/src/libcamera/control_ids_debug.yaml\n@@ -0,0 +1,7 @@\n+# SPDX-License-Identifier: LGPL-2.1-or-later\n+#\n+%YAML 1.1\n+---\n+vendor: debug\n+controls:\n+\ndiff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\nindex d42447d04647..6752eb986ac6 100644\n--- a/src/libcamera/control_ranges.yaml\n+++ b/src/libcamera/control_ranges.yaml\n@@ -13,6 +13,8 @@ ranges:\n draft: 10000\n # Raspberry Pi vendor controls\n rpi: 20000\n- # Next range starts at 30000\n+ # Controls for debug metadata\n+ debug: 30000\n+ # Next range starts at 40000\n \n ...\n", "prefixes": [ "v2", "1/7" ] }