Patch Detail
Show a patch.
GET /api/patches/21480/?format=api
{ "id": 21480, "url": "https://patchwork.libcamera.org/api/patches/21480/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21480/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241002164801.1556328-1-mzamazal@redhat.com>", "date": "2024-10-02T16:48:01", "name": "libcamera: software_isp: Improve wording in a comment", "commit_ref": "a7d573df53ff2fe2edaaf4c11a269f12b1a9e305", "pull_url": null, "state": "accepted", "archived": false, "hash": "88eb5206d69d6587797d65b465dde3ad291c62d7", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21480/mbox/", "series": [ { "id": 4649, "url": "https://patchwork.libcamera.org/api/series/4649/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4649", "date": "2024-10-02T16:48:01", "name": "libcamera: software_isp: Improve wording in a comment", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4649/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21480/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21480/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 222F0BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Oct 2024 16:48:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0E706351F;\n\tWed, 2 Oct 2024 18:48:15 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39D9C63510\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Oct 2024 18:48:14 +0200 (CEST)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-70-1cBfK1kKNlWTNeHNbxoZwA-1;\n\tWed, 02 Oct 2024 12:48:12 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 1265E19560BE; Wed, 2 Oct 2024 16:48:11 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.90])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 436E83000197; Wed, 2 Oct 2024 16:48:08 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"If2byJwe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727887693;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=xGHGMBJ7bxzs0TcGF42eGMZrFsY7QVXiZsFK1cg7QoY=;\n\tb=If2byJweQual+RG4mIwZwKFt79uQRm0R35zF0yGQRjXovu61K1OZk1OFfOczsTDGNho55G\n\tO5+OlU+cLB2H7su0y/JYMfHt5UO5acKeTssSqv0At0Jri6qH+Y2shq5abXVoxJ2JKAPVEw\n\taY6k6Y6/eysQjMNeeYCU1IjZmz2xamw=", "X-MC-Unique": "1cBfK1kKNlWTNeHNbxoZwA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH] libcamera: software_isp: Improve wording in a comment", "Date": "Wed, 2 Oct 2024 18:48:01 +0200", "Message-ID": "<20241002164801.1556328-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A minor wording improvement suggested on refactoring review.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex 783dfb8bc..df92edd7e 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -29,7 +29,7 @@ static constexpr unsigned int kExposureBinsCount = 5;\n static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n \n /*\n- * The below value implements the hysteresis for the exposure adjustment.\n+ * This implements the hysteresis for the exposure adjustment.\n * It is small enough to have the exposure close to the optimal, and is big\n * enough to prevent the exposure from wobbling around the optimal value.\n */\n", "prefixes": [] }