Patch Detail
Show a patch.
GET /api/patches/21468/?format=api
{ "id": 21468, "url": "https://patchwork.libcamera.org/api/patches/21468/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21468/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241002055002.6271-3-jacopo.mondi@ideasonboard.com>", "date": "2024-10-02T05:50:00", "name": "[v10,3/5] libcamera: controls: Add ControlTypePoint", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "61bb00deb8fd4505bf4e2eae7354ef2727268fae", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21468/mbox/", "series": [ { "id": 4647, "url": "https://patchwork.libcamera.org/api/series/4647/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4647", "date": "2024-10-01T19:13:44", "name": "Add Face Detection Controls", "version": 10, "mbox": "https://patchwork.libcamera.org/series/4647/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21468/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21468/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7EDBBD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Oct 2024 05:50:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 192EB63512;\n\tWed, 2 Oct 2024 07:50:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 752DE63512\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Oct 2024 07:50:16 +0200 (CEST)", "from ideasonboard.com (unknown [5.77.88.238])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78AC9A1A;\n\tWed, 2 Oct 2024 07:48:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AqyNzjoQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727848124;\n\tbh=cGo0UfLYVNri6IQT1UX1pG+d9scY8pRhOjGqSSN8CfM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AqyNzjoQnGJofWzPxdaaQORIf//w6SnLQncT3DAnvoCXA7vCPzSI0MWmzy48dq3WS\n\tjOgaoWKGDHRPd6q3MzKJd667foxaSopEQnS3R3OJixgVOlHBWs8c4nqt7vloEGMH0t\n\tgsci1NkQ1mvl5YSPM05k62IAjaMGiDW2sFn3nHhE=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tBecker Hsieh <beckerh@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v10 3/5] libcamera: controls: Add ControlTypePoint", "Date": "Wed, 2 Oct 2024 07:50:00 +0200", "Message-ID": "<20241002055002.6271-3-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.46.1", "In-Reply-To": "<20241002055002.6271-1-jacopo.mondi@ideasonboard.com>", "References": "<20241001191354.55056-1-jacopo.mondi@ideasonboard.com>\n\t<20241002055002.6271-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Yudhistira Erlandinata <yerlandinata@chromium.org>\n\nAdd a control_type<> specialization for libcamera::Point to allow\nstoring data of that type in a ControlValue instance.\n\nThe new control type will be used by controls introduced in the\nnext patches.\n\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Becker Hsieh <beckerh@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/controls.h | 6 ++++++\n src/libcamera/controls.cpp | 6 ++++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex c5131870d402..ca60bbacad17 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -35,6 +35,7 @@ enum ControlType {\n \tControlTypeString,\n \tControlTypeRectangle,\n \tControlTypeSize,\n+\tControlTypePoint,\n };\n \n namespace details {\n@@ -97,6 +98,11 @@ struct control_type<Size> {\n \tstatic constexpr std::size_t size = 0;\n };\n \n+template<>\n+struct control_type<Point> {\n+\tstatic constexpr ControlType value = ControlTypePoint;\n+};\n+\n template<typename T, std::size_t N>\n struct control_type<Span<T, N>> : public control_type<std::remove_cv_t<T>> {\n \tstatic constexpr std::size_t size = N;\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex ea4397302a21..62185d643ecd 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -60,6 +60,7 @@ static constexpr size_t ControlValueSize[] = {\n \t[ControlTypeString]\t\t= sizeof(char),\n \t[ControlTypeRectangle]\t\t= sizeof(Rectangle),\n \t[ControlTypeSize]\t\t= sizeof(Size),\n+\t[ControlTypePoint]\t\t= sizeof(Point),\n };\n \n } /* namespace */\n@@ -254,6 +255,11 @@ std::string ControlValue::toString() const\n \t\t\tstr += value->toString();\n \t\t\tbreak;\n \t\t}\n+\t\tcase ControlTypePoint: {\n+\t\t\tconst Point *value = reinterpret_cast<const Point *>(data);\n+\t\t\tstr += value->toString();\n+\t\t\tbreak;\n+\t\t}\n \t\tcase ControlTypeNone:\n \t\tcase ControlTypeString:\n \t\t\tbreak;\n", "prefixes": [ "v10", "3/5" ] }