Patch Detail
Show a patch.
GET /api/patches/21401/?format=api
{ "id": 21401, "url": "https://patchwork.libcamera.org/api/patches/21401/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21401/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240927134624.801004-9-mzamazal@redhat.com>", "date": "2024-09-27T13:46:14", "name": "[v8,08/18] libcamera: software_isp: Create algorithms", "commit_ref": "97f9961e1bc85bec29d3d3b1cba05f46d83f4c27", "pull_url": null, "state": "accepted", "archived": false, "hash": "fe91538189980a8bddaf0ef98f5a8266d0d598f3", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21401/mbox/", "series": [ { "id": 4634, "url": "https://patchwork.libcamera.org/api/series/4634/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4634", "date": "2024-09-27T13:46:06", "name": "Software ISP refactoring", "version": 8, "mbox": "https://patchwork.libcamera.org/series/4634/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21401/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21401/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7CC8C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Sep 2024 13:47:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65E8863525;\n\tFri, 27 Sep 2024 15:47:01 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A164263525\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Sep 2024 15:46:55 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-161-m-egOW0fN5qXSVs2hg3dKw-1;\n\tFri, 27 Sep 2024 09:46:52 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 76FB81978166; Fri, 27 Sep 2024 13:46:51 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.123])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id ADCCA1956054; Fri, 27 Sep 2024 13:46:49 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OQGeQwsk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727444814;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fX6X2l+deAT+lHH2AGxej2dAVJdyCpHrz0u6+wAeXMw=;\n\tb=OQGeQwsk3d2Zp6GRzTMRNzzL572tTT+VxK+De8CmDCUlcxRk6Lmk2U1wk+Kedy8vAJhjrq\n\t3aRAn/3qCTN6O3YganCzJPRHiyAo972ZcqOMMjR2Z1sj0z7KRXKtGXcTTiKYIbdEyp5DeG\n\tf+ksy7WKnxjyavsXiP78jNAfPt/FuO4=", "X-MC-Unique": "m-egOW0fN5qXSVs2hg3dKw-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v8 08/18] libcamera: software_isp: Create algorithms", "Date": "Fri, 27 Sep 2024 15:46:14 +0200", "Message-ID": "<20240927134624.801004-9-mzamazal@redhat.com>", "In-Reply-To": "<20240927134624.801004-1-mzamazal@redhat.com>", "References": "<20240927134624.801004-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We are ready to introduce algorithms now. First, let's create\nalgorithms. The algorithms are not called yet, calls to them will be\nadded in followup patches.\n\nThe maximum number of contexts is set to the same value as in hardware\npipelines.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/algorithms/meson.build | 4 ++++\n src/ipa/simple/data/uncalibrated.yaml | 1 +\n src/ipa/simple/meson.build | 7 +++++--\n src/ipa/simple/soft_simple.cpp | 14 ++++++++++++++\n 4 files changed, 24 insertions(+), 2 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/meson.build", "diff": "diff --git a/src/ipa/simple/algorithms/meson.build b/src/ipa/simple/algorithms/meson.build\nnew file mode 100644\nindex 000000000..31d26e434\n--- /dev/null\n+++ b/src/ipa/simple/algorithms/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+soft_simple_ipa_algorithms = files([\n+])\ndiff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\nindex ff981a1a5..2cdc39a84 100644\n--- a/src/ipa/simple/data/uncalibrated.yaml\n+++ b/src/ipa/simple/data/uncalibrated.yaml\n@@ -2,4 +2,5 @@\n %YAML 1.1\n ---\n version: 1\n+algorithms:\n ...\ndiff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\nindex 7757f99ba..dcd7c70a8 100644\n--- a/src/ipa/simple/meson.build\n+++ b/src/ipa/simple/meson.build\n@@ -1,5 +1,8 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+subdir('algorithms')\n+subdir('data')\n+\n ipa_name = 'ipa_soft_simple'\n \n soft_simple_sources = files([\n@@ -8,6 +11,8 @@ soft_simple_sources = files([\n 'black_level.cpp',\n ])\n \n+soft_simple_sources += soft_simple_ipa_algorithms\n+\n mod = shared_module(ipa_name, soft_simple_sources,\n name_prefix : '',\n include_directories : [ipa_includes],\n@@ -24,6 +29,4 @@ if ipa_sign_module\n build_by_default : true)\n endif\n \n-subdir('data')\n-\n ipa_names += ipa_name\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 12b5245ed..79ed4891b 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -54,12 +54,15 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n * enough to prevent the exposure from wobbling around the optimal value.\n */\n static constexpr float kExposureSatisfactory = 0.2;\n+/* Maximum number of frame contexts to be held */\n+static constexpr uint32_t kMaxFrameContexts = 16;\n \n class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n {\n public:\n \tIPASoftSimple()\n \t\t: params_(nullptr), stats_(nullptr), blackLevel_(BlackLevel()),\n+\t\t context_({ {}, {}, { kMaxFrameContexts } }),\n \t\t ignoreUpdates_(0)\n \t{\n \t}\n@@ -93,6 +96,8 @@ private:\n \tstatic constexpr unsigned int kGammaLookupSize = 1024;\n \tstd::array<uint8_t, kGammaLookupSize> gammaTable_;\n \tint lastBlackLevel_ = -1;\n+\t/* Local parameter storage */\n+\tstruct IPAContext context_;\n \n \tint32_t exposureMin_, exposureMax_;\n \tint32_t exposure_;\n@@ -139,6 +144,15 @@ int IPASoftSimple::init(const IPASettings &settings,\n \tunsigned int version = (*data)[\"version\"].get<uint32_t>(0);\n \tLOG(IPASoft, Debug) << \"Tuning file version \" << version;\n \n+\tif (!data->contains(\"algorithms\")) {\n+\t\tLOG(IPASoft, Error) << \"Tuning file doesn't contain algorithms\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tint ret = createAlgorithms(context_, (*data)[\"algorithms\"]);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tparams_ = nullptr;\n \tstats_ = nullptr;\n \n", "prefixes": [ "v8", "08/18" ] }