Patch Detail
Show a patch.
GET /api/patches/21364/?format=api
{ "id": 21364, "url": "https://patchwork.libcamera.org/api/patches/21364/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21364/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240925095850.348259-13-mzamazal@redhat.com>", "date": "2024-09-25T09:58:44", "name": "[v4,12/15] config: Allow enabling software ISP in runtime", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d1c2672a15765a7922ead9e12ba9536c7d3918ca", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21364/mbox/", "series": [ { "id": 4623, "url": "https://patchwork.libcamera.org/api/series/4623/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4623", "date": "2024-09-25T09:58:32", "name": "Add global configuration file", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4623/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21364/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21364/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA7C7C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Sep 2024 09:59:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F4586352D;\n\tWed, 25 Sep 2024 11:59:40 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 370076351E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Sep 2024 11:59:31 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-694-_dA5lW7eO1-H62xRb_kNbw-1;\n\tWed, 25 Sep 2024 05:59:28 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E3534193EF48; Wed, 25 Sep 2024 09:59:27 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.29])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6074B19560AA; Wed, 25 Sep 2024 09:59:26 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"NMsTJ7gC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727258370;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=RYgQT76rk+4hTKWYuoxJzN6BXaXJX7nCg23Ut1nJCZM=;\n\tb=NMsTJ7gC43zq5QlQVrh4YH6BEIjhIv+fQWk5Lm4cLlzDSAYdPfOZTcyf5hpCSvkKxRz+Ls\n\tpv765JOBR0kj/i1EjFy7xASzl0RhCzX82HBONHfdI75sKt4pDxphsZEPOzfLA4OP7zU3s7\n\tJNyqb0j1wr3yUqYv8AKkdPc7xKPQ/vg=", "X-MC-Unique": "_dA5lW7eO1-H62xRb_kNbw-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v4 12/15] config: Allow enabling software ISP in runtime", "Date": "Wed, 25 Sep 2024 11:58:44 +0200", "Message-ID": "<20240925095850.348259-13-mzamazal@redhat.com>", "In-Reply-To": "<20240925095850.348259-1-mzamazal@redhat.com>", "References": "<20240925095850.348259-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch allows enabling or disabling software ISP in runtime in\naddition to compile time. This can be useful for software ISP testing\non various platforms as well as for overriding the defaults in case the\ndefaults don't work well (e.g. hardware ISP may or may not work on\ni.MX8MP depending on the kernel and libcamera patches present in the\ngiven system).\n\nThe configuration is specified as follows:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: DRIVER-NAME\n software_isp: BOOLEAN\n - ...\n\nFor example:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: mxc-isi\n software_isp: true\n\nThe overall configuration of enabling or disabling software ISP may get\ndropped in future but this patch is still useful in the meantime.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 81915573b..78f446fb6 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -32,6 +32,7 @@\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/converter.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/software_isp/software_isp.h\"\n@@ -1541,6 +1542,17 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t}\n \n \tswIspEnabled_ = info->swIspEnabled;\n+\tfor (GlobalConfiguration::Configuration entry :\n+\t GlobalConfiguration::configuration()\n+\t\t [\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t\t\t .asList()) {\n+\t\tauto name = entry[\"driver\"].get<std::string>();\n+\t\tif (name.has_value() and !name.value().compare(info->driver)) {\n+\t\t\tswIspEnabled_ = entry[\"software_isp\"].get<bool>().value_or(swIspEnabled_);\n+\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n \n \t/* Locate the sensors. */\n \tstd::vector<MediaEntity *> sensors = locateSensors(media);\n", "prefixes": [ "v4", "12/15" ] }