Patch Detail
Show a patch.
GET /api/patches/21340/?format=api
{ "id": 21340, "url": "https://patchwork.libcamera.org/api/patches/21340/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21340/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240924090051.1617040-2-chenghaoyang@google.com>", "date": "2024-09-24T08:26:10", "name": "[v2,1/2] libcamera: Add gc05a2 camera sensor proprietary for ciri", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "525b1433f3c725af5ea02ecb6df5be0c9aabc58a", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21340/mbox/", "series": [ { "id": 4617, "url": "https://patchwork.libcamera.org/api/series/4617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4617", "date": "2024-09-24T08:26:09", "name": "Add camera sensor properties for ciri", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21340/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21340/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EBA8C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Sep 2024 09:01:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03B5863514;\n\tTue, 24 Sep 2024 11:01:01 +0200 (CEST)", "from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com\n\t[IPv6:2607:f8b0:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA8DA634F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2024 11:00:58 +0200 (CEST)", "by mail-pl1-x62f.google.com with SMTP id\n\td9443c01a7336-2054e22ce3fso52218015ad.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2024 02:00:58 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-20af185853dsm6803885ad.265.2024.09.24.02.00.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Sep 2024 02:00:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"jJT7hgX2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727168457; x=1727773257;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=foSmkcJXyx1QavPPb4g+Uwf2bhegj0k51OKwBYu/aGE=;\n\tb=jJT7hgX26qIujkxC4Ik+zJU77oL5qi+LJsVQeubv70AHmTNLr/TY+P2e0IaLuE8x8d\n\t37aeOCjJyNHLaAcKJ+dARJ+/FqEUDMFQelC+ks6VrUJ4GYkpRH4ZHAy8fXpwwS8oJEMT\n\t5zdBiKe4Rq9sQbWRrKPfzXQrCNpYaDDa0qayA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727168457; x=1727773257;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=foSmkcJXyx1QavPPb4g+Uwf2bhegj0k51OKwBYu/aGE=;\n\tb=Eqte5gi+Fg2dXzMJB72zC2PibxL0HEVzX6QPHm/TA8hqnrbw5Q0O1YtzK6acXRiOLW\n\tdpQ7LTBuTdX1DR5cRtFa+tyQj1uc7OULGFfGishixR8wL8cifBMjlpiFBCagvhdJ3ONG\n\tc1WU0zU/cPeIRsRdToraw8TpGqB/gEKr+YVOsqYBZ29Md6YIP2VPqcS5URssMPl09omz\n\t0gUOPBk22O+ETMYAPrpD/cHANcz+yAS2L5COe7gtV2TJYUA+pjH5NsBqIJdgCt8tWqHm\n\t0FMwEjdWWrJ0DzHiHWRfRRemMhpivVSxxhLOD/s7McIe8sWUfq8bNRFOSsUBxlp8IwZs\n\tJGlQ==", "X-Gm-Message-State": "AOJu0YwFPntSaIlhIthkBNmH387XtABM6GTxai+UosnJUcFnF2yDr5Tv\n\tRrFYoRz0t5uOmRiAH7WZC9/J/DCz+bmI39ahANMOSDVpOB7KoQGtPgsUt72a85YtV8pw57WcTCo\n\t=", "X-Google-Smtp-Source": "AGHT+IEZnBjlPgOVCRg3NqE3tfO8Fz3rYqhTo3jhxEiTj+OMp7GriisanarzML1ZX/mB90IoKUujhw==", "X-Received": "by 2002:a17:902:d4c9:b0:205:674f:31c2 with SMTP id\n\td9443c01a7336-208d83040d7mr182854655ad.9.1727168457079; \n\tTue, 24 Sep 2024 02:00:57 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>,\n\tHan-Lin Chen <hanlinchen@chromium.org>, Xing Gu <xinggu@chromium.org>,\n\tYudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH v2 1/2] libcamera: Add gc05a2 camera sensor proprietary for\n\tciri", "Date": "Tue, 24 Sep 2024 08:26:10 +0000", "Message-ID": "<20240924090051.1617040-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.0.792.g87dc391469-goog", "In-Reply-To": "<20240924090051.1617040-1-chenghaoyang@google.com>", "References": "<20240924090051.1617040-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "gc05a2 is the first sensor used by ciri.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Xing Gu <xinggu@chromium.org>\nCo-developed-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 17 +++++++++++++++++\n .../sensor/camera_sensor_properties.cpp | 7 +++++++\n 2 files changed, 24 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex ffc7c1d7..cd7d12d6 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -519,6 +519,23 @@ private:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ar0521\", CameraSensorHelperAr0521)\n \n+class CameraSensorHelperGc05a2 : public CameraSensorHelper\n+{\n+public:\n+\tuint32_t gainCode(double gain) const override\n+\t{\n+\t\tuint32_t aeGain = std::clamp((uint32_t)gain, kAeBaseGain_, kStep_ * kAeBaseGain_);\n+\t\treturn aeGain * 0x400 / kAeBaseGain_;\n+\t}\n+\n+\t// `double gain(uint32_t gainCode)` will not be used.\n+\n+private:\n+\tstatic constexpr uint32_t kStep_ = 16;\n+\tstatic constexpr uint32_t kAeBaseGain_ = 1024;\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n+\n class CameraSensorHelperImx219 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 4e5217ab..3e1bd85e 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -70,6 +70,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"gc05a2\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "v2", "1/2" ] }