Patch Detail
Show a patch.
GET /api/patches/21257/?format=api
{ "id": 21257, "url": "https://patchwork.libcamera.org/api/patches/21257/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21257/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240913075750.35115-9-stefan.klug@ideasonboard.com>", "date": "2024-09-13T07:57:26", "name": "[v2,8/9] ipa: rkisp1: Add sensor info to context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "674a2dccee19bb67124d55365a7f97cc6e46c4b4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21257/mbox/", "series": [ { "id": 4587, "url": "https://patchwork.libcamera.org/api/series/4587/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4587", "date": "2024-09-13T07:57:18", "name": "Implement polynomial lsc support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4587/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21257/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21257/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DCF4C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Sep 2024 07:58:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC78163509;\n\tFri, 13 Sep 2024 09:58:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62DE663504\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Sep 2024 09:58:16 +0200 (CEST)", "from ideasonboard.com (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AE601011;\n\tFri, 13 Sep 2024 09:56:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YN9BHp4Q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726214217;\n\tbh=Ddnboubq04MBc79+AsxPZLaJr0dyGKhRBhZd8P5psVI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YN9BHp4QyD4069VI0oDaDZj61d20KJGO5ESV2+OpHq4bjtdH8GDivUW+p3IMiA/rZ\n\tuYeBhI5N0YP1TubWyo+q+tIvvB04aZQeqrQUr9Rz9MkJ0H7MWeg1+rgobmbzoKKx1K\n\tVexy25/iDsPFdiInlT+clLtmKTGZ8BE0vnNpnJfg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 8/9] ipa: rkisp1: Add sensor info to context", "Date": "Fri, 13 Sep 2024 09:57:26 +0200", "Message-ID": "<20240913075750.35115-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240913075750.35115-1-stefan.klug@ideasonboard.com>", "References": "<20240913075750.35115-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the LSC algorithm to dynamically calculate the LSC tables based on\nthe sensor size and the crop rectangle it needs access to that data.\nProvide access to it by adding the sensorInfo object to the context.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/ipa_context.h | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 4 +++-\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 3af2774a7fc8..e274d9b01e1c 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -17,6 +17,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n #include <libcamera/geometry.h>\n+#include <libcamera/ipa/core_ipa_interface.h>\n \n #include <libipa/camera_sensor_helper.h>\n #include <libipa/fc_queue.h>\n@@ -180,6 +181,7 @@ struct IPAFrameContext : public FrameContext {\n \n struct IPAContext {\n \tconst IPAHwSettings *hw;\n+\tIPACameraSensorInfo sensorInfo;\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 78d2c375d6dc..9e161cabdea4 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -124,7 +124,7 @@ const ControlInfoMap::Map rkisp1Controls{\n } /* namespace */\n \n IPARkISP1::IPARkISP1()\n-\t: context_({ {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n+\t: context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n {\n }\n \n@@ -158,6 +158,8 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \n \tLOG(IPARkISP1, Debug) << \"Hardware revision is \" << hwRevision;\n \n+\tcontext_.sensorInfo = sensorInfo;\n+\n \tcontext_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel);\n \tif (!context_.camHelper) {\n \t\tLOG(IPARkISP1, Error)\n", "prefixes": [ "v2", "8/9" ] }