Patch Detail
Show a patch.
GET /api/patches/21230/?format=api
{ "id": 21230, "url": "https://patchwork.libcamera.org/api/patches/21230/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21230/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240911093600.671979-3-paul.elder@ideasonboard.com>", "date": "2024-09-11T09:35:59", "name": "[v3,2/3] apps: cam: Print control enum values more nicely", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1376f5acb25f3b3502aebed6530bf76569356739", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21230/mbox/", "series": [ { "id": 4579, "url": "https://patchwork.libcamera.org/api/series/4579/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4579", "date": "2024-09-11T09:35:57", "name": "libcamera: controls: Add enum information to ControlId", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4579/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21230/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21230/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A574C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Sep 2024 09:36:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A075634FD;\n\tWed, 11 Sep 2024 11:36:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AB6B634F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Sep 2024 11:36:18 +0200 (CEST)", "from pyrite.hamster-moth.ts.net\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 843CABEB;\n\tWed, 11 Sep 2024 11:35:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Is5W4NNL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726047300;\n\tbh=c6svChRR/G6yEUvhfG8OKLKYhvx8tqXtO3PGOJJc0V4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Is5W4NNL3nLfuAySdpDb8xZ+YA6zukbIwm96VxXi2/SZYLCQOaOAZmQaGqrS/FMAE\n\tX/JKW1Jhd0lC/mUsTcOwBaH/2je9G/JdBQ+rhHOxdcZ4Qf1UpTOxu2UH8ukLqYjL3A\n\tmXaQVDRgCiEokpOvC2S1ssmH5Hltvzz042PBl1aQ=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>, stefan.klug@ideasonboard.com, \n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v3 2/3] apps: cam: Print control enum values more nicely", "Date": "Wed, 11 Sep 2024 11:35:59 +0200", "Message-Id": "<20240911093600.671979-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240911093600.671979-1-paul.elder@ideasonboard.com>", "References": "<20240911093600.671979-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that enum names can be obtained from ControlId, use that information\nto print out the list of supported enum values in --list-controls.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n---\nChanges in v3:\n- s/enumName/enumToString/\n\nNo change in v2\n---\n src/apps/cam/camera_session.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 097dc4792..37de6c9f3 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -159,8 +159,16 @@ CameraSession::~CameraSession()\n void CameraSession::listControls() const\n {\n \tfor (const auto &[id, info] : camera_->controls()) {\n-\t\tstd::cout << \"Control: \" << id->name() << \": \"\n-\t\t\t << info.toString() << std::endl;\n+\t\tif (info.values().size() == 0) {\n+\t\t\tstd::cout << \"Control: \" << id->name() << \": \"\n+\t\t\t\t << info.toString() << std::endl;\n+\t\t} else {\n+\t\t\tstd::cout << \"Control: \" << id->name() << \": \" << std::endl;\n+\t\t\tfor (const auto &value : info.values()) {\n+\t\t\t\tint32_t val = value.get<int32_t>();\n+\t\t\t\tstd::cout << \" - \" << id->enumToString(val) << \" (\" << val << \")\" << std::endl;\n+\t\t\t}\n+\t\t}\n \t}\n }\n \n", "prefixes": [ "v3", "2/3" ] }