Patch Detail
Show a patch.
GET /api/patches/21226/?format=api
{ "id": 21226, "url": "https://patchwork.libcamera.org/api/patches/21226/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21226/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240910234649.28591-3-laurent.pinchart@ideasonboard.com>", "date": "2024-09-10T23:46:48", "name": "[2/3] qcam: viewfinder_gl: Drop duplicate glClearColor()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "834a6818e15ab152179a56c4de75b8afff3d271c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21226/mbox/", "series": [ { "id": 4578, "url": "https://patchwork.libcamera.org/api/series/4578/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4578", "date": "2024-09-10T23:46:46", "name": "qcam: Fix GL renderer on Qt 6", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4578/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21226/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21226/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B6F4BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Sep 2024 23:47:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 002C6634FD;\n\tWed, 11 Sep 2024 01:47:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9917F634FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Sep 2024 01:47:25 +0200 (CEST)", "from pendragon.ideasonboard.com\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BA92108D;\n\tWed, 11 Sep 2024 01:46:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nVy5jsmA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726011968;\n\tbh=tBB/fm/QHR7uGKEdy9aFeQXVkHB9SG45Rlj9Mz3TBII=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nVy5jsmA/iT8Jv9kag9i3HuuusPhCulpgqrYx/V8DlASw4QN5DFrKHPno4osvFE7I\n\ttnbkFSQZI4pY7pJRTRXXHPvJsCdPv/GfnWAuW/0eHUgtZpo5qwEsvZXxELTErbVwXz\n\tCJlZROsqlm8w8YvUO8COIeCFa0iXle4Jqyxev5Z4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Neal Gompa <neal@gompa.dev>", "Subject": "[PATCH 2/3] qcam: viewfinder_gl: Drop duplicate glClearColor()", "Date": "Wed, 11 Sep 2024 02:46:48 +0300", "Message-ID": "<20240910234649.28591-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240910234649.28591-1-laurent.pinchart@ideasonboard.com>", "References": "<20240910234649.28591-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There's no need to call glClearColor() twice before drawing any GL\ncontent. Drop the first call. This doesn't introduce any functional\nchange.\n\nWhile at it, pass floats instead of doubles to glClearColor(), as\nrequired by the function.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/qcam/viewfinder_gl.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 5be7bec539bf..b2096faf859f 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -533,8 +533,6 @@ void ViewFinderGL::initializeGL()\n \t/* Create Vertex Shader */\n \tif (!createVertexShader())\n \t\tqWarning() << \"[ViewFinderGL]: create vertex shader failed.\";\n-\n-\tglClearColor(1.0f, 1.0f, 1.0f, 0.0f);\n }\n \n void ViewFinderGL::doRender()\n@@ -821,7 +819,7 @@ void ViewFinderGL::paintGL()\n \t}\n \n \tif (image_) {\n-\t\tglClearColor(0.0, 0.0, 0.0, 1.0);\n+\t\tglClearColor(0.0f, 0.0f, 0.0f, 1.0f);\n \t\tglClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);\n \n \t\tdoRender();\n", "prefixes": [ "2/3" ] }