Patch Detail
Show a patch.
GET /api/patches/21202/?format=api
{ "id": 21202, "url": "https://patchwork.libcamera.org/api/patches/21202/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21202/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240909132204.14147-1-david.plowman@raspberrypi.com>", "date": "2024-09-09T13:22:04", "name": "ipa: rpi: agc: Ignore stable region when exposure/gain set manually", "commit_ref": "5c5bc85082fce87d66964207f4e0292807f591a3", "pull_url": null, "state": "accepted", "archived": false, "hash": "1a6c18db11487151bcc471c8e6241f618f54c3f7", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21202/mbox/", "series": [ { "id": 4570, "url": "https://patchwork.libcamera.org/api/series/4570/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4570", "date": "2024-09-09T13:22:04", "name": "ipa: rpi: agc: Ignore stable region when exposure/gain set manually", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4570/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21202/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21202/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84AC5C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 9 Sep 2024 13:22:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48003634F8;\n\tMon, 9 Sep 2024 15:22:18 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37C3B634EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Sep 2024 15:22:16 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-42cb1e623d1so15289335e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 09 Sep 2024 06:22:16 -0700 (PDT)", "from davidp-xps-13.pitowers.org\n\t([2a00:1098:3142:1f:fd43:a9ee:72a9:6fe2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42caeb21a4esm77996675e9.7.2024.09.09.06.22.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Sep 2024 06:22:14 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qXtxzk2p\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1725888135; x=1726492935;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jEFbbNV4LothFiZLCissoTU9VSYV3NqGfnrPBZFM0G0=;\n\tb=qXtxzk2pdAr58SJMoPIt9UOFSP+TbK3vGdQTZqI5PJrQue+S4jZgKWExCSQ0ehKB+U\n\t5cAzKcKelFYFNAkiNT+c+KLGLTespsz7GuxFN3uDS9ZlNHhJMzTYp2BjqH0iXBwtNMw9\n\tTlkqqb9LwIhCMgVGT86vzY9GRGWhZksEVbVPAuOFYXcHjsOFemgTjilmQ3Nhol97YZai\n\tMGHbTkkmTyPojczy1wL2KvjpOoJSV/FG1f+Jaftwr9K4WQAGpPWM2o4oT039MNGHvWLr\n\tY2Oxv6EapOkGm2Fyap0UqwMdL1XaDGAq1Vt+ozn+tvYkCyAsIR8tZXfUrK3bh5QbY+KR\n\tZI3Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725888135; x=1726492935;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=jEFbbNV4LothFiZLCissoTU9VSYV3NqGfnrPBZFM0G0=;\n\tb=LFdW1IxtxbjeguFNSDnH7Yf6UIA7sgYkt4UTOrqHDGNL+epcEnY81EnWCFRGd7R+KO\n\tQX08tHc6f+ej6pP2pHT8PAdw7nm4JXsQbX33NpcdG96mUeKOsdsJ0gYNtdSfeaNTmAXM\n\t48oOwjGWiMgf+N49aQZABIUqfN1/TDiBm6gLNRonysypw1BDqgGTutbK871+uj4Zle1d\n\tZSDqju0O/mku2gMxzhXXeKbrXBlvaaP13m2CHj8gawZ8kJ6eCjGV1JElgiLjDMSlDgMQ\n\t5BXOVCMVarUBHLDWjIQCWQFQ1ngEywWdD5xThVxUHBQpwypKnTzK++1JgM5P/WD5DKzf\n\tzHBQ==", "X-Gm-Message-State": "AOJu0YygKDzf59IZP9bM5FFlIB7CZribasMY9fsMbOVC708ytvzpsZHI\n\tKAUB81CGHEiIxq/iBHtUzkA6DdcHpVdu+U8MFaZMwEcEf/VNliuvQJkBynVUGC6GTEaqhpbRAiv\n\tW", "X-Google-Smtp-Source": "AGHT+IHqNMweRXDzni6Kuqp2TOkUgOL+hPB1Ki67A/LuGYMRhx52z4vAkNjhb327zEbTuzvvdb1lyQ==", "X-Received": "by 2002:adf:f34c:0:b0:367:9d05:cf1f with SMTP id\n\tffacd0b85a97d-378895cafc0mr6814326f8f.14.1725888134602; \n\tMon, 09 Sep 2024 06:22:14 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH] ipa: rpi: agc: Ignore stable region when exposure/gain set\n\tmanually", "Date": "Mon, 9 Sep 2024 14:22:04 +0100", "Message-Id": "<20240909132204.14147-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a user is taking control of exposure and gain, setting them\nmanually, we set the AGC \"stable region\" to zero. This means that any\nuser changes, however small, will be applied, and they won't be\nregarded as \"too small to bother with\".\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\nindex cf2565a8..c9df9b5b 100644\n--- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n@@ -883,11 +883,14 @@ void AgcChannel::filterExposure()\n \n \t/*\n \t * AGC adapts instantly if both shutter and gain are directly specified\n-\t * or we're in the startup phase.\n+\t * or we're in the startup phase. Also disable the stable region, because we want\n+\t * to reflect any user exposure/gain updates, however small.\n \t */\n \tif ((status_.fixedShutter && status_.fixedAnalogueGain) ||\n-\t frameCount_ <= config_.startupFrames)\n+\t frameCount_ <= config_.startupFrames) {\n \t\tspeed = 1.0;\n+\t\tstableRegion = 0.0;\n+\t}\n \tif (!filtered_.totalExposure) {\n \t\tfiltered_.totalExposure = target_.totalExposure;\n \t} else if (filtered_.totalExposure * (1.0 - stableRegion) < target_.totalExposure &&\n", "prefixes": [] }