Patch Detail
Show a patch.
GET /api/patches/21179/?format=api
{ "id": 21179, "url": "https://patchwork.libcamera.org/api/patches/21179/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21179/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240906120927.4071508-7-mzamazal@redhat.com>", "date": "2024-09-06T12:09:15", "name": "[v6,06/18] libcamera: software_isp: Remove final dots in debayer.cpp docstrings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c45739d9c7ada80ed5dc4f6f51cc435180dd42c6", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21179/mbox/", "series": [ { "id": 4566, "url": "https://patchwork.libcamera.org/api/series/4566/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4566", "date": "2024-09-06T12:09:09", "name": "Software ISP refactoring", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4566/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21179/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21179/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21BA3C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Sep 2024 12:10:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6F1B634FA;\n\tFri, 6 Sep 2024 14:10:15 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59053634F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Sep 2024 14:10:07 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-456-akvGVTJ7NdyVNx4tFndzPA-1;\n\tFri, 06 Sep 2024 08:10:03 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 12C701953941; Fri, 6 Sep 2024 12:10:02 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.65])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E0D641956086; Fri, 6 Sep 2024 12:09:59 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XW2CiDji\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725624606;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=1KZmM50ODUWNoDjYHlqfTIxDIdoCNLWj3qYt2cCvtr4=;\n\tb=XW2CiDjiRvBMck7ujlNe6h3a2pOtw+CeJejHH1e7rbes1T/W9Y87TL+VJ7qt5R2oz/D+Px\n\tlSgwVSFvR6cVa1Lmx7mf6d2oJ2u+bdeZFxqDlLeWZjZ4ffjxeN07u5E2zhnoFsBc+A/cFD\n\tgFnCI2UcwJLUxLB2kiqWDY0FbIVyLwE=", "X-MC-Unique": "akvGVTJ7NdyVNx4tFndzPA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v6 06/18] libcamera: software_isp: Remove final dots in\n\tdebayer.cpp docstrings", "Date": "Fri, 6 Sep 2024 14:09:15 +0200", "Message-ID": "<20240906120927.4071508-7-mzamazal@redhat.com>", "In-Reply-To": "<20240906120927.4071508-1-mzamazal@redhat.com>", "References": "<20240906120927.4071508-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The policy and the style checker require that \\brief, \\param and \\return\ntexts don't finish with a dot. This needs to be fixed in debayer.cpp.\nAlso leading spaces in a \\return statement are removed from there.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/software_isp/debayer.cpp | 48 +++++++++++++-------------\n 1 file changed, 24 insertions(+), 24 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex f4a299d5..db26c380 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -58,47 +58,47 @@ Debayer::~Debayer()\n \n /**\n * \\fn int Debayer::configure(const StreamConfiguration &inputCfg, const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs)\n- * \\brief Configure the debayer object according to the passed in parameters.\n- * \\param[in] inputCfg The input configuration.\n- * \\param[in] outputCfgs The output configurations.\n+ * \\brief Configure the debayer object according to the passed in parameters\n+ * \\param[in] inputCfg The input configuration\n+ * \\param[in] outputCfgs The output configurations\n *\n- * \\return 0 on success, a negative errno on failure.\n+ * \\return 0 on success, a negative errno on failure\n */\n \n /**\n * \\fn Size Debayer::patternSize(PixelFormat inputFormat)\n- * \\brief Get the width and height at which the bayer pattern repeats.\n- * \\param[in] inputFormat The input format.\n+ * \\brief Get the width and height at which the bayer pattern repeats\n+ * \\param[in] inputFormat The input format\n *\n * Valid sizes are: 2x2, 4x2 or 4x4.\n *\n- * \\return Pattern size or an empty size for unsupported inputFormats.\n+ * \\return Pattern size or an empty size for unsupported inputFormats\n */\n \n /**\n * \\fn std::vector<PixelFormat> Debayer::formats(PixelFormat inputFormat)\n- * \\brief Get the supported output formats.\n- * \\param[in] inputFormat The input format.\n+ * \\brief Get the supported output formats\n+ * \\param[in] inputFormat The input format\n *\n- * \\return All supported output formats or an empty vector if there are none.\n+ * \\return All supported output formats or an empty vector if there are none\n */\n \n /**\n * \\fn std::tuple<unsigned int, unsigned int> Debayer::strideAndFrameSize(const PixelFormat &outputFormat, const Size &size)\n- * \\brief Get the stride and the frame size.\n- * \\param[in] outputFormat The output format.\n- * \\param[in] size The output size.\n+ * \\brief Get the stride and the frame size\n+ * \\param[in] outputFormat The output format\n+ * \\param[in] size The output size\n *\n * \\return A tuple of the stride and the frame size, or a tuple with 0,0 if\n- * there is no valid output config.\n+ * there is no valid output config\n */\n \n /**\n * \\fn void Debayer::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n- * \\brief Process the bayer data into the requested format.\n- * \\param[in] input The input buffer.\n- * \\param[in] output The output buffer.\n- * \\param[in] params The parameters to be used in debayering.\n+ * \\brief Process the bayer data into the requested format\n+ * \\param[in] input The input buffer\n+ * \\param[in] output The output buffer\n+ * \\param[in] params The parameters to be used in debayering\n *\n * \\note DebayerParams is passed by value deliberately so that a copy is passed\n * when this is run in another thread by invokeMethod().\n@@ -106,21 +106,21 @@ Debayer::~Debayer()\n \n /**\n * \\fn virtual SizeRange Debayer::sizes(PixelFormat inputFormat, const Size &inputSize)\n- * \\brief Get the supported output sizes for the given input format and size.\n- * \\param[in] inputFormat The input format.\n- * \\param[in] inputSize The input size.\n+ * \\brief Get the supported output sizes for the given input format and size\n+ * \\param[in] inputFormat The input format\n+ * \\param[in] inputSize The input size\n *\n- * \\return The valid size ranges or an empty range if there are none.\n+ * \\return The valid size ranges or an empty range if there are none\n */\n \n /**\n * \\var Signal<FrameBuffer *> Debayer::inputBufferReady\n- * \\brief Signals when the input buffer is ready.\n+ * \\brief Signals when the input buffer is ready\n */\n \n /**\n * \\var Signal<FrameBuffer *> Debayer::outputBufferReady\n- * \\brief Signals when the output buffer is ready.\n+ * \\brief Signals when the output buffer is ready\n */\n \n } /* namespace libcamera */\n", "prefixes": [ "v6", "06/18" ] }