Patch Detail
Show a patch.
GET /api/patches/21166/?format=api
{ "id": 21166, "url": "https://patchwork.libcamera.org/api/patches/21166/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21166/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240905162508.4169-3-laurent.pinchart@ideasonboard.com>", "date": "2024-09-05T16:25:08", "name": "[2/2] qcam: viewfinder_qt: Render stopped icon on a black background", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "b7be808240a3349448e83ac4f1f9448bcf0c3cc5", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21166/mbox/", "series": [ { "id": 4563, "url": "https://patchwork.libcamera.org/api/series/4563/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4563", "date": "2024-09-05T16:25:06", "name": "qcam: Use black background", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4563/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21166/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21166/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88403BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 5 Sep 2024 16:25:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DBD1634EC;\n\tThu, 5 Sep 2024 18:25:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAF24634E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Sep 2024 18:25:13 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47DAE3E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Sep 2024 18:24:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RDivcgmZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725553440;\n\tbh=VeyMbtIOBmVq2alwV85YSVU9tXQDafkh1F25AlrJ7VU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RDivcgmZz/gsq1xivBZwSF+lHGmdLUC8J+CGxYf58FWsTRxPt0FpblooA2amkNUmA\n\tOjxGkg+KacEaU+OqZohaL/38b0LCKaR4AW5+WQkuqNiHmGVO3IQvS14DVAvnzu3291\n\tOnZ0CpALligmBf9qsa8gKVqqVw9o6efqlH0za61Q=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 2/2] qcam: viewfinder_qt: Render stopped icon on a black\n\tbackground", "Date": "Thu, 5 Sep 2024 19:25:08 +0300", "Message-ID": "<20240905162508.4169-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240905162508.4169-1-laurent.pinchart@ideasonboard.com>", "References": "<20240905162508.4169-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To match the black letterboxes, render the stoppid icon on a black\nbackground.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/qcam/assets/feathericons/camera-off.svg | 2 +-\n src/apps/qcam/viewfinder_qt.cpp | 5 +++--\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/apps/qcam/assets/feathericons/camera-off.svg b/src/apps/qcam/assets/feathericons/camera-off.svg\nindex daa3e25f0c1d..2d36b59c8b52 100644\n--- a/src/apps/qcam/assets/feathericons/camera-off.svg\n+++ b/src/apps/qcam/assets/feathericons/camera-off.svg\n@@ -1 +1 @@\n-<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"24\" height=\"24\" viewBox=\"0 0 24 24\" fill=\"none\" stroke=\"currentColor\" stroke-width=\"2\" stroke-linecap=\"round\" stroke-linejoin=\"round\" class=\"feather feather-camera-off\"><line x1=\"1\" y1=\"1\" x2=\"23\" y2=\"23\"></line><path d=\"M21 21H3a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h3m3-3h6l2 3h4a2 2 0 0 1 2 2v9.34m-7.72-2.06a4 4 0 1 1-5.56-5.56\"></path></svg>\n\\ No newline at end of file\n+<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"24\" height=\"24\" viewBox=\"0 0 24 24\" fill=\"none\" stroke=\"#c0c0c0\" stroke-width=\"2\" stroke-linecap=\"round\" stroke-linejoin=\"round\" class=\"feather feather-camera-off\"><line x1=\"1\" y1=\"1\" x2=\"23\" y2=\"23\"></line><path d=\"M21 21H3a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h3m3-3h6l2 3h4a2 2 0 0 1 2 2v9.34m-7.72-2.06a4 4 0 1 1-5.56-5.56\"></path></svg>\ndiff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\nindex 62b6f27fa23e..b0d63f3fa5ea 100644\n--- a/src/apps/qcam/viewfinder_qt.cpp\n+++ b/src/apps/qcam/viewfinder_qt.cpp\n@@ -48,6 +48,8 @@ ViewFinderQt::ViewFinderQt(QWidget *parent)\n \tQPalette pal = palette();\n \tpal.setColor(QPalette::Window, Qt::black);\n \tsetPalette(pal);\n+\n+\tsetAttribute(Qt::WA_OpaquePaintEvent, true);\n }\n \n ViewFinderQt::~ViewFinderQt()\n@@ -122,7 +124,6 @@ void ViewFinderQt::render(libcamera::FrameBuffer *buffer, Image *image)\n \t\t}\n \t}\n \n-\tsetAttribute(Qt::WA_OpaquePaintEvent, true);\n \tupdate();\n \n \tif (buffer)\n@@ -138,7 +139,6 @@ void ViewFinderQt::stop()\n \t\tbuffer_ = nullptr;\n \t}\n \n-\tsetAttribute(Qt::WA_OpaquePaintEvent, false);\n \tupdate();\n }\n \n@@ -194,6 +194,7 @@ void ViewFinderQt::paintEvent(QPaintEvent *)\n \telse\n \t\tpoint.setY((height() - pixmap_.height()) / 2);\n \n+\tpainter.drawRect(rect());\n \tpainter.drawPixmap(point, pixmap_);\n }\n \n", "prefixes": [ "2/2" ] }