Patch Detail
Show a patch.
GET /api/patches/21135/?format=api
{ "id": 21135, "url": "https://patchwork.libcamera.org/api/patches/21135/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21135/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240902154212.1281257-6-mzamazal@redhat.com>", "date": "2024-09-02T15:41:58", "name": "[v3,05/18] libcamera: rkisp1: Remove unused includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2e480f1fa13ac22ccb5dbbfeee4e8ed96c16571d", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21135/mbox/", "series": [ { "id": 4556, "url": "https://patchwork.libcamera.org/api/series/4556/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4556", "date": "2024-09-02T15:41:53", "name": "Remove unused includes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4556/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21135/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21135/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1275CBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 2 Sep 2024 15:42:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6029634F0;\n\tMon, 2 Sep 2024 17:42:47 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBD9B634E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 2 Sep 2024 17:42:44 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-520-3nCAnJylPWytZV0omulzFA-1;\n\tMon, 02 Sep 2024 11:42:40 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id BD0071955BED; Mon, 2 Sep 2024 15:42:39 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 4BB451955DD6; Mon, 2 Sep 2024 15:42:38 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"CEvzPdI6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291763;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=A626K6lp5Ljcqd0KzfsnAauCfY8eptu75UMFF3thXCA=;\n\tb=CEvzPdI6XZmO7jwIPTY5EVfWgKNwanmLCR2LHzE7lltvXlW8Kn5yFj08x9BN2JleqjEPgg\n\tQsq7KaVSUmwXZpMayQS6i6T1k3YTqktALvZx/bpHnV1u+GGW2n+dpjDMWnF2AX2DoRjQ7z\n\tUQFjqmozssZEoES4Lu5hbjqcCp8dv3o=", "X-MC-Unique": "3nCAnJylPWytZV0omulzFA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 05/18] libcamera: rkisp1: Remove unused includes", "Date": "Mon, 2 Sep 2024 17:41:58 +0200", "Message-ID": "<20240902154212.1281257-6-mzamazal@redhat.com>", "In-Reply-To": "<20240902154212.1281257-1-mzamazal@redhat.com>", "References": "<20240902154212.1281257-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The includes that are not used can be removed.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/rkisp1/algorithms/agc.h | 1 -\n src/ipa/rkisp1/algorithms/awb.cpp | 4 ++--\n src/ipa/rkisp1/algorithms/ccm.cpp | 6 +-----\n src/ipa/rkisp1/algorithms/dpf.cpp | 4 +++-\n src/ipa/rkisp1/rkisp1.cpp | 7 ++++---\n src/ipa/rkisp1/utils.h | 1 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +--\n 7 files changed, 11 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\nindex d64ff42c..aa86f2c5 100644\n--- a/src/ipa/rkisp1/algorithms/agc.h\n+++ b/src/ipa/rkisp1/algorithms/agc.h\n@@ -15,7 +15,6 @@\n #include <libcamera/geometry.h>\n \n #include \"libipa/agc_mean_luminance.h\"\n-#include \"libipa/histogram.h\"\n \n #include \"algorithm.h\"\n \ndiff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex b40f405f..c6451719 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -8,12 +8,12 @@\n #include \"awb.h\"\n \n #include <algorithm>\n-#include <cmath>\n-#include <iomanip>\n+#include <ios>\n \n #include <libcamera/base/log.h>\n \n #include <libcamera/control_ids.h>\n+\n #include <libcamera/ipa/core_ipa_interface.h>\n \n /**\ndiff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex ca80112a..1ca0e73f 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -7,11 +7,7 @@\n \n #include \"ccm.h\"\n \n-#include <algorithm>\n-#include <chrono>\n-#include <cmath>\n-#include <tuple>\n-#include <vector>\n+#include <map>\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/utils.h>\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 079cc2c3..cb6095da 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -7,7 +7,9 @@\n \n #include \"dpf.h\"\n \n-#include <cmath>\n+#include <algorithm>\n+#include <string>\n+#include <vector>\n \n #include <libcamera/base/log.h>\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 79ae9289..a62fe151 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -6,8 +6,8 @@\n */\n \n #include <algorithm>\n-#include <math.h>\n-#include <queue>\n+#include <array>\n+#include <chrono>\n #include <stdint.h>\n #include <string.h>\n \n@@ -19,10 +19,11 @@\n \n #include <libcamera/control_ids.h>\n #include <libcamera/framebuffer.h>\n+#include <libcamera/request.h>\n+\n #include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n #include <libcamera/ipa/rkisp1_ipa_interface.h>\n-#include <libcamera/request.h>\n \n #include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\ndiff --git a/src/ipa/rkisp1/utils.h b/src/ipa/rkisp1/utils.h\nindex 450f2244..5f38b50b 100644\n--- a/src/ipa/rkisp1/utils.h\n+++ b/src/ipa/rkisp1/utils.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <cmath>\n-#include <limits>\n #include <type_traits>\n \n namespace libcamera {\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 710d9573..e521623b 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -6,10 +6,9 @@\n */\n \n #include <algorithm>\n-#include <array>\n-#include <iomanip>\n #include <memory>\n #include <numeric>\n+#include <optional>\n #include <queue>\n \n #include <linux/media-bus-format.h>\n", "prefixes": [ "v3", "05/18" ] }