Patch Detail
Show a patch.
GET /api/patches/21134/?format=api
{ "id": 21134, "url": "https://patchwork.libcamera.org/api/patches/21134/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21134/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240902154212.1281257-5-mzamazal@redhat.com>", "date": "2024-09-02T15:41:57", "name": "[v3,04/18] libcamera: ipu3: Formatting improvements", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "652e01dc5961c1876df597c47c8599a694f9d351", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21134/mbox/", "series": [ { "id": 4556, "url": "https://patchwork.libcamera.org/api/series/4556/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4556", "date": "2024-09-02T15:41:53", "name": "Remove unused includes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4556/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21134/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21134/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E8D4BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 2 Sep 2024 15:42:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16E4A634ED;\n\tMon, 2 Sep 2024 17:42:45 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2404634ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 2 Sep 2024 17:42:42 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-516-a3RHQRxRM92ZIzBKFovwjA-1;\n\tMon, 02 Sep 2024 11:42:38 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E89AE1954B09; Mon, 2 Sep 2024 15:42:37 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 3F87D1955F1B; Mon, 2 Sep 2024 15:42:35 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ODgk6RhN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291761;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=xqh1sKAO8+2rOet2zgx+mB15yi4vgAY5JtxH7Xv7upc=;\n\tb=ODgk6RhNBGOHmjnyGmkRlV0xk75D5Av842mN1fDBdyYmbvSTkRD2F84RiJjD/63uyCkqww\n\tfOH1NdqoEmeKon52Rk+Uoa8IKrMp3/nGITeJGGNbhecsKKK05hiui362iVaSbVrKU5SwZ2\n\tEtQrJMWagSScISrCrLBH8kAPw4NwVcM=", "X-MC-Unique": "a3RHQRxRM92ZIzBKFovwjA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 04/18] libcamera: ipu3: Formatting improvements", "Date": "Mon, 2 Sep 2024 17:41:57 +0200", "Message-ID": "<20240902154212.1281257-5-mzamazal@redhat.com>", "In-Reply-To": "<20240902154212.1281257-1-mzamazal@redhat.com>", "References": "<20240902154212.1281257-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The LSP autoformatter doesn't like some of the current formatting, let's\nmake it happier. Note that not all of its suggestions were accepted\nbecause readability is preferred and adjusting .clang-format may not be\neasy or possible.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n src/ipa/ipu3/algorithms/blc.cpp | 4 ++--\n src/ipa/ipu3/ipu3.cpp | 11 ++++++-----\n src/libcamera/pipeline/ipu3/ipu3.cpp | 17 +++++++++--------\n 4 files changed, 18 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 3378c4fd..c5f3d8f0 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -14,6 +14,7 @@\n #include <libcamera/base/utils.h>\n \n #include <libcamera/control_ids.h>\n+\n #include <libcamera/ipa/core_ipa_interface.h>\n \n #include \"libipa/histogram.h\"\n@@ -246,7 +247,6 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \tutils::Duration frameDuration = context.configuration.sensor.lineDuration\n \t\t\t\t * vTotal;\n \tmetadata.set(controls::FrameDuration, frameDuration.get<std::micro>());\n-\n }\n \n REGISTER_IPA_ALGORITHM(Agc, \"Agc\")\ndiff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp\nindex fa4b9272..35748fb2 100644\n--- a/src/ipa/ipu3/algorithms/blc.cpp\n+++ b/src/ipa/ipu3/algorithms/blc.cpp\n@@ -55,8 +55,8 @@ void BlackLevelCorrection::prepare([[maybe_unused]] IPAContext &context,\n \t * tuning processes. This is a first rough approximation.\n \t */\n \tparams->obgrid_param.gr = 64;\n-\tparams->obgrid_param.r = 64;\n-\tparams->obgrid_param.b = 64;\n+\tparams->obgrid_param.r = 64;\n+\tparams->obgrid_param.b = 64;\n \tparams->obgrid_param.gb = 64;\n \n \t/* Enable the custom black level correction processing */\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 9dcc89ae..6ebf7c1d 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -24,10 +24,11 @@\n \n #include <libcamera/control_ids.h>\n #include <libcamera/framebuffer.h>\n+#include <libcamera/request.h>\n+\n #include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n #include <libcamera/ipa/ipu3_ipa_interface.h>\n-#include <libcamera/request.h>\n \n #include \"libcamera/internal/mapped_framebuffer.h\"\n #include \"libcamera/internal/yaml_parser.h\"\n@@ -308,8 +309,8 @@ int IPAIPU3::init(const IPASettings &settings,\n \n \t/* Clean context */\n \tcontext_.configuration = {};\n-\tcontext_.configuration.sensor.lineDuration = sensorInfo.minLineLength\n-\t\t\t\t\t\t * 1.0s / sensorInfo.pixelRate;\n+\tcontext_.configuration.sensor.lineDuration =\n+\t\tsensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n \n \t/* Load the tuning data file. */\n \tFile file(settings.configurationFile);\n@@ -472,8 +473,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \tcontext_.frameContexts.clear();\n \n \t/* Initialise the sensor configuration. */\n-\tcontext_.configuration.sensor.lineDuration = sensorInfo_.minLineLength\n-\t\t\t\t\t\t * 1.0s / sensorInfo_.pixelRate;\n+\tcontext_.configuration.sensor.lineDuration =\n+\t\tsensorInfo_.minLineLength * 1.0s / sensorInfo_.pixelRate;\n \tcontext_.configuration.sensor.size = sensorInfo_.outputSize;\n \n \t/*\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 29172f34..430aa902 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -18,12 +18,13 @@\n #include <libcamera/camera.h>\n #include <libcamera/control_ids.h>\n #include <libcamera/formats.h>\n-#include <libcamera/ipa/ipu3_ipa_interface.h>\n-#include <libcamera/ipa/ipu3_ipa_proxy.h>\n #include <libcamera/property_ids.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n+#include <libcamera/ipa/ipu3_ipa_interface.h>\n+#include <libcamera/ipa/ipu3_ipa_proxy.h>\n+\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n@@ -1116,19 +1117,19 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t * returned through the ImgU main and secondary outputs.\n \t\t */\n \t\tdata->cio2_.bufferReady().connect(data.get(),\n-\t\t\t\t\t&IPU3CameraData::cio2BufferReady);\n+\t\t\t\t\t\t &IPU3CameraData::cio2BufferReady);\n \t\tdata->cio2_.bufferAvailable.connect(\n \t\t\tdata.get(), &IPU3CameraData::queuePendingRequests);\n \t\tdata->imgu_->input_->bufferReady.connect(&data->cio2_,\n-\t\t\t\t\t&CIO2Device::tryReturnBuffer);\n+\t\t\t\t\t\t\t &CIO2Device::tryReturnBuffer);\n \t\tdata->imgu_->output_->bufferReady.connect(data.get(),\n-\t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n+\t\t\t\t\t\t\t &IPU3CameraData::imguOutputBufferReady);\n \t\tdata->imgu_->viewfinder_->bufferReady.connect(data.get(),\n-\t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n+\t\t\t\t\t\t\t &IPU3CameraData::imguOutputBufferReady);\n \t\tdata->imgu_->param_->bufferReady.connect(data.get(),\n-\t\t\t\t\t&IPU3CameraData::paramBufferReady);\n+\t\t\t\t\t\t\t &IPU3CameraData::paramBufferReady);\n \t\tdata->imgu_->stat_->bufferReady.connect(data.get(),\n-\t\t\t\t\t&IPU3CameraData::statBufferReady);\n+\t\t\t\t\t\t\t&IPU3CameraData::statBufferReady);\n \n \t\t/* Create and register the Camera instance. */\n \t\tconst std::string &cameraId = cio2->sensor()->id();\n", "prefixes": [ "v3", "04/18" ] }