Patch Detail
Show a patch.
GET /api/patches/21128/?format=api
{ "id": 21128, "url": "https://patchwork.libcamera.org/api/patches/21128/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21128/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240831185927.125879-1-robert.mader@collabora.com>", "date": "2024-08-31T18:59:26", "name": "libcamera: debayer_cpu: Report buffer sync times", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "736837218a52a7969eca921fe75542fe3c8a0aae", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21128/mbox/", "series": [ { "id": 4554, "url": "https://patchwork.libcamera.org/api/series/4554/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4554", "date": "2024-08-31T18:59:26", "name": "libcamera: debayer_cpu: Report buffer sync times", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4554/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21128/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21128/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": [ "parsemail@patchwork.libcamera.org", "robert.mader@collabora.com" ], "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64C46C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 31 Aug 2024 19:00:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6759063471;\n\tSat, 31 Aug 2024 21:00:16 +0200 (CEST)", "from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com\n\t[136.143.188.10])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F24B61900\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 31 Aug 2024 21:00:13 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1725130809016294.34292254385946; \n\tSat, 31 Aug 2024 12:00:09 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"LwD+8pUJ\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1725130810; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=U+RHM42rBjaCb4VrJUduWGjyr2KC0i2uCfQ4vn19UgcWiAGoM+fL+a77FEOXYLVloSlQl2IvzFVpGhmmfgHRtIyJV1qGhbgkpN0yc5xbtNYTMNvLYjvHiVHw6rHZPpao9kUQiP99cSi5pR6dAkaNvPYSnu1jnHwKTLtZ0RR5O6A=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1725130810;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=mRGpj2r7GTtOpgoGMSinSGIxW6JGSD53mi31ysKAMn0=; \n\tb=ecoDsGxA6Ak5dKeKE1hjojoW9AvnlKnIDpx4fWV84P01XmXszmxDFS0vK+1UwiN+VFp7X+cJU2JYU6oOggSAiPgPX65zYUBPUK7nGoEc8QvV2VN6L3OQNMi1V7CSdoqkGuY04yPhhlIRkTcA5GQhb1iEEKGAni7cOP0RZvjlc00=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1725130810;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=mRGpj2r7GTtOpgoGMSinSGIxW6JGSD53mi31ysKAMn0=;\n\tb=LwD+8pUJQTpcal+YZ+o2CxZdy8HltPrDXhJma+Px90H5DA9MTLQolu/2d+AlHfBq\n\t8aMFNkynF8pjgd40dE2aUtY4986AMaZqrLnRBcbkxwvW/papSG6ztPvfjIKbXIxLff/\n\t8ZAIRs1wKX4GaXUHTUFOvb7IaxJWTD8JY4jnJKGA=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH] libcamera: debayer_cpu: Report buffer sync times", "Date": "Sat, 31 Aug 2024 20:59:26 +0200", "Message-ID": "<20240831185927.125879-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.46.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "---\n src/libcamera/software_isp/debayer_cpu.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 6c953b03..e51ab6ff 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -735,6 +735,8 @@ void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams\n \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime);\n \t}\n \n+\ttimespec time0 = {};\n+\tclock_gettime(CLOCK_MONOTONIC_RAW, &time0);\n \tfor (const FrameBuffer::Plane &plane : output->planes()) {\n \t\tconst int fd = plane.fd.get();\n \t\tstruct dma_buf_sync sync = { DMA_BUF_SYNC_START };\n@@ -744,6 +746,10 @@ void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams\n \t\tif (ioctl (fd, DMA_BUF_IOCTL_SYNC, &sync) < 0)\n \t\t\tLOG(Debayer, Error) << \"Syncing buffer FD \" << fd << \"failed: \" << errno;\n \t}\n+\ttimespec time1 = {};\n+\tclock_gettime(CLOCK_MONOTONIC_RAW, &time1);\n+\tint64_t time_sync = timeDiff(time1, time0);\n+\tLOG(Debayer, Warning) << \"Syncing input buffers start: \" << time_sync / 1000 << \"us\";\n \n \tgreen_ = params.green;\n \tred_ = swapRedBlueGains_ ? params.blue : params.red;\n@@ -772,6 +778,7 @@ void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams\n \n \tmetadata.planes()[0].bytesused = out.planes()[0].size();\n \n+\tclock_gettime(CLOCK_MONOTONIC_RAW, &time0);\n \tfor (const FrameBuffer::Plane &plane : output->planes()) {\n \t\tconst int fd = plane.fd.get();\n \t\tstruct dma_buf_sync sync = { DMA_BUF_SYNC_END };\n@@ -781,6 +788,9 @@ void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams\n \t\tif (ioctl (fd, DMA_BUF_IOCTL_SYNC, &sync) < 0)\n \t\t\tLOG(Debayer, Error) << \"Syncing buffer FD \" << fd << \"failed: \" << errno;\n \t}\n+\tclock_gettime(CLOCK_MONOTONIC_RAW, &time1);\n+\ttime_sync = timeDiff(time1, time0);\n+\tLOG(Debayer, Warning) << \"Syncing input buffers end: \" << time_sync / 1000 << \"us\";\n \n \t/* Measure before emitting signals */\n \tif (measuredFrames_ < DebayerCpu::kLastFrameToMeasure &&\n", "prefixes": [] }