Patch Detail
Show a patch.
GET /api/patches/20799/?format=api
{ "id": 20799, "url": "https://patchwork.libcamera.org/api/patches/20799/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20799/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240805143654.20870-14-laurent.pinchart@ideasonboard.com>", "date": "2024-08-05T14:36:49", "name": "[v5,13/18] libcamera: Don't add libcamera_public_headers to libcamera_public_sources", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "66e8a2b9d4f460cd5d3a58d40998cabd22fddea8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20799/mbox/", "series": [ { "id": 4488, "url": "https://patchwork.libcamera.org/api/series/4488/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4488", "date": "2024-08-05T14:36:36", "name": "Split libcamera documentation in public and internal APIs", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4488/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20799/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20799/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF31AC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Aug 2024 14:38:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 436B4633CE;\n\tMon, 5 Aug 2024 16:38:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFD08633B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 16:37:35 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42B74581\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 16:36:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iJGp4AfW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722868604;\n\tbh=mZwE4sCtry+LedLLMW1vya+wEL4sqITu/xo/xumq664=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=iJGp4AfWyfkovf+xzbKQGdi36xRmASKfFi2Bb1kq7TeEXEtfaO36eQoX9NMbTo36e\n\t8EtzLcntJAud+alL2a9BdD1PkXgKkevYJ/q+Xsuzk5NqBYWrwFkn9w8Xh2brEHaimP\n\t8uJGcK1IVhA/zKIcxenzsxnKEyUhP2lqp+mRULbA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v5 13/18] libcamera: Don't add libcamera_public_headers to\n\tlibcamera_public_sources", "Date": "Mon, 5 Aug 2024 17:36:49 +0300", "Message-ID": "<20240805143654.20870-14-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>", "References": "<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that libcamera_internal_sources is separate from\nlibcamera_internal_headers, perform the same split for\nlibcamera_public_sources and libcamera_public_headers to ensure\nconsistency of the build system variables.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 6a7c9d77dfd8..c3efc5278ec8 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -54,8 +54,6 @@ libcamera_internal_sources = files([\n 'yaml_parser.cpp',\n ])\n \n-libcamera_public_sources += libcamera_public_headers\n-\n includes = [\n libcamera_includes,\n ]\n@@ -193,6 +191,7 @@ libcamera_deps += [\n \n libcamera = shared_library('libcamera',\n [\n+ libcamera_public_headers,\n libcamera_public_sources,\n libcamera_ipa_headers,\n libcamera_internal_headers,\n", "prefixes": [ "v5", "13/18" ] }