Patch Detail
Show a patch.
GET /api/patches/20767/?format=api
{ "id": 20767, "url": "https://patchwork.libcamera.org/api/patches/20767/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20767/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240805100038.11972-2-jaslo@ziska.de>", "date": "2024-08-05T09:28:36", "name": "[1/3] gstreamer: Remove auto-focus-mode property", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "47b893945f1ee9b88bd99c884952e11cf2a569c2", "submitter": { "id": 173, "url": "https://patchwork.libcamera.org/api/people/173/?format=api", "name": "Jaslo Ziska", "email": "jaslo@ziska.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20767/mbox/", "series": [ { "id": 4485, "url": "https://patchwork.libcamera.org/api/series/4485/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4485", "date": "2024-08-05T09:28:35", "name": "gstreamer: Generate controls from control_ids_*.yaml files", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4485/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20767/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20767/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E027C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Aug 2024 10:01:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1F1063383;\n\tMon, 5 Aug 2024 12:01:42 +0200 (CEST)", "from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[81.169.146.219])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E4506337E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 12:01:41 +0200 (CEST)", "from archlinux.fritz.box by smtp.strato.de (RZmta 51.1.0 AUTH)\n\twith ESMTPSA id zb9f0a075A1evkF\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tMon, 5 Aug 2024 12:01:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ziska.de header.i=@ziska.de header.b=\"rsBIs5CN\";\n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"A5/WIWVE\"; dkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1722852101; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=EJLzDICVq1EixzfxKcNO1kceygMtm1XAKXq5pJSJ5oRtr3BlrNAWaoghT2XaiLhg3C\n\tDBstHEjYwImW0Wlpssx+UH0Exz2W1eaSv8d7dCX8PuJ6KGozQcnNDy4BtkO+h4QCJO75\n\t3UpFol17Mf3imJzDz2rXGxFwdJRAxDmk5YLvkAUjMC3vku/c6f3yZZGDgQLNHy0g96vi\n\tLg7sa1hnoX2sZabpxJqeNVwrRo/x6np9RTQlSQnuOznUCoyoXuM/NZ9UQK3OX90lj1kg\n\toU9V3xKNI74dLhGogZUhY+5NyMRB1pXEzmC4KRGz4AKxnRDn+Fex/wcjHsfbwu2SOiZw\n\tCv1g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; t=1722852101;\n\ts=strato-dkim-0002; d=strato.com;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=hiOd+hNFSxGfhI+NNFS30nToAf7iyESp67roLlCqKJg=;\n\tb=L7h6Zah4Zk3BIbxvQwmjJDHpjopdeMO0+4Rh++4C/E5t0gei5Qi1MIVeX5knpneEL6\n\tn4zw78vF2+CDF4jgaACS2xNgr+I421r/GmOLANq/G9cKrf61kc4nyz1a5sR2iRUVxT3W\n\t5Y/2285ZQUULBcHeHDrdZ2JQtwY/Tm5lzjaKdTCE7v1/flxyClOp0ay7pRNmDwElFUF4\n\t2aLFN9nhDr1/QRIHsRqJ0TbG5VosGuqPA5w24SQQk4v3HX5g3G++C6qSo/54zP6ccycS\n\tusWDdl9OSRfVkj8NnLIPU2cVbJCkxU6VA0MFBhAJkfjRH+Em24yV5D7OksTJET8DSXo0\n\tTaBA==", "ARC-Authentication-Results": "i=1; strato.com;\n arc=none;\n dkim=none", "X-RZG-CLASS-ID": "mo00", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; t=1722852101;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=hiOd+hNFSxGfhI+NNFS30nToAf7iyESp67roLlCqKJg=;\n\tb=rsBIs5CNxq8Op0WaI0+5qrK3Gt9Y3U4EpxFxCv+y36rUTO3FGKlO25yex/dCTIHCO7\n\t4kiPbbRTfFrQv8Czn51lBv7JAjLEZyhDzMktc/GfNuxyVqD+jazwCXQshl1QDMcrpijU\n\tceui48GblOSi7/FGrSw+A7VJu41Tz4W8plfVZgpM1yBreEyGMEoPRSTjF2buFQOAhGPh\n\ttUl6DB5SxneskO+OnMCPnXddu2y7sibMNqDqM3KRiR4F74c8UC3ieB6/4U/edLTrialy\n\tqePPG7sM2HhtjREpLLFeb4xxcslVDACC2/uINLrRfAZFPlx3y+6AxP92HP4yaXbnqMEO\n\tcfWA==", "v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1722852101;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=hiOd+hNFSxGfhI+NNFS30nToAf7iyESp67roLlCqKJg=;\n\tb=A5/WIWVEqmuaH2lS+Q+WTKCFVZC3PEB+SuGsefHWoGzZ/lluZvx2rK0ocX4Ub3OsXu\n\tcSrGWzY0JaQj0cYhvrCg==" ], "X-RZG-AUTH": "\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cCg4qxBvJaP2L5sFjJoIK+3CsR3+pCW/FVb/tK\"", "From": "Jaslo Ziska <jaslo@ziska.de>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jaslo Ziska <jaslo@ziska.de>", "Subject": "[PATCH 1/3] gstreamer: Remove auto-focus-mode property", "Date": "Mon, 5 Aug 2024 11:28:36 +0200", "Message-ID": "<20240805100038.11972-2-jaslo@ziska.de>", "X-Mailer": "git-send-email 2.46.0", "In-Reply-To": "<20240805100038.11972-1-jaslo@ziska.de>", "References": "<20240805100038.11972-1-jaslo@ziska.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation of the next commit remove the auto-focus-mode property\nfrom the libcamera element.\n\nSigned-off-by: Jaslo Ziska <jaslo@ziska.de>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 28 ----------------------------\n 1 file changed, 28 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex e1bb6b4c..5a3e2989 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -142,7 +142,6 @@ struct _GstLibcameraSrc {\n \tGstTask *task;\n \n \tgchar *camera_name;\n-\tcontrols::AfModeEnum auto_focus_mode = controls::AfModeManual;\n \n \tstd::atomic<GstEvent *> pending_eos;\n \n@@ -154,7 +153,6 @@ struct _GstLibcameraSrc {\n enum {\n \tPROP_0,\n \tPROP_CAMERA_NAME,\n-\tPROP_AUTO_FOCUS_MODE,\n };\n \n static void gst_libcamera_src_child_proxy_init(gpointer g_iface,\n@@ -663,18 +661,6 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \t\tgst_pad_push_event(srcpad, gst_event_new_segment(&segment));\n \t}\n \n-\tif (self->auto_focus_mode != controls::AfModeManual) {\n-\t\tconst ControlInfoMap &infoMap = state->cam_->controls();\n-\t\tif (infoMap.find(&controls::AfMode) != infoMap.end()) {\n-\t\t\tstate->initControls_.set(controls::AfMode, self->auto_focus_mode);\n-\t\t} else {\n-\t\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n-\t\t\t\t\t (\"Failed to enable auto focus\"),\n-\t\t\t\t\t (\"AfMode not supported by this camera, \"\n-\t\t\t\t\t \"please retry with 'auto-focus-mode=AfModeManual'\"));\n-\t\t}\n-\t}\n-\n \tret = state->cam_->start(&state->initControls_);\n \tif (ret) {\n \t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n@@ -742,9 +728,6 @@ gst_libcamera_src_set_property(GObject *object, guint prop_id,\n \t\tg_free(self->camera_name);\n \t\tself->camera_name = g_value_dup_string(value);\n \t\tbreak;\n-\tcase PROP_AUTO_FOCUS_MODE:\n-\t\tself->auto_focus_mode = static_cast<controls::AfModeEnum>(g_value_get_enum(value));\n-\t\tbreak;\n \tdefault:\n \t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n \t\tbreak;\n@@ -762,9 +745,6 @@ gst_libcamera_src_get_property(GObject *object, guint prop_id, GValue *value,\n \tcase PROP_CAMERA_NAME:\n \t\tg_value_set_string(value, self->camera_name);\n \t\tbreak;\n-\tcase PROP_AUTO_FOCUS_MODE:\n-\t\tg_value_set_enum(value, static_cast<gint>(self->auto_focus_mode));\n-\t\tbreak;\n \tdefault:\n \t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n \t\tbreak;\n@@ -967,14 +947,6 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \t\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n \tg_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n \n-\tspec = g_param_spec_enum(\"auto-focus-mode\",\n-\t\t\t\t \"Set auto-focus mode\",\n-\t\t\t\t \"Available options: AfModeManual, \"\n-\t\t\t\t \"AfModeAuto or AfModeContinuous.\",\n-\t\t\t\t gst_libcamera_auto_focus_get_type(),\n-\t\t\t\t static_cast<gint>(controls::AfModeManual),\n-\t\t\t\t G_PARAM_WRITABLE);\n-\tg_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, spec);\n }\n \n /* GstChildProxy implementation */\n", "prefixes": [ "1/3" ] }