Patch Detail
Show a patch.
GET /api/patches/20736/?format=api
{ "id": 20736, "url": "https://patchwork.libcamera.org/api/patches/20736/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20736/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240731183616.1977348-3-mzamazal@redhat.com>", "date": "2024-07-31T18:36:15", "name": "[v3,2/3] libcamera: ipa_proxy: Unify configurationFile argument name", "commit_ref": "58f83d70ebf3ae2b98a9ade8e173c19f555a890a", "pull_url": null, "state": "accepted", "archived": false, "hash": "0f8797789cd822608375f15057a116a6a10dd77a", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20736/mbox/", "series": [ { "id": 4471, "url": "https://patchwork.libcamera.org/api/series/4471/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4471", "date": "2024-07-31T18:36:13", "name": "Fix misleading error messages", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4471/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20736/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20736/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AEB1BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 31 Jul 2024 18:36:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B16E63378;\n\tWed, 31 Jul 2024 20:36:39 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C96496336F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Jul 2024 20:36:36 +0200 (CEST)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-39-vgZw0ntQN8Gfh_jjJaw1mQ-1;\n\tWed, 31 Jul 2024 14:36:31 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id A2F291955D4A; Wed, 31 Jul 2024 18:36:30 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.46])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A0B11300018D; Wed, 31 Jul 2024 18:36:28 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Sdg3aU8Y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722450995;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=G+nvhr/q2i3bcN8UWFM7TpLPBnN6VVbdMXuYPjmeSOo=;\n\tb=Sdg3aU8YAT6gQrlPizKyUo54YdiwMPSpo7naPnPR9qCBpxWig90uzZc8gQv/RRteqcIIB9\n\tLmZlDDqcHBTCpCZ3R00/xaQZ4Yat24/3eHne3xeW7SHA6RD1Vh4doLj+0Ht5PVSdlgIJZ3\n\thPlHNooS3AR5gvu2C/c6mQOGi1W1eds=", "X-MC-Unique": "vgZw0ntQN8Gfh_jjJaw1mQ-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 2/3] libcamera: ipa_proxy: Unify configurationFile\n\targument name", "Date": "Wed, 31 Jul 2024 20:36:15 +0200", "Message-ID": "<20240731183616.1977348-3-mzamazal@redhat.com>", "In-Reply-To": "<20240731183616.1977348-1-mzamazal@redhat.com>", "References": "<20240731183616.1977348-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The argument name is different in the declaration and the definition.\nLet's use the same one in both, namely `name'.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/ipa_proxy.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex ed6a5bcf..5240f69f 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -31,7 +31,7 @@ public:\n \n \tbool isValid() const { return valid_; }\n \n-\tstd::string configurationFile(const std::string &file) const;\n+\tstd::string configurationFile(const std::string &name) const;\n \n protected:\n \tstd::string resolvePath(const std::string &file) const;\n", "prefixes": [ "v3", "2/3" ] }