Patch Detail
Show a patch.
GET /api/patches/20733/?format=api
{ "id": 20733, "url": "https://patchwork.libcamera.org/api/patches/20733/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20733/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240731135936.2105-5-laurent.pinchart@ideasonboard.com>", "date": "2024-07-31T13:59:36", "name": "[v2,4/4] libcamera: software_isp: Remove file seal TODO item", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "32087161248d99a263fac0d62fcc1fb1958f9dd3", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20733/mbox/", "series": [ { "id": 4470, "url": "https://patchwork.libcamera.org/api/series/4470/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4470", "date": "2024-07-31T13:59:32", "name": "libcamera: Address soft ISP file seal TODO item", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4470/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20733/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20733/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8962BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 31 Jul 2024 14:00:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8383363378;\n\tWed, 31 Jul 2024 16:00:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FB0B6337E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Jul 2024 16:00:03 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FC8BF85\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Jul 2024 15:59:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HTFAuh4B\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722434355;\n\tbh=Knu62KiGoHOCCQU/vXuC0BXDHWrzsPsQ2qf1DsZw6QM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=HTFAuh4BkktOmblQ9Y/PYwrEdReXx+p1e+VYMWjCcgQ2vWA8fTyNWHeBOiIZZc7Xl\n\tMJ/938fx6ukyLpS3JmAxt6tdbk7VC4VrHWb1b9gPP2gYfLIYDOLb26fo/L9V1mkP5U\n\t1D0rINhv1VEVXdsHmkfBtjOjnzw1uQnfYlUVFLLE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 4/4] libcamera: software_isp: Remove file seal TODO item", "Date": "Wed, 31 Jul 2024 16:59:36 +0300", "Message-ID": "<20240731135936.2105-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>", "References": "<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The file seal TODO item has been addressed. Remove it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/software_isp/TODO | 19 -------------------\n 1 file changed, 19 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\nindex 6bdc590531ca..9978afc0317b 100644\n--- a/src/libcamera/software_isp/TODO\n+++ b/src/libcamera/software_isp/TODO\n@@ -1,22 +1,3 @@\n-1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()\n-\n->> SharedMem::SharedMem(const std::string &name, std::size_t size)\n->> \t: name_(name), size_(size), mem_(nullptr)\n->>\n->> ...\n->>\n->> \tif (ftruncate(fd_.get(), size_) < 0)\n->> \t\treturn;\n->\n-> Should we set the GROW and SHRINK seals (in a separate patch) ?\n-\n-Yes, this can be done.\n-Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch\n-some potential errors related to improper access to the shared memory allocated by\n-the SharedMemObject.\n-\n----\n-\n 2. Reconsider stats sharing\n \n >>> +void SwStatsCpu::finishFrame(void)\n", "prefixes": [ "v2", "4/4" ] }