Patch Detail
Show a patch.
GET /api/patches/20713/?format=api
{ "id": 20713, "url": "https://patchwork.libcamera.org/api/patches/20713/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20713/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240726114715.226468-5-umang.jain@ideasonboard.com>", "date": "2024-07-26T11:47:14", "name": "[v6,4/5] libcamera: converter: Add DW100 converter class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bfb9035d7d4a2afd141f23354e1629f4a719bb85", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20713/mbox/", "series": [ { "id": 4462, "url": "https://patchwork.libcamera.org/api/series/4462/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4462", "date": "2024-07-26T11:47:10", "name": "libcamera: rkisp1: Plumb the ConverterDW100 converter", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4462/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20713/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20713/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0A11BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jul 2024 11:47:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DE6663378;\n\tFri, 26 Jul 2024 13:47:38 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73D2A6199C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jul 2024 13:47:32 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47ECA8CC;\n\tFri, 26 Jul 2024 13:46:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uxeFkhNk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721994408;\n\tbh=g1L5ROJltTGOPcYCYXqk9+ly2EHbHenoJecEotA7u/o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uxeFkhNkE9V6H2kDpLNI0+2U6hVjz7B48RkDAR5UEOSrFbnEsfYpiW/jCs0bqF5/1\n\tSxCoAAR5pEJqtOeYja/Xl4yhETwlWV2hD7Lg0oud/N2VKOHEJCqqyNF8Fg1sV9ngMw\n\tdOyHdNLj+i265jGJo2Msy+AkpmFZxT2MXBjH2+m0=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v6 4/5] libcamera: converter: Add DW100 converter class", "Date": "Fri, 26 Jul 2024 17:17:14 +0530", "Message-ID": "<20240726114715.226468-5-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.0", "In-Reply-To": "<20240726114715.226468-1-umang.jain@ideasonboard.com>", "References": "<20240726114715.226468-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "DW100 Dewarp engine is present on i.MX8MP SoC. This patch\nprovides a converter class (inherited from V4L2M2MConverter).\n\nThe DW100 dewarp engine has scaling capabilites and can be used\nto set crop rectangles in the rkisp1 pipeline handler. Plumbing\nin the RkISP1 pipeline-handler is done in the subsequent patch.\n\nThe ConverterDW100 class can be extended later (as additional\ndevelopment) to support the dewarping by setting a dewarp vertex\nmap as well.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n .../internal/converter/converter_dw100.h | 24 ++++++++++++\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter/converter_dw100.cpp | 37 +++++++++++++++++++\n src/libcamera/converter/meson.build | 1 +\n 4 files changed, 63 insertions(+)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp", "diff": "diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nnew file mode 100644\nindex 00000000..dc41f365\n--- /dev/null\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#pragma once\n+\n+#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+\n+namespace libcamera {\n+\n+class MediaDevice;\n+class Rectangle;\n+class Stream;\n+\n+class ConverterDW100 : public V4L2M2MConverter\n+{\n+public:\n+\tConverterDW100(std::shared_ptr<MediaDevice> media);\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\nindex 891e79e7..85007a4b 100644\n--- a/include/libcamera/internal/converter/meson.build\n+++ b/include/libcamera/internal/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_headers += files([\n+ 'converter_dw100.h',\n 'converter_v4l2_m2m.h',\n ])\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nnew file mode 100644\nindex 00000000..eb9906f0\n--- /dev/null\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -0,0 +1,37 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#include \"libcamera/internal/converter/converter_dw100.h\"\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/geometry.h>\n+\n+#include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Converter)\n+\n+/**\n+ * \\class libcamera::ConverterDW100\n+ * \\brief The i.MX8MP dewarp converter implements the converter interface based\n+ * on V4L2 M2M device.\n+*/\n+\n+/**\n+ * \\fn ConverterDW100::ConverterDW100\n+ * \\brief Construct a ConverterDW100 instance\n+ * \\param[in] media The media device implementing the converter\n+ */\n+ConverterDW100::ConverterDW100(std::shared_ptr<MediaDevice> media)\n+\t: V4L2M2MConverter(media.get(), Feature::InputCrop)\n+{\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\nindex 2aa72fe4..175581b8 100644\n--- a/src/libcamera/converter/meson.build\n+++ b/src/libcamera/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_sources += files([\n+ 'converter_dw100.cpp',\n 'converter_v4l2_m2m.cpp'\n ])\n", "prefixes": [ "v6", "4/5" ] }