Patch Detail
Show a patch.
GET /api/patches/20698/?format=api
{ "id": 20698, "url": "https://patchwork.libcamera.org/api/patches/20698/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20698/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240723145736.81241-1-dse@thaumatec.com>", "date": "2024-07-23T14:56:25", "name": "[v2] libipa: camera_sensor_helper: Add OV5675 black level", "commit_ref": "7ee9ef451dfe6c07747b206a390455d4e8df1638", "pull_url": null, "state": "accepted", "archived": false, "hash": "ca19eeebfdebb955054023a80a99dddb3ac41540", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20698/mbox/", "series": [ { "id": 4458, "url": "https://patchwork.libcamera.org/api/series/4458/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4458", "date": "2024-07-23T14:56:25", "name": "[v2] libipa: camera_sensor_helper: Add OV5675 black level", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4458/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20698/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20698/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57B7DC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Jul 2024 14:57:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56AD66336F;\n\tTue, 23 Jul 2024 16:57:49 +0200 (CEST)", "from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BEB2619A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jul 2024 16:57:48 +0200 (CEST)", "by mail-ej1-x629.google.com with SMTP id\n\ta640c23a62f3a-a7a47e2179dso116167366b.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jul 2024 07:57:48 -0700 (PDT)", "from localhost.localdomain ([91.90.172.13])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a7a3c8bebe5sm545435066b.119.2024.07.23.07.57.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 23 Jul 2024 07:57:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=thaumatec-com.20230601.gappssmtp.com\n\theader.i=@thaumatec-com.20230601.gappssmtp.com\n\theader.b=\"KkTgxRqk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1721746668;\n\tx=1722351468; darn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=+SYu0mM/EE1bMPonVnwYsdoQ69mbTmYNe89fWbxySgU=;\n\tb=KkTgxRqk5+1BCWtgJeM9IdaaUQ8SWtHhJAfp87Dm1sdr96u2jJ76z1FIXN5YG32E/6\n\tmQkENjK4Jh/aae28aCpb5gPOREOjxiMrq44MAKXeVsI33wqmi7yngpQtBnxOec5pZWht\n\tI3HgFbS6G+QtN1hqiKSWZEZ+3/ACstPAIvvw9hzNjk+QLy149Osi4UGZ+Dn0G2NHUGQ+\n\t0ZnUxnswJ09KugKsZq6KHphCJcPowAERL/0AEocFcTRSBrsRm6SONevh3cmqiz6Y6h9i\n\tv2tkG9Rpvg3keRvXmW1WgRqUYOTGh0EBalBZaq3aCc/t/tHh5Dl75B/YpuJdluGyh09C\n\tQCRg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1721746668; x=1722351468;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=+SYu0mM/EE1bMPonVnwYsdoQ69mbTmYNe89fWbxySgU=;\n\tb=Sjo6P1XJ6ItPo+7RSfJa24pk0Aas0M+NS3Xn02spRBbKEoR9vwBYsAuM656UXQji1z\n\t6c55fi/JK3alQ3w2l8ms7EjusILEq1cq9hrEjVO8ZfYfAbRP7fvdxhbbHkKvOZMOEotN\n\tKPFmCQ8VbTbvreim6XlfRXzPTUZVPzhE1vLfCzqVIl1MMb0gkXvFgtV91mnic72ZzFbM\n\tsIWce7/BtO+TBJEVvR23I7wz4SRho31cVW9Xma6/4jrEyvXX/yKRc+f+8IffxJVb7aD6\n\tqXvK6iQMYAlIkgjgBGkKuggRTDRlbm4UWDDJ8RgR4c3uo1aYnTDMfO2oodIMhHZab66s\n\thH6g==", "X-Gm-Message-State": "AOJu0YwrN8C2EaCMbxaL8PIHVnQ41qwXqfQNqe5fvvbi+6j8xVWxHUZU\n\tCdMu6khzB+pJC1mb2j64hQ0GNWXC5UisE9nZaKyr67zdlKXs0K2bmtdgz19vilYB1Bj24lykaBK\n\tO", "X-Google-Smtp-Source": "AGHT+IHNYcjaZ3y0Y5uYJkanm9hHAinxklbiiZAVwauqsp/R1VAfxvpaIKFUQb2T1jxJuDFoNamFJw==", "X-Received": "by 2002:a17:906:7955:b0:a72:7245:ec0a with SMTP id\n\ta640c23a62f3a-a7a8861ab92mr248906766b.58.1721746667613; \n\tTue, 23 Jul 2024 07:57:47 -0700 (PDT)", "From": "Daniel Semkowicz <dse@thaumatec.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Semkowicz <dse@thaumatec.com>", "Subject": "[PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level", "Date": "Tue, 23 Jul 2024 16:56:25 +0200", "Message-ID": "<20240723145736.81241-1-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.45.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add black level value for OV5675 camera sensor.\nAccording to datasheet, default value is 0x10, 10 bits width.\nHowever, Linux kernel driver initializes black level target value\nto 0x40. Set the value to the same as in kernel driver, but scaled\nto 16 bits.\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex a1339c83..29a00d7f 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -601,6 +601,8 @@ class CameraSensorHelperOv5675 : public CameraSensorHelper\n public:\n \tCameraSensorHelperOv5675()\n \t{\n+\t\t/* From Linux kernel driver: 0x40 at 10bits. */\n+\t\tblackLevel_ = 4096;\n \t\tgainType_ = AnalogueGainLinear;\n \t\tgainConstants_.linear = { 1, 0, 0, 128 };\n \t}\n", "prefixes": [ "v2" ] }