Patch Detail
Show a patch.
GET /api/patches/20694/?format=api
{ "id": 20694, "url": "https://patchwork.libcamera.org/api/patches/20694/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20694/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240717100913.16640-9-jacopo.mondi@ideasonboard.com>", "date": "2024-07-17T10:09:11", "name": "[RFC,8/9] dw100: fixup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "89f5981ff644ca3fc4165b4fb44d9a2460d082af", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20694/mbox/", "series": [ { "id": 4455, "url": "https://patchwork.libcamera.org/api/series/4455/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4455", "date": "2024-07-17T10:09:03", "name": "Handle Converter features differently", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4455/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20694/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20694/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DECAC3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Jul 2024 10:09:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 736E56338D;\n\tWed, 17 Jul 2024 12:09:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 650676337E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Jul 2024 12:09:30 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B360B0B;\n\tWed, 17 Jul 2024 12:08:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sNlV+8HQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721210932;\n\tbh=bBdgHxb/bKL2OPNxdQuIixlBev03dXKtpNPMIy6GDDc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sNlV+8HQQfC7LZ196grkUh8YC6yXytY91odhWLBPQkw1zs3Oi7V26fG0dFf/MOWKe\n\tRU26kPyMvo/uIsXn6XhwWtbY5unfslXt0PO5n4nbQpz3Jj3YVRoE+YtHzkYzb8gCII\n\t0FIYnIXaMnP6AyNvz/U7mGHgqIeb1uMgfnUG6Tt8=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "Umang Jain <umang.jain@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[RFC 8/9] dw100: fixup", "Date": "Wed, 17 Jul 2024 12:09:11 +0200", "Message-ID": "<20240717100913.16640-9-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "References": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n .../libcamera/internal/converter/converter_dw100.h | 2 +-\n src/libcamera/converter/converter_dw100.cpp | 11 +++++++++--\n 2 files changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nindex dc41f365b5c7..ee82b99e8d9d 100644\n--- a/include/libcamera/internal/converter/converter_dw100.h\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -18,7 +18,7 @@ class Stream;\n class ConverterDW100 : public V4L2M2MConverter\n {\n public:\n-\tConverterDW100(std::shared_ptr<MediaDevice> media);\n+\tConverterDW100(MediaDevice *media, Converter::Features features);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nindex 3061fc71dd80..09ede8d0c216 100644\n--- a/src/libcamera/converter/converter_dw100.cpp\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -29,9 +29,16 @@ LOG_DECLARE_CATEGORY(Converter)\n * \\brief Construct a ConverterDW100 instance\n * \\param[in] media The media device implementing the converter\n */\n-ConverterDW100::ConverterDW100(std::shared_ptr<MediaDevice> media)\n-\t: V4L2M2MConverter(media.get(), Feature::Crop)\n+ConverterDW100::ConverterDW100(MediaDevice *media, Converter::Features features)\n+\t: V4L2M2MConverter(media, features)\n {\n }\n \n+static std::initializer_list<std::string> compatibles = {\n+\t\"dw100\",\n+};\n+\n+REGISTER_CONVERTER(\"dw100\", ConverterDW100, compatibles,\n+\t\t Converter::Feature::Crop)\n+\n } /* namespace libcamera */\n", "prefixes": [ "RFC", "8/9" ] }